From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
pavel@ucw.cz, dmurphy@ti.com, jacek.anaszewski@gmail.com,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] leds: lp50xx: Fix an error handling path in 'lp50xx_probe_dt()'
Date: Thu, 24 Sep 2020 06:49:32 +0000 [thread overview]
Message-ID: <20200924064932.GP18329@kadam> (raw)
In-Reply-To: <faa49efc-5ba5-b6bd-b486-2f7c4611219b@wanadoo.fr>
On Wed, Sep 23, 2020 at 08:49:56PM +0200, Christophe JAILLET wrote:
> Le 23/09/2020 à 15:35, Dan Carpenter a écrit :
> > I've added Heikki Krogerus to the CC list because my question is mostly
> > about commit 59abd83672f7 ("drivers: base: Introducing software nodes to
> > the firmware node framework").
> >
> > I have been trying to teach Smatch to understand reference counting so
> > it can discover these kinds of bugs automatically.
> >
> > I don't know how software_node_get_next_child() can work when it doesn't
> > call kobject_get(). This sort of bug would have been caught in testing
> > because it affects the success path so I must be reading the code wrong.
> >
>
> I had the same reading of the code and thought that I was missing something
> somewhere.
>
> There is the same question about 'acpi_get_next_subnode' which is also a
> '.get_next_child_node' function, without any ref counting, if I'm correct.
>
Yeah, but there aren't any ->get/put() ops for the acpi_get_next_subnode()
stuff so it's not a problem. (Presumably there is some other sort of
refcounting policy there).
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
pavel@ucw.cz, dmurphy@ti.com, jacek.anaszewski@gmail.com,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] leds: lp50xx: Fix an error handling path in 'lp50xx_probe_dt()'
Date: Thu, 24 Sep 2020 09:49:32 +0300 [thread overview]
Message-ID: <20200924064932.GP18329@kadam> (raw)
In-Reply-To: <faa49efc-5ba5-b6bd-b486-2f7c4611219b@wanadoo.fr>
On Wed, Sep 23, 2020 at 08:49:56PM +0200, Christophe JAILLET wrote:
> Le 23/09/2020 à 15:35, Dan Carpenter a écrit :
> > I've added Heikki Krogerus to the CC list because my question is mostly
> > about commit 59abd83672f7 ("drivers: base: Introducing software nodes to
> > the firmware node framework").
> >
> > I have been trying to teach Smatch to understand reference counting so
> > it can discover these kinds of bugs automatically.
> >
> > I don't know how software_node_get_next_child() can work when it doesn't
> > call kobject_get(). This sort of bug would have been caught in testing
> > because it affects the success path so I must be reading the code wrong.
> >
>
> I had the same reading of the code and thought that I was missing something
> somewhere.
>
> There is the same question about 'acpi_get_next_subnode' which is also a
> '.get_next_child_node' function, without any ref counting, if I'm correct.
>
Yeah, but there aren't any ->get/put() ops for the acpi_get_next_subnode()
stuff so it's not a problem. (Presumably there is some other sort of
refcounting policy there).
regards,
dan carpenter
next prev parent reply other threads:[~2020-09-24 6:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 21:05 [PATCH] leds: lp50xx: Fix an error handling path in 'lp50xx_probe_dt()' Christophe JAILLET
2020-09-22 21:05 ` Christophe JAILLET
2020-09-23 13:27 ` Dan Murphy
2020-09-23 13:27 ` Dan Murphy
2020-09-23 13:35 ` Dan Carpenter
2020-09-23 13:35 ` Dan Carpenter
2020-09-23 18:49 ` Christophe JAILLET
2020-09-23 18:49 ` Christophe JAILLET
2020-09-24 6:49 ` Dan Carpenter [this message]
2020-09-24 6:49 ` Dan Carpenter
2020-09-28 11:53 ` Heikki Krogerus
2020-09-28 11:53 ` Heikki Krogerus
2020-11-25 10:46 ` Pavel Machek
2020-11-25 10:46 ` Pavel Machek
2020-11-25 12:16 ` Heikki Krogerus
2020-11-25 12:16 ` Heikki Krogerus
2020-11-25 11:01 ` Pavel Machek
2020-11-25 11:01 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924064932.GP18329@kadam \
--to=dan.carpenter@oracle.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dmurphy@ti.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jacek.anaszewski@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.