From: Baoquan He <bhe@redhat.com>
To: Alexander Egorenkov <egorenar@linux.ibm.com>
Cc: keescook@chromium.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, ktkhai@virtuozzo.com,
ebiederm@xmission.com, akpm@linux-foundation.org,
dyoung@redhat.com, christian.brauner@ubuntu.com,
vgoyal@redhat.com
Subject: Re: [PATCH v2 1/1] kdump: append uts_namespace.name offset to VMCOREINFO
Date: Fri, 25 Sep 2020 11:18:50 +0800 [thread overview]
Message-ID: <20200925031850.GO25604@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20200924124647.300080-1-egorenar@linux.ibm.com>
On 09/24/20 at 02:46pm, Alexander Egorenkov wrote:
> The offset of the field 'init_uts_ns.name' has changed
> since
>
> commit 9a56493f6942c0e2df1579986128721da96e00d8
> Author: Kirill Tkhai <ktkhai@virtuozzo.com>
> Date: Mon Aug 3 13:16:21 2020 +0300
>
> uts: Use generic ns_common::count
>
> Link: https://lore.kernel.org/r/159644978167.604812.1773586504374412107.stgit@localhost.localdomain
Seems there's some argument about the generic ns_common::count in the
thread of above link. While except of it, the adding the offset of
uts_namespace.name looks good to me.
Acked-by: Baoquan He <bhe@redhat.com>
>
> Make the offset of the field 'uts_namespace.name' available
> in VMCOREINFO because tools like 'crash-utility' and
> 'makedumpfile' must be able to read it from crash dumps.
>
> Signed-off-by: Alexander Egorenkov <egorenar@linux.ibm.com>
> ---
> kernel/crash_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index 106e4500fd53..173fdc261882 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -447,6 +447,7 @@ static int __init crash_save_vmcoreinfo_init(void)
> VMCOREINFO_PAGESIZE(PAGE_SIZE);
>
> VMCOREINFO_SYMBOL(init_uts_ns);
> + VMCOREINFO_OFFSET(uts_namespace, name);
> VMCOREINFO_SYMBOL(node_online_map);
> #ifdef CONFIG_MMU
> VMCOREINFO_SYMBOL_ARRAY(swapper_pg_dir);
> --
> 2.26.2
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Alexander Egorenkov <egorenar@linux.ibm.com>
Cc: dyoung@redhat.com, vgoyal@redhat.com, ebiederm@xmission.com,
akpm@linux-foundation.org, ktkhai@virtuozzo.com,
keescook@chromium.org, christian.brauner@ubuntu.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] kdump: append uts_namespace.name offset to VMCOREINFO
Date: Fri, 25 Sep 2020 11:18:50 +0800 [thread overview]
Message-ID: <20200925031850.GO25604@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20200924124647.300080-1-egorenar@linux.ibm.com>
On 09/24/20 at 02:46pm, Alexander Egorenkov wrote:
> The offset of the field 'init_uts_ns.name' has changed
> since
>
> commit 9a56493f6942c0e2df1579986128721da96e00d8
> Author: Kirill Tkhai <ktkhai@virtuozzo.com>
> Date: Mon Aug 3 13:16:21 2020 +0300
>
> uts: Use generic ns_common::count
>
> Link: https://lore.kernel.org/r/159644978167.604812.1773586504374412107.stgit@localhost.localdomain
Seems there's some argument about the generic ns_common::count in the
thread of above link. While except of it, the adding the offset of
uts_namespace.name looks good to me.
Acked-by: Baoquan He <bhe@redhat.com>
>
> Make the offset of the field 'uts_namespace.name' available
> in VMCOREINFO because tools like 'crash-utility' and
> 'makedumpfile' must be able to read it from crash dumps.
>
> Signed-off-by: Alexander Egorenkov <egorenar@linux.ibm.com>
> ---
> kernel/crash_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index 106e4500fd53..173fdc261882 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -447,6 +447,7 @@ static int __init crash_save_vmcoreinfo_init(void)
> VMCOREINFO_PAGESIZE(PAGE_SIZE);
>
> VMCOREINFO_SYMBOL(init_uts_ns);
> + VMCOREINFO_OFFSET(uts_namespace, name);
> VMCOREINFO_SYMBOL(node_online_map);
> #ifdef CONFIG_MMU
> VMCOREINFO_SYMBOL_ARRAY(swapper_pg_dir);
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-09-25 3:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 12:46 [PATCH v2 1/1] kdump: append uts_namespace.name offset to VMCOREINFO Alexander Egorenkov
2020-09-24 12:46 ` Alexander Egorenkov
2020-09-25 3:18 ` Baoquan He [this message]
2020-09-25 3:18 ` Baoquan He
2020-09-25 5:23 ` Bhupesh Sharma
2020-09-25 5:23 ` Bhupesh Sharma
2020-09-30 9:25 ` lijiang
2020-09-30 9:25 ` lijiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925031850.GO25604@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=christian.brauner@ubuntu.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=egorenar@linux.ibm.com \
--cc=keescook@chromium.org \
--cc=kexec@lists.infradead.org \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.