From: Tony Lindgren <tony@atomide.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: khilman@kernel.org, linux@armlinux.org.uk,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org
Subject: Re: [PATCH v2] omap3: enable off mode automatically
Date: Fri, 25 Sep 2020 14:34:59 +0300 [thread overview]
Message-ID: <20200925113459.GI9471@atomide.com> (raw)
In-Reply-To: <20200924070550.GG9471@atomide.com>
* Tony Lindgren <tony@atomide.com> [200924 07:06]:
> * Andreas Kemnade <andreas@kemnade.info> [200924 07:00]:
> > On Fri, 11 Sep 2020 18:12:09 +0200
> > Andreas Kemnade <andreas@kemnade.info> wrote:
> >
> > > Enabling off mode was only reachable deeply hidden
> > > in the debugfs. As powersaving is an important feature,
> > > move the option out of its shady place.
> > > The debugfs file can still be used to override the default.
> > >
> > > Use the presence of a device compatible to ti,twl4030-idle or
> > > ti,twl4030-idle-osc-off as an indicator that the board is wired correctly
> > > for off mode.
> > >
> > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > > ---
> > > An earlier version of this patch was here:
> > > https://patchwork.kernel.org/patch/10794121/
> > >
> > > A config option was used instead of the suggested devicetree check.
> > >
> > > Changes in v2:
> > > - fix compile without CONFIG_ARCH_OMAP3
> > > The variable enable_off_mode is now always a real one and not
> > > a preprocessor constant to avoid trouble with unusual configurations.
> > >
> > Anything I still missed here?
>
> No the missing part is just me picking up the remaining patches
> for v5.10 that I'll hopefully manage to do today :)
Applied now in omap-for-v5.10/soc thanks.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: linux-omap@vger.kernel.org, khilman@kernel.org,
linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
letux-kernel@openphoenux.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] omap3: enable off mode automatically
Date: Fri, 25 Sep 2020 14:34:59 +0300 [thread overview]
Message-ID: <20200925113459.GI9471@atomide.com> (raw)
In-Reply-To: <20200924070550.GG9471@atomide.com>
* Tony Lindgren <tony@atomide.com> [200924 07:06]:
> * Andreas Kemnade <andreas@kemnade.info> [200924 07:00]:
> > On Fri, 11 Sep 2020 18:12:09 +0200
> > Andreas Kemnade <andreas@kemnade.info> wrote:
> >
> > > Enabling off mode was only reachable deeply hidden
> > > in the debugfs. As powersaving is an important feature,
> > > move the option out of its shady place.
> > > The debugfs file can still be used to override the default.
> > >
> > > Use the presence of a device compatible to ti,twl4030-idle or
> > > ti,twl4030-idle-osc-off as an indicator that the board is wired correctly
> > > for off mode.
> > >
> > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > > ---
> > > An earlier version of this patch was here:
> > > https://patchwork.kernel.org/patch/10794121/
> > >
> > > A config option was used instead of the suggested devicetree check.
> > >
> > > Changes in v2:
> > > - fix compile without CONFIG_ARCH_OMAP3
> > > The variable enable_off_mode is now always a real one and not
> > > a preprocessor constant to avoid trouble with unusual configurations.
> > >
> > Anything I still missed here?
>
> No the missing part is just me picking up the remaining patches
> for v5.10 that I'll hopefully manage to do today :)
Applied now in omap-for-v5.10/soc thanks.
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-25 11:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 16:12 [PATCH v2] omap3: enable off mode automatically Andreas Kemnade
2020-09-11 16:12 ` Andreas Kemnade
2020-09-24 7:00 ` Andreas Kemnade
2020-09-24 7:00 ` Andreas Kemnade
2020-09-24 7:05 ` Tony Lindgren
2020-09-24 7:05 ` Tony Lindgren
2020-09-25 11:34 ` Tony Lindgren [this message]
2020-09-25 11:34 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925113459.GI9471@atomide.com \
--to=tony@atomide.com \
--cc=andreas@kemnade.info \
--cc=khilman@kernel.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.