* [LTP] [PATCH 1/2] Fix formatting signal name in tst_strstatus()
@ 2020-09-24 14:42 Martin Doucha
2020-09-24 14:42 ` [LTP] [PATCH 2/2] mmap18: Increase minimal stack mapping to 8KB Martin Doucha
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Martin Doucha @ 2020-09-24 14:42 UTC (permalink / raw)
To: ltp
Signed-off-by: Martin Doucha <mdoucha@suse.cz>
---
lib/tst_status.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/tst_status.c b/lib/tst_status.c
index f1affeac5..9124faaa3 100644
--- a/lib/tst_status.c
+++ b/lib/tst_status.c
@@ -20,7 +20,8 @@ const char *exited(int status)
const char *signaled(int status)
{
- snprintf(buf, sizeof(buf), "killed by %s", tst_strsig(status));
+ snprintf(buf, sizeof(buf), "killed by %s",
+ tst_strsig(WTERMSIG(status)));
return buf;
}
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [LTP] [PATCH 2/2] mmap18: Increase minimal stack mapping to 8KB
2020-09-24 14:42 [LTP] [PATCH 1/2] Fix formatting signal name in tst_strstatus() Martin Doucha
@ 2020-09-24 14:42 ` Martin Doucha
2020-09-25 10:12 ` Li Wang
2020-09-25 12:34 ` Cyril Hrubis
2020-09-25 3:20 ` [LTP] [PATCH 1/2] Fix formatting signal name in tst_strstatus() Li Wang
2020-09-25 12:24 ` Cyril Hrubis
2 siblings, 2 replies; 6+ messages in thread
From: Martin Doucha @ 2020-09-24 14:42 UTC (permalink / raw)
To: ltp
The first testcase keeps segfaulting on older kernels with only 4KB initial
stack mapping
Signed-off-by: Martin Doucha <mdoucha@suse.cz>
---
Note: Increasing initial stack size to 8KB fixes the segfaults but I'm not
entirely sure whether we shouldn't use PTHREAD_STACK_MIN as the minimal size
instead. Pthread man page isn't entirely clear whether PTHREAD_STACK_MIN is
the minimal value for stack size after it grows to the limit, or the minimal
size of the initial stack mapping (before it starts growing).
On x86_64, PTHREAD_STACK_MIN is 4 pages (16KB). On PPC64, it's 2 pages
(128KB).
testcases/kernel/syscalls/mmap/mmap18.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/testcases/kernel/syscalls/mmap/mmap18.c b/testcases/kernel/syscalls/mmap/mmap18.c
index 966bf673e..8b149fb93 100644
--- a/testcases/kernel/syscalls/mmap/mmap18.c
+++ b/testcases/kernel/syscalls/mmap/mmap18.c
@@ -201,10 +201,11 @@ static void grow_stack_fail(size_t stack_size, size_t mapped_size)
static void run_test(void)
{
size_t stack_size = 8 * PTHREAD_STACK_MIN;
+ size_t minsize = MAX(page_size, 8192);
- grow_stack_success(stack_size, page_size);
+ grow_stack_success(stack_size, minsize);
grow_stack_success(stack_size, stack_size/2);
- grow_stack_fail(stack_size, page_size);
+ grow_stack_fail(stack_size, minsize);
grow_stack_fail(stack_size, stack_size/2);
}
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [LTP] [PATCH 2/2] mmap18: Increase minimal stack mapping to 8KB
2020-09-24 14:42 ` [LTP] [PATCH 2/2] mmap18: Increase minimal stack mapping to 8KB Martin Doucha
@ 2020-09-25 10:12 ` Li Wang
2020-09-25 12:34 ` Cyril Hrubis
1 sibling, 0 replies; 6+ messages in thread
From: Li Wang @ 2020-09-25 10:12 UTC (permalink / raw)
To: ltp
On Thu, Sep 24, 2020 at 10:43 PM Martin Doucha <mdoucha@suse.cz> wrote:
> The first testcase keeps segfaulting on older kernels with only 4KB initial
> stack mapping
>
> Signed-off-by: Martin Doucha <mdoucha@suse.cz>
>
Reviewed-by: Li Wang <liwang@redhat.com>
> ---
>
> Note: Increasing initial stack size to 8KB fixes the segfaults but I'm not
> entirely sure whether we shouldn't use PTHREAD_STACK_MIN as the minimal
> size
> instead. Pthread man page isn't entirely clear whether PTHREAD_STACK_MIN
> is
> the minimal value for stack size after it grows to the limit, or the
> minimal
> size of the initial stack mapping (before it starts growing).
>
I slightly think the latter, which means PTHREAD_STACK_MIN is the minimal
size of the initial stack mapping. So maybe better to use the
PTHREAD_STACK_MIN
as mmaped_size, we even don't need to have a MAX() there.
>
> On x86_64, PTHREAD_STACK_MIN is 4 pages (16KB). On PPC64, it's 2 pages
> (128KB).
> testcases/kernel/syscalls/mmap/mmap18.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/mmap/mmap18.c
> b/testcases/kernel/syscalls/mmap/mmap18.c
> index 966bf673e..8b149fb93 100644
> --- a/testcases/kernel/syscalls/mmap/mmap18.c
> +++ b/testcases/kernel/syscalls/mmap/mmap18.c
> @@ -201,10 +201,11 @@ static void grow_stack_fail(size_t stack_size,
> size_t mapped_size)
> static void run_test(void)
> {
> size_t stack_size = 8 * PTHREAD_STACK_MIN;
> + size_t minsize = MAX(page_size, 8192);
>
> - grow_stack_success(stack_size, page_size);
> + grow_stack_success(stack_size, minsize);
> grow_stack_success(stack_size, stack_size/2);
> - grow_stack_fail(stack_size, page_size);
> + grow_stack_fail(stack_size, minsize);
> grow_stack_fail(stack_size, stack_size/2);
> }
>
> --
> 2.28.0
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
>
>
--
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20200925/9be3da58/attachment.htm>
^ permalink raw reply [flat|nested] 6+ messages in thread* [LTP] [PATCH 2/2] mmap18: Increase minimal stack mapping to 8KB
2020-09-24 14:42 ` [LTP] [PATCH 2/2] mmap18: Increase minimal stack mapping to 8KB Martin Doucha
2020-09-25 10:12 ` Li Wang
@ 2020-09-25 12:34 ` Cyril Hrubis
1 sibling, 0 replies; 6+ messages in thread
From: Cyril Hrubis @ 2020-09-25 12:34 UTC (permalink / raw)
To: ltp
Hi!
> The first testcase keeps segfaulting on older kernels with only 4KB initial
> stack mapping
>
> Signed-off-by: Martin Doucha <mdoucha@suse.cz>
> ---
>
> Note: Increasing initial stack size to 8KB fixes the segfaults but I'm not
> entirely sure whether we shouldn't use PTHREAD_STACK_MIN as the minimal size
> instead. Pthread man page isn't entirely clear whether PTHREAD_STACK_MIN is
> the minimal value for stack size after it grows to the limit, or the minimal
> size of the initial stack mapping (before it starts growing).
I vote for passing down PTHREAD_STACK_MIN for the initial mapping.
> On x86_64, PTHREAD_STACK_MIN is 4 pages (16KB). On PPC64, it's 2 pages
> (128KB).
>
> testcases/kernel/syscalls/mmap/mmap18.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/mmap/mmap18.c b/testcases/kernel/syscalls/mmap/mmap18.c
> index 966bf673e..8b149fb93 100644
> --- a/testcases/kernel/syscalls/mmap/mmap18.c
> +++ b/testcases/kernel/syscalls/mmap/mmap18.c
> @@ -201,10 +201,11 @@ static void grow_stack_fail(size_t stack_size, size_t mapped_size)
> static void run_test(void)
> {
> size_t stack_size = 8 * PTHREAD_STACK_MIN;
> + size_t minsize = MAX(page_size, 8192);
>
> - grow_stack_success(stack_size, page_size);
> + grow_stack_success(stack_size, minsize);
> grow_stack_success(stack_size, stack_size/2);
> - grow_stack_fail(stack_size, page_size);
> + grow_stack_fail(stack_size, minsize);
> grow_stack_fail(stack_size, stack_size/2);
> }
>
> --
> 2.28.0
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 6+ messages in thread
* [LTP] [PATCH 1/2] Fix formatting signal name in tst_strstatus()
2020-09-24 14:42 [LTP] [PATCH 1/2] Fix formatting signal name in tst_strstatus() Martin Doucha
2020-09-24 14:42 ` [LTP] [PATCH 2/2] mmap18: Increase minimal stack mapping to 8KB Martin Doucha
@ 2020-09-25 3:20 ` Li Wang
2020-09-25 12:24 ` Cyril Hrubis
2 siblings, 0 replies; 6+ messages in thread
From: Li Wang @ 2020-09-25 3:20 UTC (permalink / raw)
To: ltp
On Thu, Sep 24, 2020 at 10:43 PM Martin Doucha <mdoucha@suse.cz> wrote:
> Signed-off-by: Martin Doucha <mdoucha@suse.cz>
>
Acked-by: Li Wang <liwang@redhat.com>
> ---
> lib/tst_status.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/tst_status.c b/lib/tst_status.c
> index f1affeac5..9124faaa3 100644
> --- a/lib/tst_status.c
> +++ b/lib/tst_status.c
> @@ -20,7 +20,8 @@ const char *exited(int status)
>
> const char *signaled(int status)
> {
> - snprintf(buf, sizeof(buf), "killed by %s", tst_strsig(status));
> + snprintf(buf, sizeof(buf), "killed by %s",
> + tst_strsig(WTERMSIG(status)));
>
> return buf;
> }
> --
> 2.28.0
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
>
>
--
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20200925/f5923914/attachment.htm>
^ permalink raw reply [flat|nested] 6+ messages in thread* [LTP] [PATCH 1/2] Fix formatting signal name in tst_strstatus()
2020-09-24 14:42 [LTP] [PATCH 1/2] Fix formatting signal name in tst_strstatus() Martin Doucha
2020-09-24 14:42 ` [LTP] [PATCH 2/2] mmap18: Increase minimal stack mapping to 8KB Martin Doucha
2020-09-25 3:20 ` [LTP] [PATCH 1/2] Fix formatting signal name in tst_strstatus() Li Wang
@ 2020-09-25 12:24 ` Cyril Hrubis
2 siblings, 0 replies; 6+ messages in thread
From: Cyril Hrubis @ 2020-09-25 12:24 UTC (permalink / raw)
To: ltp
Hi!
Pushed, thanks.
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-25 12:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-24 14:42 [LTP] [PATCH 1/2] Fix formatting signal name in tst_strstatus() Martin Doucha
2020-09-24 14:42 ` [LTP] [PATCH 2/2] mmap18: Increase minimal stack mapping to 8KB Martin Doucha
2020-09-25 10:12 ` Li Wang
2020-09-25 12:34 ` Cyril Hrubis
2020-09-25 3:20 ` [LTP] [PATCH 1/2] Fix formatting signal name in tst_strstatus() Li Wang
2020-09-25 12:24 ` Cyril Hrubis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.