From: Wolfram Sang <wsa@kernel.org>
To: Tali Perry <tali.perry1@gmail.com>
Cc: andriy.shevchenko@linux.intel.com, kunyi@google.com,
benjaminfair@google.com, avifishman70@gmail.com, joel@jms.id.au,
tmaimon77@gmail.com, linux-i2c@vger.kernel.org,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] i2c: npcm7xx: Clear LAST bit after a failed transaction.
Date: Sun, 27 Sep 2020 20:06:16 +0200 [thread overview]
Message-ID: <20200927180616.GG19475@kunai> (raw)
In-Reply-To: <20200920204809.132911-1-tali.perry1@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 668 bytes --]
On Sun, Sep 20, 2020 at 11:48:09PM +0300, Tali Perry wrote:
> Due to a HW issue, in some scenarios the LAST bit might remain set.
> This will cause an unexpected NACK after reading 16 bytes on the next
> read.
>
> Example: if user tries to read from a missing device, get a NACK,
> then if the next command is a long read ( > 16 bytes),
> the master will stop reading after 16 bytes.
> To solve this, if a command fails, check if LAST bit is still
> set. If it does, reset the module.
>
> Fixes: 56a1485b102e (i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver)
> Signed-off-by: Tali Perry <tali.perry1@gmail.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: Tali Perry <tali.perry1@gmail.com>
Cc: benjaminfair@google.com, avifishman70@gmail.com,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, andriy.shevchenko@linux.intel.com,
tmaimon77@gmail.com
Subject: Re: [PATCH v1] i2c: npcm7xx: Clear LAST bit after a failed transaction.
Date: Sun, 27 Sep 2020 20:06:16 +0200 [thread overview]
Message-ID: <20200927180616.GG19475@kunai> (raw)
In-Reply-To: <20200920204809.132911-1-tali.perry1@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 668 bytes --]
On Sun, Sep 20, 2020 at 11:48:09PM +0300, Tali Perry wrote:
> Due to a HW issue, in some scenarios the LAST bit might remain set.
> This will cause an unexpected NACK after reading 16 bytes on the next
> read.
>
> Example: if user tries to read from a missing device, get a NACK,
> then if the next command is a long read ( > 16 bytes),
> the master will stop reading after 16 bytes.
> To solve this, if a command fails, check if LAST bit is still
> set. If it does, reset the module.
>
> Fixes: 56a1485b102e (i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver)
> Signed-off-by: Tali Perry <tali.perry1@gmail.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-09-27 18:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-20 20:48 [PATCH v1] i2c: npcm7xx: Clear LAST bit after a failed transaction Tali Perry
2020-09-27 18:06 ` Wolfram Sang [this message]
2020-09-27 18:06 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200927180616.GG19475@kunai \
--to=wsa@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=joel@jms.id.au \
--cc=kunyi@google.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.