From: Sam Ravnborg <sam@ravnborg.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: kernel test robot <lkp@intel.com>,
airlied@linux.ie, Daniel Vetter <daniel.vetter@ffwll.ch>,
hjc@rock-chips.com, dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, daniel@ffwll.ch,
christian.koenig@amd.com, linux-arm-kernel@lists.infradead.org,
heiko@sntech.de
Subject: Re: [PATCH] drm/rockchip: Include <drm/drm_gem_cma_helper> for drm_gem_cm_vm_ops
Date: Mon, 28 Sep 2020 10:40:19 +0200 [thread overview]
Message-ID: <20200928084019.GA625010@ravnborg.org> (raw)
In-Reply-To: <20200928081643.8575-1-tzimmermann@suse.de>
Hi Thomas.
On Mon, Sep 28, 2020 at 10:16:43AM +0200, Thomas Zimmermann wrote:
> Include <drm/drm_gem_cma_helper.h> to get drm_gem_cma_vm_ops. Fallout
> from the recent conversion to GEM object functions.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
As this has only hit drm-misc-next and not pushed anywhere else there is
really no need for the Fixes: tag. At least thats my understanding.
Otherwise the patch is equal to what I posted in the weekend so:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Sandy Huang <hjc@rock-chips.com>
> Cc: "Heiko Stübner" <heiko@sntech.de>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> index 1cf4631461c9..7d5ebb10323b 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> @@ -10,6 +10,7 @@
>
> #include <drm/drm.h>
> #include <drm/drm_gem.h>
> +#include <drm/drm_gem_cma_helper.h>
> #include <drm/drm_prime.h>
> #include <drm/drm_vma_manager.h>
>
> --
> 2.28.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: kernel test robot <lkp@intel.com>,
airlied@linux.ie, Daniel Vetter <daniel.vetter@ffwll.ch>,
hjc@rock-chips.com, dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, daniel@ffwll.ch,
christian.koenig@amd.com, linux-arm-kernel@lists.infradead.org,
heiko@sntech.de
Subject: Re: [PATCH] drm/rockchip: Include <drm/drm_gem_cma_helper> for drm_gem_cm_vm_ops
Date: Mon, 28 Sep 2020 10:40:19 +0200 [thread overview]
Message-ID: <20200928084019.GA625010@ravnborg.org> (raw)
In-Reply-To: <20200928081643.8575-1-tzimmermann@suse.de>
Hi Thomas.
On Mon, Sep 28, 2020 at 10:16:43AM +0200, Thomas Zimmermann wrote:
> Include <drm/drm_gem_cma_helper.h> to get drm_gem_cma_vm_ops. Fallout
> from the recent conversion to GEM object functions.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
As this has only hit drm-misc-next and not pushed anywhere else there is
really no need for the Fixes: tag. At least thats my understanding.
Otherwise the patch is equal to what I posted in the weekend so:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Sandy Huang <hjc@rock-chips.com>
> Cc: "Heiko Stübner" <heiko@sntech.de>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> index 1cf4631461c9..7d5ebb10323b 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> @@ -10,6 +10,7 @@
>
> #include <drm/drm.h>
> #include <drm/drm_gem.h>
> +#include <drm/drm_gem_cma_helper.h>
> #include <drm/drm_prime.h>
> #include <drm/drm_vma_manager.h>
>
> --
> 2.28.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: kernel test robot <lkp@intel.com>,
airlied@linux.ie, Daniel Vetter <daniel.vetter@ffwll.ch>,
hjc@rock-chips.com, dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, christian.koenig@amd.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/rockchip: Include <drm/drm_gem_cma_helper> for drm_gem_cm_vm_ops
Date: Mon, 28 Sep 2020 10:40:19 +0200 [thread overview]
Message-ID: <20200928084019.GA625010@ravnborg.org> (raw)
In-Reply-To: <20200928081643.8575-1-tzimmermann@suse.de>
Hi Thomas.
On Mon, Sep 28, 2020 at 10:16:43AM +0200, Thomas Zimmermann wrote:
> Include <drm/drm_gem_cma_helper.h> to get drm_gem_cma_vm_ops. Fallout
> from the recent conversion to GEM object functions.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
As this has only hit drm-misc-next and not pushed anywhere else there is
really no need for the Fixes: tag. At least thats my understanding.
Otherwise the patch is equal to what I posted in the weekend so:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Sandy Huang <hjc@rock-chips.com>
> Cc: "Heiko Stübner" <heiko@sntech.de>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> index 1cf4631461c9..7d5ebb10323b 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> @@ -10,6 +10,7 @@
>
> #include <drm/drm.h>
> #include <drm/drm_gem.h>
> +#include <drm/drm_gem_cma_helper.h>
> #include <drm/drm_prime.h>
> #include <drm/drm_vma_manager.h>
>
> --
> 2.28.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-09-28 8:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 8:16 [PATCH] drm/rockchip: Include <drm/drm_gem_cma_helper> for drm_gem_cm_vm_ops Thomas Zimmermann
2020-09-28 8:16 ` Thomas Zimmermann
2020-09-28 8:16 ` Thomas Zimmermann
2020-09-28 8:40 ` Sam Ravnborg [this message]
2020-09-28 8:40 ` Sam Ravnborg
2020-09-28 8:40 ` Sam Ravnborg
2020-09-28 8:48 ` Thomas Zimmermann
2020-09-28 8:48 ` Thomas Zimmermann
2020-09-28 8:48 ` Thomas Zimmermann
2020-09-28 10:33 ` Sam Ravnborg
2020-09-28 10:33 ` Sam Ravnborg
2020-09-28 10:33 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928084019.GA625010@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lkp@intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.