* [PATCH] sparc: Fix handling of page table constructor failure
@ 2020-09-27 15:19 Matthew Wilcox (Oracle)
2020-09-28 14:46 ` Mike Rapoport
2020-10-08 19:53 ` Matthew Wilcox
0 siblings, 2 replies; 3+ messages in thread
From: Matthew Wilcox (Oracle) @ 2020-09-27 15:19 UTC (permalink / raw)
To: sparclinux
The page has just been allocated, so its refcount is 1. free_unref_page()
is for use on pages which have a zero refcount. Use __free_page()
like the other implementations of pte_alloc_one().
Fixes: 1ae9ae5f7df7 ("sparc: handle pgtable_page_ctor() fail")
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
arch/sparc/mm/init_64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c
index fad6d3129904..4288f08a5736 100644
--- a/arch/sparc/mm/init_64.c
+++ b/arch/sparc/mm/init_64.c
@@ -2898,7 +2898,7 @@ pgtable_t pte_alloc_one(struct mm_struct *mm)
if (!page)
return NULL;
if (!pgtable_pte_page_ctor(page)) {
- free_unref_page(page);
+ __free_page(page);
return NULL;
}
return (pte_t *) page_address(page);
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sparc: Fix handling of page table constructor failure
2020-09-27 15:19 [PATCH] sparc: Fix handling of page table constructor failure Matthew Wilcox (Oracle)
@ 2020-09-28 14:46 ` Mike Rapoport
2020-10-08 19:53 ` Matthew Wilcox
1 sibling, 0 replies; 3+ messages in thread
From: Mike Rapoport @ 2020-09-28 14:46 UTC (permalink / raw)
To: sparclinux
On Sun, Sep 27, 2020 at 04:19:50PM +0100, Matthew Wilcox (Oracle) wrote:
> The page has just been allocated, so its refcount is 1. free_unref_page()
> is for use on pages which have a zero refcount. Use __free_page()
> like the other implementations of pte_alloc_one().
>
> Fixes: 1ae9ae5f7df7 ("sparc: handle pgtable_page_ctor() fail")
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
> arch/sparc/mm/init_64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c
> index fad6d3129904..4288f08a5736 100644
> --- a/arch/sparc/mm/init_64.c
> +++ b/arch/sparc/mm/init_64.c
> @@ -2898,7 +2898,7 @@ pgtable_t pte_alloc_one(struct mm_struct *mm)
> if (!page)
> return NULL;
> if (!pgtable_pte_page_ctor(page)) {
> - free_unref_page(page);
> + __free_page(page);
> return NULL;
> }
> return (pte_t *) page_address(page);
> --
> 2.28.0
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sparc: Fix handling of page table constructor failure
2020-09-27 15:19 [PATCH] sparc: Fix handling of page table constructor failure Matthew Wilcox (Oracle)
2020-09-28 14:46 ` Mike Rapoport
@ 2020-10-08 19:53 ` Matthew Wilcox
1 sibling, 0 replies; 3+ messages in thread
From: Matthew Wilcox @ 2020-10-08 19:53 UTC (permalink / raw)
To: sparclinux
ping
On Sun, Sep 27, 2020 at 04:19:50PM +0100, Matthew Wilcox (Oracle) wrote:
> The page has just been allocated, so its refcount is 1. free_unref_page()
> is for use on pages which have a zero refcount. Use __free_page()
> like the other implementations of pte_alloc_one().
>
> Fixes: 1ae9ae5f7df7 ("sparc: handle pgtable_page_ctor() fail")
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> arch/sparc/mm/init_64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c
> index fad6d3129904..4288f08a5736 100644
> --- a/arch/sparc/mm/init_64.c
> +++ b/arch/sparc/mm/init_64.c
> @@ -2898,7 +2898,7 @@ pgtable_t pte_alloc_one(struct mm_struct *mm)
> if (!page)
> return NULL;
> if (!pgtable_pte_page_ctor(page)) {
> - free_unref_page(page);
> + __free_page(page);
> return NULL;
> }
> return (pte_t *) page_address(page);
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-08 19:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-27 15:19 [PATCH] sparc: Fix handling of page table constructor failure Matthew Wilcox (Oracle)
2020-09-28 14:46 ` Mike Rapoport
2020-10-08 19:53 ` Matthew Wilcox
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.