All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ath11k: Move non-fatal warn logs to dbg level
@ 2020-09-24 11:58 ` Govind Singh
  0 siblings, 0 replies; 4+ messages in thread
From: Govind Singh @ 2020-09-24 11:58 UTC (permalink / raw)
  To: ath11k; +Cc: Govind Singh, linux-wireless

During driver load below warn logs are printed in the console.
Since driver may not implement all wmi events sent by fw and
all of them are non-fatal, move this log to debug level to
remove un-necessary warn message on console.

[876.898735] ath11k_pci 0000:06:00.0: Unknown eventid: 0x16005
[879.283250] ath11k_pci 0000:06:00.0: Unknown eventid: 0x1d00a

No functional changes. Compile tested only.

Signed-off-by: Govind Singh <govinds@codeaurora.org>
---
 drivers/net/wireless/ath/ath11k/wmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c
index adde14a390ec..1e5a46bdaa61 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.c
+++ b/drivers/net/wireless/ath/ath11k/wmi.c
@@ -6579,7 +6579,7 @@ static void ath11k_wmi_tlv_op_rx(struct ath11k_base *ab, struct sk_buff *skb)
 		break;
 	/* TODO: Add remaining events */
 	default:
-		ath11k_warn(ab, "Unknown eventid: 0x%x\n", id);
+		ath11k_dbg(ab, ATH11K_DBG_WMI, "Unknown eventid: 0x%x\n", id);
 		break;
 	}
 
-- 
2.22.0


-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] ath11k: Move non-fatal warn logs to dbg level
@ 2020-09-24 11:58 ` Govind Singh
  0 siblings, 0 replies; 4+ messages in thread
From: Govind Singh @ 2020-09-24 11:58 UTC (permalink / raw)
  To: ath11k; +Cc: linux-wireless, Govind Singh

During driver load below warn logs are printed in the console.
Since driver may not implement all wmi events sent by fw and
all of them are non-fatal, move this log to debug level to
remove un-necessary warn message on console.

[876.898735] ath11k_pci 0000:06:00.0: Unknown eventid: 0x16005
[879.283250] ath11k_pci 0000:06:00.0: Unknown eventid: 0x1d00a

No functional changes. Compile tested only.

Signed-off-by: Govind Singh <govinds@codeaurora.org>
---
 drivers/net/wireless/ath/ath11k/wmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c
index adde14a390ec..1e5a46bdaa61 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.c
+++ b/drivers/net/wireless/ath/ath11k/wmi.c
@@ -6579,7 +6579,7 @@ static void ath11k_wmi_tlv_op_rx(struct ath11k_base *ab, struct sk_buff *skb)
 		break;
 	/* TODO: Add remaining events */
 	default:
-		ath11k_warn(ab, "Unknown eventid: 0x%x\n", id);
+		ath11k_dbg(ab, ATH11K_DBG_WMI, "Unknown eventid: 0x%x\n", id);
 		break;
 	}
 
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ath11k: Move non-fatal warn logs to dbg level
  2020-09-24 11:58 ` Govind Singh
  (?)
  (?)
@ 2020-09-29  8:31 ` Kalle Valo
  -1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-09-29  8:31 UTC (permalink / raw)
  To: Govind Singh; +Cc: linux-wireless, ath11k

Govind Singh <govinds@codeaurora.org> wrote:

> During driver load below warn logs are printed in the console.
> Since driver may not implement all wmi events sent by fw and
> all of them are non-fatal, move this log to debug level to
> remove un-necessary warn message on console.
> 
> [876.898735] ath11k_pci 0000:06:00.0: Unknown eventid: 0x16005
> [879.283250] ath11k_pci 0000:06:00.0: Unknown eventid: 0x1d00a
> 
> No functional changes. Compile tested only.
> 
> Signed-off-by: Govind Singh <govinds@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

82b4f9b857e7 ath11k: Move non-fatal warn logs to dbg level

-- 
https://patchwork.kernel.org/patch/11797129/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ath11k: Move non-fatal warn logs to dbg level
  2020-09-24 11:58 ` Govind Singh
  (?)
@ 2020-09-29  8:31 ` Kalle Valo
  -1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-09-29  8:31 UTC (permalink / raw)
  To: Govind Singh; +Cc: ath11k, linux-wireless, Govind Singh

Govind Singh <govinds@codeaurora.org> wrote:

> During driver load below warn logs are printed in the console.
> Since driver may not implement all wmi events sent by fw and
> all of them are non-fatal, move this log to debug level to
> remove un-necessary warn message on console.
> 
> [876.898735] ath11k_pci 0000:06:00.0: Unknown eventid: 0x16005
> [879.283250] ath11k_pci 0000:06:00.0: Unknown eventid: 0x1d00a
> 
> No functional changes. Compile tested only.
> 
> Signed-off-by: Govind Singh <govinds@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

82b4f9b857e7 ath11k: Move non-fatal warn logs to dbg level

-- 
https://patchwork.kernel.org/patch/11797129/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-09-29  8:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-24 11:58 [PATCH] ath11k: Move non-fatal warn logs to dbg level Govind Singh
2020-09-24 11:58 ` Govind Singh
2020-09-29  8:31 ` Kalle Valo
2020-09-29  8:31 ` Kalle Valo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.