From: Christoph Hellwig <hch@lst.de>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>, Jens Axboe <axboe@kernel.dk>,
Keith Busch <kbusch@kernel.org>,
Leon Romanovsky <leonro@nvidia.com>,
Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org,
Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH blk-next 1/2] blk-mq-rdma: Delete not-used multi-queue RDMA map queue code
Date: Tue, 29 Sep 2020 12:20:46 +0200 [thread overview]
Message-ID: <20200929102046.GA14445@lst.de> (raw)
In-Reply-To: <20200929091358.421086-2-leon@kernel.org>
On Tue, Sep 29, 2020 at 12:13:57PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> The RDMA vector affinity code is not backed up by any driver and always
> returns NULL to every ib_get_vector_affinity() call.
>
> This means that blk_mq_rdma_map_queues() always takes fallback path.
>
> Fixes: 9afc97c29b03 ("mlx5: remove support for ib_get_vector_affinity")
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
So you guys totally broken the nvme queue assignment without even
telling anyone? Great job!
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Leon Romanovsky <leon@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, Sagi Grimberg <sagi@grimberg.me>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>, Keith Busch <kbusch@kernel.org>,
Leon Romanovsky <leonro@nvidia.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH blk-next 1/2] blk-mq-rdma: Delete not-used multi-queue RDMA map queue code
Date: Tue, 29 Sep 2020 12:20:46 +0200 [thread overview]
Message-ID: <20200929102046.GA14445@lst.de> (raw)
In-Reply-To: <20200929091358.421086-2-leon@kernel.org>
On Tue, Sep 29, 2020 at 12:13:57PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> The RDMA vector affinity code is not backed up by any driver and always
> returns NULL to every ib_get_vector_affinity() call.
>
> This means that blk_mq_rdma_map_queues() always takes fallback path.
>
> Fixes: 9afc97c29b03 ("mlx5: remove support for ib_get_vector_affinity")
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
So you guys totally broken the nvme queue assignment without even
telling anyone? Great job!
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-09-29 10:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 9:13 [PATCH blk-next 0/2] Delete the get_vector_affinity leftovers Leon Romanovsky
2020-09-29 9:13 ` Leon Romanovsky
2020-09-29 9:13 ` [PATCH blk-next 1/2] blk-mq-rdma: Delete not-used multi-queue RDMA map queue code Leon Romanovsky
2020-09-29 9:13 ` Leon Romanovsky
2020-09-29 10:20 ` Christoph Hellwig [this message]
2020-09-29 10:20 ` Christoph Hellwig
2020-09-29 10:35 ` Leon Romanovsky
2020-09-29 10:35 ` Leon Romanovsky
2020-09-29 18:24 ` Sagi Grimberg
2020-09-29 18:24 ` Sagi Grimberg
2020-10-02 6:45 ` Christoph Hellwig
2020-10-02 6:45 ` Christoph Hellwig
2020-10-02 20:20 ` Sagi Grimberg
2020-10-02 20:20 ` Sagi Grimberg
2020-10-05 8:38 ` Christoph Hellwig
2020-10-05 8:38 ` Christoph Hellwig
2020-10-06 4:58 ` Leon Romanovsky
2020-10-06 4:58 ` Leon Romanovsky
2020-09-29 9:13 ` [PATCH blk-next 2/2] RDMA/core: Delete not-implemented get_vector_affinity Leon Romanovsky
2020-09-29 9:13 ` Leon Romanovsky
2020-10-01 5:01 ` [PATCH blk-next 0/2] Delete the get_vector_affinity leftovers Leon Romanovsky
2020-10-01 5:01 ` Leon Romanovsky
2020-10-02 1:28 ` Jens Axboe
2020-10-02 1:28 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929102046.GA14445@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=kbusch@kernel.org \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.