From: Rob Herring <robh@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Andy Gross" <agross@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-kernel@vger.kernel.org, "Lee Jones" <lee.jones@linaro.org>,
"Martin Botka" <martin.botka1@gmail.com>,
"Pavel Machek" <pavel@ucw.cz>,
devicetree@vger.kernel.org, "Dan Murphy" <dmurphy@ti.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
linux-leds@vger.kernel.org, linux-pwm@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4 1/4] dt-bindings: leds: Add Qualcomm Light Pulse Generator binding
Date: Tue, 29 Sep 2020 09:48:02 -0500 [thread overview]
Message-ID: <20200929144802.GA566563@bogus> (raw)
In-Reply-To: <20200929031544.1000204-2-bjorn.andersson@linaro.org>
On Mon, 28 Sep 2020 20:15:41 -0700, Bjorn Andersson wrote:
> This adds the binding document describing the three hardware blocks
> related to the Light Pulse Generator found in a wide range of Qualcomm
> PMICs.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>
> Changes since v3:
> - Rewritten as YAML
> - Adopt multicolor model
>
> .../bindings/leds/leds-qcom-lpg.yaml | 170 ++++++++++++++++++
> 1 file changed, 170 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
Traceback (most recent call last):
File "/usr/local/bin/dt-extract-example", line 45, in <module>
binding = yaml.load(open(args.yamlfile, encoding='utf-8').read())
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 343, in load
return constructor.get_single_data()
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 111, in get_single_data
node = self.composer.get_single_node()
File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node
File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document
File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
File "_ruamel_yaml.pyx", line 773, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 852, in _ruamel_yaml.CParser._compose_sequence_node
File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event
ruamel.yaml.scanner.ScannerError: while scanning a block scalar
in "<unicode string>", line 131, column 5
found a tab character where an indentation space is expected
in "<unicode string>", line 144, column 1
make[1]: *** [Documentation/devicetree/bindings/Makefile:18: Documentation/devicetree/bindings/leds/leds-qcom-lpg.example.dts] Error 1
make[1]: *** Deleting file 'Documentation/devicetree/bindings/leds/leds-qcom-lpg.example.dts'
make[1]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml: while scanning a block scalar
in "<unicode string>", line 131, column 5
found a tab character where an indentation space is expected
in "<unicode string>", line 144, column 1
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml: ignoring, error parsing file
warning: no schema found in file: ./Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
make: *** [Makefile:1366: dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1372990
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2020-09-29 14:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 3:15 [PATCH v4 0/4] Qualcomm Light Pulse Generator Bjorn Andersson
2020-09-29 3:15 ` [PATCH v4 1/4] dt-bindings: leds: Add Qualcomm Light Pulse Generator binding Bjorn Andersson
2020-09-29 14:48 ` Rob Herring [this message]
2020-09-29 14:51 ` Rob Herring
2020-09-29 3:15 ` [PATCH v4 2/4] leds: Add driver for Qualcomm LPG Bjorn Andersson
2020-09-29 5:09 ` kernel test robot
2020-09-29 5:09 ` kernel test robot
2020-10-07 9:40 ` Luca Weiss
2020-09-29 3:15 ` [PATCH v4 3/4] arm64: dts: qcom: msm8996: Add mpp and lpg blocks Bjorn Andersson
2020-10-01 15:22 ` Konrad Dybcio
2020-10-01 16:21 ` Bjorn Andersson
2020-09-29 3:15 ` [PATCH v4 4/4] arm64: dts: qcom: Add user LEDs on db820c Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929144802.GA566563@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=martin.botka1@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.