Re: [PATCH v4 2/4] leds: Add driver for Qualcomm LPG

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2440 bytes --]

Hi Bjorn,

I love your patch! Yet something to improve:

[auto build test ERROR on pavel-linux-leds/for-next]
[also build test ERROR on robh/for-next v5.9-rc7 next-20200928]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Bjorn-Andersson/Qualcomm-Light-Pulse-Generator/20200929-111512
base:   git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git for-next
config: microblaze-randconfig-r004-20200929 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/5937b69205a78e5ed73d8e8e279eccaad245b1eb
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Bjorn-Andersson/Qualcomm-Light-Pulse-Generator/20200929-111512
        git checkout 5937b69205a78e5ed73d8e8e279eccaad245b1eb
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   microblaze-linux-ld: drivers/leds/leds-qcom-lpg.o: in function `lpg_pwm_apply':
>> drivers/leds/leds-qcom-lpg.c:814: undefined reference to `__udivdi3'
>> microblaze-linux-ld: drivers/leds/leds-qcom-lpg.c:815: undefined reference to `__udivdi3'

vim +814 drivers/leds/leds-qcom-lpg.c

   807	
   808	static int lpg_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
   809				 const struct pwm_state *state)
   810	{
   811		struct lpg *lpg = container_of(chip, struct lpg, pwm);
   812		struct lpg_channel *chan = &lpg->channels[pwm->hwpwm];
   813	
 > 814		lpg_calc_freq(chan, state->period / NSEC_PER_USEC);
 > 815		lpg_calc_duty(chan, state->duty_cycle / NSEC_PER_USEC);
   816		chan->enabled = state->enabled;
   817	
   818		lpg_apply(chan);
   819	
   820		triled_set(lpg, chan->triled_mask, chan->enabled);
   821	
   822		return 0;
   823	}
   824	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27446 bytes --]