* [PATCH] kexec-tools: Fix a prompt message when crashkernel is not reserved
@ 2020-09-12 1:38 Youling Tang
2020-09-16 18:44 ` Bhupesh SHARMA
0 siblings, 1 reply; 3+ messages in thread
From: Youling Tang @ 2020-09-12 1:38 UTC (permalink / raw)
To: Simon Horman, Khalid Aziz, Eric W. Biederman; +Cc: kexec
Where Y specifies how much memory to reserve for the dump-capture kernel
and X specifies the beginning of this reserved memory. So Y should be
placed before X.
Signed-off-by: Youling Tang <tangyouling@loongson.cn>
---
kexec/kexec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kexec/kexec.c b/kexec/kexec.c
index bb88caa..fd7c8d2 100644
--- a/kexec/kexec.c
+++ b/kexec/kexec.c
@@ -1530,7 +1530,7 @@ int main(int argc, char *argv[])
!is_crashkernel_mem_reserved()) {
die("Memory for crashkernel is not reserved\n"
"Please reserve memory by passing"
- "\"crashkernel=X@Y\" parameter to kernel\n"
+ "\"crashkernel=Y@X\" parameter to kernel\n"
"Then try to loading kdump kernel\n");
}
--
2.1.0
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kexec-tools: Fix a prompt message when crashkernel is not reserved
2020-09-12 1:38 [PATCH] kexec-tools: Fix a prompt message when crashkernel is not reserved Youling Tang
@ 2020-09-16 18:44 ` Bhupesh SHARMA
2020-09-29 16:13 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Bhupesh SHARMA @ 2020-09-16 18:44 UTC (permalink / raw)
To: Youling Tang; +Cc: Simon Horman, kexec, Eric W. Biederman, Khalid Aziz
Hi Youling,
On Sat, Sep 12, 2020 at 7:10 AM Youling Tang <tangyouling@loongson.cn> wrote:
>
> Where Y specifies how much memory to reserve for the dump-capture kernel
> and X specifies the beginning of this reserved memory. So Y should be
> placed before X.
>
> Signed-off-by: Youling Tang <tangyouling@loongson.cn>
> ---
> kexec/kexec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kexec/kexec.c b/kexec/kexec.c
> index bb88caa..fd7c8d2 100644
> --- a/kexec/kexec.c
> +++ b/kexec/kexec.c
> @@ -1530,7 +1530,7 @@ int main(int argc, char *argv[])
> !is_crashkernel_mem_reserved()) {
> die("Memory for crashkernel is not reserved\n"
> "Please reserve memory by passing"
> - "\"crashkernel=X@Y\" parameter to kernel\n"
> + "\"crashkernel=Y@X\" parameter to kernel\n"
> "Then try to loading kdump kernel\n");
> }
>
> --
> 2.1.0
Thanks for the patch. LGTM, so:
Reviewed-by: Bhupesh Sharma <bhsharma@redhat.com>
- Bhupesh
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kexec-tools: Fix a prompt message when crashkernel is not reserved
2020-09-16 18:44 ` Bhupesh SHARMA
@ 2020-09-29 16:13 ` Simon Horman
0 siblings, 0 replies; 3+ messages in thread
From: Simon Horman @ 2020-09-29 16:13 UTC (permalink / raw)
To: Bhupesh SHARMA; +Cc: kexec, Youling Tang, Eric W. Biederman, Khalid Aziz
On Thu, Sep 17, 2020 at 12:14:02AM +0530, Bhupesh SHARMA wrote:
> Hi Youling,
>
> On Sat, Sep 12, 2020 at 7:10 AM Youling Tang <tangyouling@loongson.cn> wrote:
> >
> > Where Y specifies how much memory to reserve for the dump-capture kernel
> > and X specifies the beginning of this reserved memory. So Y should be
> > placed before X.
> >
> > Signed-off-by: Youling Tang <tangyouling@loongson.cn>
> > ---
> > kexec/kexec.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kexec/kexec.c b/kexec/kexec.c
> > index bb88caa..fd7c8d2 100644
> > --- a/kexec/kexec.c
> > +++ b/kexec/kexec.c
> > @@ -1530,7 +1530,7 @@ int main(int argc, char *argv[])
> > !is_crashkernel_mem_reserved()) {
> > die("Memory for crashkernel is not reserved\n"
> > "Please reserve memory by passing"
> > - "\"crashkernel=X@Y\" parameter to kernel\n"
> > + "\"crashkernel=Y@X\" parameter to kernel\n"
> > "Then try to loading kdump kernel\n");
> > }
> >
> > --
> > 2.1.0
>
> Thanks for the patch. LGTM, so:
> Reviewed-by: Bhupesh Sharma <bhsharma@redhat.com>
Thanks, applied.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-29 16:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-12 1:38 [PATCH] kexec-tools: Fix a prompt message when crashkernel is not reserved Youling Tang
2020-09-16 18:44 ` Bhupesh SHARMA
2020-09-29 16:13 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.