Re: [PATCH] MAINTAINERS: Update section for cpuidle-psci

From: Sudeep Holla <sudeep.holla@arm.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Linux PM <linux-pm@vger.kernel.org>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Lina Iyer <ilina@codeaurora.org>,
	Lukasz Luba <lukasz.luba@arm.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Stephen Boyd <sboyd@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Benjamin Gaignard <benjamin.gaignard@st.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] MAINTAINERS: Update section for cpuidle-psci
Date: Wed, 30 Sep 2020 11:16:32 +0100	[thread overview]
Message-ID: <20200930101632.GA30186@bogus> (raw)
In-Reply-To: <20200930091254.GA16862@e121166-lin.cambridge.arm.com>

On Wed, Sep 30, 2020 at 10:12:54AM +0100, Lorenzo Pieralisi wrote:
> On Wed, Sep 23, 2020 at 03:44:53PM +0200, Ulf Hansson wrote:
> > On Wed, 23 Sep 2020 at 10:11, Lorenzo Pieralisi
> > <lorenzo.pieralisi@arm.com> wrote:
> > >
> > > On Mon, Sep 21, 2020 at 05:49:52PM +0200, Rafael J. Wysocki wrote:
> > > > On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > > > >
> > > > > Extend the file pattern to also include cpuidle-psci.h and
> > > > > cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> > > > > particularly to help with the support for PM domains.
> > > > >
> > > > > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > > > > Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> > > > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > > >
> > > > Any objections from the original maintainers?
> > >
> > > The PSCI driver providing support for platform coordinated idle states
> > > (that this patch is targeting AFAICS) does not require more maintainers,
> > > that support is complete and Sudeep and I will take care of refactoring
> > > and fixes.
> > >
> > > If the OSI bits in it require a specific maintainer I would prefer those
> > > bits to be moved into a specific file and maintainership added
> > > _explicitly_ for that file only.
> >
> > My main concern is that the OSI support (and some related changes for
> > genpd) is still being worked upon. The corresponding code deserves to
> > be looked after by someone. I offer my help with this.
>
> All OSI changes can go into cpuidle-psci-domain.c, you can add a
> maintainer entry for that.
>
> > I guess we can split up the code as you suggest, but perhaps another
> > way would be to explicitly state my part of the responsibility in
> > MAINTAINERS. Along the lines of this:
> >
> > M:     Ulf Hansson <ulf.hansson@linaro.org> # OSI support / PM domains
> >
> > Would that be okay to you?
>
> No because there should be no need, as I have already said. If you need
> to change cpuidle-psci.c send patches please and we will review them.
>

I agree and recollect that was the main idea when we moved all the OSI
specific PM domain code to separate file.

--
Regards,
Sudeep