From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it,
Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
linux-integrity@vger.kernel.org,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3 0/4] TPM 2.0 fixes in IMA tests
Date: Wed, 30 Sep 2020 14:59:39 +0300 [thread overview]
Message-ID: <20200930115939.GB7612@linux.intel.com> (raw)
In-Reply-To: <20200930055314.GA21664@dell5510>
On Wed, Sep 30, 2020 at 07:53:14AM +0200, Petr Vorel wrote:
> Hi Jarkko,
>
> > Hi, is there something specific I should look at in this patch set?
>
> I'm sorry to bother you with LTP specific code. Can you have a quick look if I
> didn't overlook anything obvious in reading PCR files (read_pcr_tpm*())?
>
> I'm surprised that it's working on my TPM 2.0 which does not export
> /sys/kernel/security/tpm0/binary_bios_measurements (using evmctl).
Thank you, this was actually really important remark and reminder.
OK so I think James' patch is stuck because of me, i.e.
https://lore.kernel.org/linux-integrity/20200911114820.GB6877@linux.intel.com/
I'm sorry about this. The final final conclusion is that the way it
exports PCRs is just fine.
Can you test this version?
https://patchwork.kernel.org/patch/11759729/
I can then add reviewd-by and apply it and you don't have to do any sort
of stupid hacks.
/Jarkkko
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 0/4] TPM 2.0 fixes in IMA tests
Date: Wed, 30 Sep 2020 14:59:39 +0300 [thread overview]
Message-ID: <20200930115939.GB7612@linux.intel.com> (raw)
In-Reply-To: <20200930055314.GA21664@dell5510>
On Wed, Sep 30, 2020 at 07:53:14AM +0200, Petr Vorel wrote:
> Hi Jarkko,
>
> > Hi, is there something specific I should look at in this patch set?
>
> I'm sorry to bother you with LTP specific code. Can you have a quick look if I
> didn't overlook anything obvious in reading PCR files (read_pcr_tpm*())?
>
> I'm surprised that it's working on my TPM 2.0 which does not export
> /sys/kernel/security/tpm0/binary_bios_measurements (using evmctl).
Thank you, this was actually really important remark and reminder.
OK so I think James' patch is stuck because of me, i.e.
https://lore.kernel.org/linux-integrity/20200911114820.GB6877@linux.intel.com/
I'm sorry about this. The final final conclusion is that the way it
exports PCRs is just fine.
Can you test this version?
https://patchwork.kernel.org/patch/11759729/
I can then add reviewd-by and apply it and you don't have to do any sort
of stupid hacks.
/Jarkkko
next prev parent reply other threads:[~2020-09-30 11:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 16:50 [PATCH v3 0/4] TPM 2.0 fixes in IMA tests Petr Vorel
2020-09-29 16:50 ` [LTP] " Petr Vorel
2020-09-29 16:50 ` [PATCH v3 1/4] IMA: Move get_algorithm_digest(), set_digest_index() to ima_setup.sh Petr Vorel
2020-09-29 16:50 ` [LTP] " Petr Vorel
2020-09-29 16:50 ` [PATCH v3 2/4] IMA: Rewrite ima_boot_aggregate.c to new API Petr Vorel
2020-09-29 16:50 ` [LTP] " Petr Vorel
2020-09-29 21:39 ` Mimi Zohar
2020-09-29 21:39 ` [LTP] " Mimi Zohar
2020-09-30 6:53 ` Petr Vorel
2020-09-30 6:53 ` [LTP] " Petr Vorel
2020-09-29 16:50 ` [PATCH v3 3/4] ima_tpm.sh: Fix calculating boot aggregate Petr Vorel
2020-09-29 16:50 ` [LTP] " Petr Vorel
2020-09-29 20:46 ` Mimi Zohar
2020-09-29 20:46 ` [LTP] " Mimi Zohar
2020-09-29 16:50 ` [PATCH v3 4/4] ima_tpm.sh: Fix calculating PCR aggregate Petr Vorel
2020-09-29 16:50 ` [LTP] " Petr Vorel
2020-09-29 19:01 ` Mimi Zohar
2020-09-29 19:01 ` [LTP] " Mimi Zohar
2020-09-29 16:53 ` [LTP] [PATCH v3 0/4] TPM 2.0 fixes in IMA tests Petr Vorel
2020-09-29 21:56 ` Mimi Zohar
2020-09-29 23:11 ` Jarkko Sakkinen
2020-09-29 23:11 ` [LTP] " Jarkko Sakkinen
2020-09-30 5:53 ` Petr Vorel
2020-09-30 5:53 ` [LTP] " Petr Vorel
2020-09-30 11:59 ` Jarkko Sakkinen [this message]
2020-09-30 11:59 ` Jarkko Sakkinen
2020-10-01 12:01 ` Petr Vorel
2020-10-01 12:01 ` [LTP] " Petr Vorel
2020-10-01 18:31 ` Jarkko Sakkinen
2020-10-01 18:31 ` [LTP] " Jarkko Sakkinen
2020-10-06 10:01 ` Petr Vorel
2020-10-06 15:53 ` Jarkko Sakkinen
2020-10-06 15:55 ` Jarkko Sakkinen
2020-10-06 17:37 ` Ken Goldman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930115939.GB7612@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-integrity@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=nramas@linux.microsoft.com \
--cc=pvorel@suse.cz \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.