From: Ido Schimmel <idosch@idosch.org>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
f.fainelli@gmail.com, andrew@lunn.ch, ayal@nvidia.com,
danieller@nvidia.com, amcohen@nvidia.com, mlxsw@nvidia.com,
Ido Schimmel <idosch@nvidia.com>
Subject: Re: [RFC PATCH net] ethtool: Fix incompatibility between netlink and ioctl interfaces
Date: Wed, 30 Sep 2020 23:06:53 +0300 [thread overview]
Message-ID: <20200930200653.GC1850258@shredder> (raw)
In-Reply-To: <20200930085917.xr2orisrg3oxw6cw@lion.mk-sys.cz>
On Wed, Sep 30, 2020 at 10:59:17AM +0200, Michal Kubecek wrote:
> How about this compromise? Let's introduce a "legacy" flag which would
> allow "ethtool -s <dev> autoneg on" do what it used to do while we would
> not taint the kernel-userspace API with this special case so that
> ETHTOOL_MSG_LINKMODES_SET request with only ETHTOOL_A_LINKMODES_AUTONEG
> (but no other attributes like _SPEED or _DUPLEX) would leave advertised
> link modes untouched unless the "legacy" flag is set. If the "legacy"
> flag is set in the request, such request would set advertised modes to
> all supported.
Sorry for the delay, busy with other obligations. Regarding the "legacy"
flag suggestion, do you mean that the ethtool user space utility will
always set it in ETHTOOL_MSG_LINKMODES_SET request in order to maintain
backward compatibility with the ioctl interface?
Thanks for spending time on this issue.
next prev parent reply other threads:[~2020-09-30 20:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 16:02 [RFC PATCH net] ethtool: Fix incompatibility between netlink and ioctl interfaces Ido Schimmel
2020-09-29 16:44 ` Michal Kubecek
2020-09-30 7:25 ` Ido Schimmel
2020-09-30 8:59 ` Michal Kubecek
2020-09-30 14:19 ` Andrew Lunn
2020-09-30 14:35 ` Ido Schimmel
2020-09-30 14:43 ` Ido Schimmel
2020-09-30 20:06 ` Ido Schimmel [this message]
2020-09-30 20:45 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930200653.GC1850258@shredder \
--to=idosch@idosch.org \
--cc=amcohen@nvidia.com \
--cc=andrew@lunn.ch \
--cc=ayal@nvidia.com \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.