[curro:for-edward 17/17] drivers/cpufreq/intel_pstate.c:2680:18: warning: ISO C90 forbids mixing declarations and code

[curro:for-edward 17/17] drivers/cpufreq/intel_pstate.c:2680:18: warning: ISO C90 forbids mixing declarations and code

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 4429 bytes --]

tree:   https://github.com/curro/linux for-edward
head:   9ba143107276ffb71f116efd181424c070805213
commit: 9ba143107276ffb71f116efd181424c070805213 [17/17] DEBUG
config: x86_64-randconfig-a005-20200930 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bcd05599d0e53977a963799d6ee4f6e0bc21331b)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/curro/linux/commit/9ba143107276ffb71f116efd181424c070805213
        git remote add curro https://github.com/curro/linux
        git fetch --no-tags curro for-edward
        git checkout 9ba143107276ffb71f116efd181424c070805213
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/cpufreq/intel_pstate.c:37:
   In file included from drivers/cpufreq/../../kernel/sched/sched.h:70:
   include/asm-generic/vmlinux.lds.h:299:9: warning: 'ACPI_PROBE_TABLE' macro redefined [-Wmacro-redefined]
   #define ACPI_PROBE_TABLE(name)                                          \
           ^
   include/linux/acpi.h:1177:9: note: previous definition is here
   #define ACPI_PROBE_TABLE(name)          __##name##_acpi_probe_table
           ^
>> drivers/cpufreq/intel_pstate.c:2680:18: warning: ISO C90 forbids mixing declarations and code [-Wdeclaration-after-statement]
           struct cpudata *cpu = container_of(data, struct cpudata, update_util);
                           ^
   drivers/cpufreq/intel_pstate.c:90:23: warning: unused function 'percent_fp' [-Wunused-function]
   static inline int32_t percent_fp(int percent)
                         ^
   drivers/cpufreq/intel_pstate.c:105:23: warning: unused function 'percent_ext_fp' [-Wunused-function]
   static inline int32_t percent_ext_fp(int percent)
                         ^
   4 warnings generated.

vim +2680 drivers/cpufreq/intel_pstate.c

93f0822dff5dae2 Dirk Brandewie  2013-02-06  2667  
0fbc9efcbbcf751 Francisco Jerez 2020-04-14  2668  /**
0fbc9efcbbcf751 Francisco Jerez 2020-04-14  2669   * Implementation of the cpufreq update_util hook based on the VLP
0fbc9efcbbcf751 Francisco Jerez 2020-04-14  2670   * controller (see get_vlp_target_range()).
0fbc9efcbbcf751 Francisco Jerez 2020-04-14  2671   */
585709a5730eca8 Francisco Jerez 2020-04-14  2672  static void intel_pstate_update_util_vlp(struct update_util_data *data,
585709a5730eca8 Francisco Jerez 2020-04-14  2673  					 u64 time, unsigned int flags)
585709a5730eca8 Francisco Jerez 2020-04-14  2674  {
9ba143107276ffb Francisco Jerez 2020-04-03  2675  	if (vlp_params.debug & 16) {
9ba143107276ffb Francisco Jerez 2020-04-03  2676  		intel_pstate_update_util(data, time, flags);
9ba143107276ffb Francisco Jerez 2020-04-03  2677  		return;
9ba143107276ffb Francisco Jerez 2020-04-03  2678  	}
9ba143107276ffb Francisco Jerez 2020-04-03  2679  
585709a5730eca8 Francisco Jerez 2020-04-14 @2680  	struct cpudata *cpu = container_of(data, struct cpudata, update_util);
585709a5730eca8 Francisco Jerez 2020-04-14  2681  
585709a5730eca8 Francisco Jerez 2020-04-14  2682  	if (update_vlp_sample(cpu, time, flags)) {
585709a5730eca8 Francisco Jerez 2020-04-14  2683  		const int32_t target = get_vlp_target_pstate(cpu);
585709a5730eca8 Francisco Jerez 2020-04-14  2684  
585709a5730eca8 Francisco Jerez 2020-04-14  2685  		intel_pstate_adjust_pstate(cpu, target);
585709a5730eca8 Francisco Jerez 2020-04-14  2686  	}
585709a5730eca8 Francisco Jerez 2020-04-14  2687  }
585709a5730eca8 Francisco Jerez 2020-04-14  2688  

:::::: The code at line 2680 was first introduced by commit
:::::: 585709a5730eca8defa8d023846ec6e6c1d4f4bb WIP: cpufreq: intel_pstate: Implement VLP controller for non-HWP parts.

:::::: TO: Francisco Jerez <currojerez@riseup.net>
:::::: CC: Francisco Jerez <currojerez@riseup.net>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33122 bytes --]