Re: [PATCH v5 1/2] arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Schrempf Frieder <frieder.schrempf@kontron.de>
Cc: Rob Herring <robh@kernel.org>,
	Robert Jones <rjones@gateworks.com>,
	Stefan Riedmueller <s.riedmueller@phytec.de>,
	Anson Huang <Anson.Huang@nxp.com>,
	devicetree@vger.kernel.org,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	"Angus Ainslie \(Purism\)" <angus@akkea.ca>,
	linux-kernel@vger.kernel.org, Li Yang <leoyang.li@nxp.com>,
	Michael Walle <michael@walle.cc>,
	Andreas Kemnade <andreas@kemnade.info>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Stoica Cosmin-Stefan <cosmin.stoica@nxp.com>,
	Rabeeh Khoury <rabeeh@solid-run.com>,
	Fabio Estevam <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 1/2] arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards
Date: Thu, 1 Oct 2020 17:19:01 +0200	[thread overview]
Message-ID: <20201001151901.GB14276@kozik-lap> (raw)
In-Reply-To: <20201001151422.16028-1-frieder.schrempf@kontron.de>

On Thu, Oct 01, 2020 at 05:13:37PM +0200, Schrempf Frieder wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> 
> Kontron Electronics GmbH offers small and powerful SoMs based on the
> i.MX8M Mini SoC including PMIC, LPDDR4-RAM, eMMC and SPI NOR.
> 
> The matching baseboards have the same form factor and similar interfaces
> as the other boards from the Kontron "Board-Line" family, including
> SD card, 1G Ethernet, 100M Ethernet, USB Host/OTG, digital IOs, RS232,
> RS485, CAN, LVDS or HDMI, RTC and much more.
> 
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> ---
> Changes for v5:
> * Add Makefile entry to build dtb
> 
> Changes for v4:
> * Remove one more needless status property
> * Use local-mac-address instead of mac-address
> * Add missing pinctrl-names in PMIC node
> * Fix interrupt flags in PMIC node
> * Use lowercase regulator names
> * Enable pullup for PMIC IRQ line
> * Fix pinctrl grp names to match schema
> 
> Changes for v3:
> * Remove needless status properties
> * Remove needless regulator properties for reg_vdd_5v
> * Use proper PHY reset properties in PHY node
> * Use phy-connection-type instead of phy-mode
> * Adjust PMIC node name and label
> * Add over-current-active-low to usbotg1 node
> * Remove redundant bus-width property from usdhc2 node
> * Remove needless regulator-compatible from reg_vdd_snvs
> * Set minimum voltage to 85mV for reg_vdd_snvs
> 
> Changes for v2:
> * Make the licensing less strict (GPL-2.0+ OR MIT)
> * Merge the SoM and baseboard DTs for N8010 and N8011 into one as
>   they only differ in DDR and eMMC size.
> * Change compatibles and model strings to "n810x" and "N8010X".
> * Only use a common memory node that will be updated by the
>   bootloader reflecting the detected DDR size.
> * Improve naming for 16MHz CAN fixed oscillator and set
>   "clock-output-names".
> * Consistently use "reg_" prefix for regulators.
> * Remove "userspi" node.
> * Slightly improve commit message.
> ---
>  arch/arm64/boot/dts/freescale/Makefile        |   1 +
>  .../dts/freescale/imx8mm-kontron-n801x-s.dts  | 322 ++++++++++++++++++
>  .../freescale/imx8mm-kontron-n801x-som.dtsi   | 294 ++++++++++++++++
>  3 files changed, 617 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
>  create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> 
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel