From: Boris Brezillon <boris.brezillon@collabora.com>
To: Rob Herring <robh+dt@kernel.org>,
Tomeu Vizoso <tomeu@tomeuvizoso.net>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Robin Murphy <robin.murphy@arm.com>
Cc: stable@vger.kernel.org, dri-devel@lists.freedesktop.org,
Steven Price <steven.price@arm.com>
Subject: Re: [PATCH v2] drm/panfrost: Fix job timeout handling
Date: Fri, 2 Oct 2020 14:06:29 +0200 [thread overview]
Message-ID: <20201002140629.79174b26@collabora.com> (raw)
In-Reply-To: <20201002071032.1225267-1-boris.brezillon@collabora.com>
On Fri, 2 Oct 2020 09:10:32 +0200
Boris Brezillon <boris.brezillon@collabora.com> wrote:
> @@ -392,19 +411,41 @@ static void panfrost_job_timedout(struct drm_sched_job *sched_job)
> job_read(pfdev, JS_TAIL_LO(js)),
> sched_job);
>
> + /* Scheduler is already stopped, nothing to do. */
> + if (!panfrost_scheduler_stop(&pfdev->js->queue[js], sched_job))
> + return;
> +
> if (!mutex_trylock(&pfdev->reset_lock))
> return;
>
> + mutex_lock(&pfdev->sched_lock);
Oops, sched_lock shouldn't be acquired here, I switched to a per-queue
lock instead.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Rob Herring <robh+dt@kernel.org>,
Tomeu Vizoso <tomeu@tomeuvizoso.net>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Robin Murphy <robin.murphy@arm.com>
Cc: Steven Price <steven.price@arm.com>,
dri-devel@lists.freedesktop.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] drm/panfrost: Fix job timeout handling
Date: Fri, 2 Oct 2020 14:06:29 +0200 [thread overview]
Message-ID: <20201002140629.79174b26@collabora.com> (raw)
In-Reply-To: <20201002071032.1225267-1-boris.brezillon@collabora.com>
On Fri, 2 Oct 2020 09:10:32 +0200
Boris Brezillon <boris.brezillon@collabora.com> wrote:
> @@ -392,19 +411,41 @@ static void panfrost_job_timedout(struct drm_sched_job *sched_job)
> job_read(pfdev, JS_TAIL_LO(js)),
> sched_job);
>
> + /* Scheduler is already stopped, nothing to do. */
> + if (!panfrost_scheduler_stop(&pfdev->js->queue[js], sched_job))
> + return;
> +
> if (!mutex_trylock(&pfdev->reset_lock))
> return;
>
> + mutex_lock(&pfdev->sched_lock);
Oops, sched_lock shouldn't be acquired here, I switched to a per-queue
lock instead.
next prev parent reply other threads:[~2020-10-02 12:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 7:10 [PATCH v2] drm/panfrost: Fix job timeout handling Boris Brezillon
2020-10-02 7:10 ` Boris Brezillon
2020-10-02 11:08 ` Steven Price
2020-10-02 11:08 ` Steven Price
2020-10-02 12:06 ` Boris Brezillon [this message]
2020-10-02 12:06 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002140629.79174b26@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=stable@vger.kernel.org \
--cc=steven.price@arm.com \
--cc=tomeu@tomeuvizoso.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.