[riscv:for-next 19/23] arch/riscv/mm/init.c:283:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG.

[riscv:for-next 19/23] arch/riscv/mm/init.c:283:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG.

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Atish Patra <atish.patra@wdc.com>
CC: Palmer Dabbelt <palmerdabbelt@google.com>
CC: Anup Patel <anup@brainfault.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git for-next
head:   de22d2107ced3cc5355cc9dbbd85e44183546bd5
commit: e8dcb61f2ade040a372d66907d220dd3fdee2505 [19/23] RISC-V: Implement late mapping page table allocation functions
:::::: branch date: 26 hours ago
:::::: commit date: 26 hours ago
config: riscv-randconfig-c004-20201002 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>

	echo
	echo "coccinelle warnings: (new ones prefixed by >>)"
	echo
>> arch/riscv/mm/init.c:283:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG.
   Please make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h)

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28400 bytes --]

[PATCH] RISC-V: fix bugon.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2045 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Atish Patra <atish.patra@wdc.com>
CC: Palmer Dabbelt <palmerdabbelt@google.com>
CC: Anup Patel <anup@brainfault.org>
CC: Paul Walmsley <paul.walmsley@sifive.com>
CC: Albert Ou <aou@eecs.berkeley.edu>
CC: Zong Li <zong.li@sifive.com>
CC: Mike Rapoport <rppt@kernel.org>
CC: Kefeng Wang <wangkefeng.wang@huawei.com>
CC: Yash Shah <yash.shah@sifive.com>
CC: linux-riscv(a)lists.infradead.org

From: kernel test robot <lkp@intel.com>

arch/riscv/mm/init.c:283:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG.
Please make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h)

 Use BUG_ON instead of a if condition followed by BUG.

Semantic patch information:
 This makes an effort to find cases where BUG() follows an if
 condition on an expression and replaces the if condition and BUG()
 with a BUG_ON having the conditional expression of the if statement
 as argument.

Generated by: scripts/coccinelle/misc/bugon.cocci

Fixes: e8dcb61f2ade ("RISC-V: Implement late mapping page table allocation functions")
CC: Atish Patra <atish.patra@wdc.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git for-next
head:   de22d2107ced3cc5355cc9dbbd85e44183546bd5
commit: e8dcb61f2ade040a372d66907d220dd3fdee2505 [19/23] RISC-V: Implement late mapping page table allocation functions
:::::: branch date: 26 hours ago
:::::: commit date: 26 hours ago

Please take the patch only if it's a positive warning. Thanks!

 init.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/arch/riscv/mm/init.c
+++ b/arch/riscv/mm/init.c
@@ -279,8 +279,7 @@ static phys_addr_t alloc_pte_late(uintpt
 	unsigned long vaddr;
 
 	vaddr = __get_free_page(GFP_KERNEL);
-	if (!vaddr || !pgtable_pte_page_ctor(virt_to_page(vaddr)))
-		BUG();
+	BUG_ON(!vaddr || !pgtable_pte_page_ctor(virt_to_page(vaddr)));
 	return __pa(vaddr);
 }