From: LABBE Corentin <clabbe@baylibre.com>
To: Colin King <colin.king@canonical.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
mjpeg-users@lists.sourceforge.net,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH][next] media: zoran: fix spelling mistake and make error message more meaningful
Date: Mon, 05 Oct 2020 10:50:41 +0000 [thread overview]
Message-ID: <20201005105041.GB29306@Red> (raw)
In-Reply-To: <20201002101620.86156-1-colin.king@canonical.com>
On Fri, Oct 02, 2020 at 11:16:20AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a spelling mistake in a pci_err error message. Fix this and
> make the error message a little more meaningful.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/staging/media/zoran/zoran_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/zoran/zoran_driver.c b/drivers/staging/media/zoran/zoran_driver.c
> index 808196ea5b81..d9f8b21edf6a 100644
> --- a/drivers/staging/media/zoran/zoran_driver.c
> +++ b/drivers/staging/media/zoran/zoran_driver.c
> @@ -666,7 +666,7 @@ static int zoran_g_selection(struct file *file, void *__fh, struct v4l2_selectio
>
> if (sel->type != V4L2_BUF_TYPE_VIDEO_OUTPUT &&
> sel->type != V4L2_BUF_TYPE_VIDEO_CAPTURE) {
> - pci_err(zr->pci_dev, "%s invalid combinaison\n", __func__);
> + pci_err(zr->pci_dev, "%s invalid selection type combination\n", __func__);
> return -EINVAL;
> }
>
> --
> 2.27.0
>
Hello
Acked-by: Corentin Labbe <clabbe@baylibre.com>
Thanks
WARNING: multiple messages have this Message-ID (diff)
From: LABBE Corentin <clabbe@baylibre.com>
To: Colin King <colin.king@canonical.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
mjpeg-users@lists.sourceforge.net, linux-media@vger.kernel.org,
devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] media: zoran: fix spelling mistake and make error message more meaningful
Date: Mon, 5 Oct 2020 12:50:41 +0200 [thread overview]
Message-ID: <20201005105041.GB29306@Red> (raw)
In-Reply-To: <20201002101620.86156-1-colin.king@canonical.com>
On Fri, Oct 02, 2020 at 11:16:20AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a spelling mistake in a pci_err error message. Fix this and
> make the error message a little more meaningful.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/staging/media/zoran/zoran_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/zoran/zoran_driver.c b/drivers/staging/media/zoran/zoran_driver.c
> index 808196ea5b81..d9f8b21edf6a 100644
> --- a/drivers/staging/media/zoran/zoran_driver.c
> +++ b/drivers/staging/media/zoran/zoran_driver.c
> @@ -666,7 +666,7 @@ static int zoran_g_selection(struct file *file, void *__fh, struct v4l2_selectio
>
> if (sel->type != V4L2_BUF_TYPE_VIDEO_OUTPUT &&
> sel->type != V4L2_BUF_TYPE_VIDEO_CAPTURE) {
> - pci_err(zr->pci_dev, "%s invalid combinaison\n", __func__);
> + pci_err(zr->pci_dev, "%s invalid selection type combination\n", __func__);
> return -EINVAL;
> }
>
> --
> 2.27.0
>
Hello
Acked-by: Corentin Labbe <clabbe@baylibre.com>
Thanks
next prev parent reply other threads:[~2020-10-05 10:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 10:16 [PATCH][next] media: zoran: fix spelling mistake and make error message more meaningful Colin King
2020-10-02 10:16 ` Colin King
2020-10-05 10:50 ` LABBE Corentin [this message]
2020-10-05 10:50 ` LABBE Corentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005105041.GB29306@Red \
--to=clabbe@baylibre.com \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mjpeg-users@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.