From: Jason Gunthorpe <jgg@nvidia.com>
To: Jann Horn <jannh@google.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Richard Weinberger <richard@nod.at>,
Jeff Dike <jdike@addtoit.com>,
linux-um@lists.infradead.org, LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
"Eric W . Biederman" <ebiederm@xmission.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
John Hubbard <jhubbard@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michel Lespinasse <walken@google.com>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>
Subject: Re: [PATCH 1/2] mmap locking API: Order lock of nascent mm outside lock of live mm
Date: Mon, 5 Oct 2020 09:52:16 -0300 [thread overview]
Message-ID: <20201005125216.GV816047@nvidia.com> (raw)
In-Reply-To: <CAG48ez0LuG9nULaBF_3ofE--u=TBgbxVdACthpb8wtJhADO02w@mail.gmail.com>
On Mon, Oct 05, 2020 at 03:30:43AM +0200, Jann Horn wrote:
> But another place where lockdep asserts should be added is find_vma();
> there are currently several architectures that sometimes improperly
> call that with no lock held:
Yes, I've seen several cases of this mis-use in drivers too
Jason
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Jann Horn <jannh@google.com>
Cc: Michel Lespinasse <walken@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
"Eric W . Biederman" <ebiederm@xmission.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Jeff Dike <jdike@addtoit.com>,
"Richard Weinberger" <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
<linux-um@lists.infradead.org>,
John Hubbard <jhubbard@nvidia.com>
Subject: Re: [PATCH 1/2] mmap locking API: Order lock of nascent mm outside lock of live mm
Date: Mon, 5 Oct 2020 09:52:16 -0300 [thread overview]
Message-ID: <20201005125216.GV816047@nvidia.com> (raw)
In-Reply-To: <CAG48ez0LuG9nULaBF_3ofE--u=TBgbxVdACthpb8wtJhADO02w@mail.gmail.com>
On Mon, Oct 05, 2020 at 03:30:43AM +0200, Jann Horn wrote:
> But another place where lockdep asserts should be added is find_vma();
> there are currently several architectures that sometimes improperly
> call that with no lock held:
Yes, I've seen several cases of this mis-use in drivers too
Jason
next prev parent reply other threads:[~2020-10-05 12:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 1:23 [PATCH 0/2] Broad write-locking of nascent mm in execve Jann Horn
2020-10-02 1:23 ` Jann Horn
2020-10-02 1:24 ` [PATCH 1/2] mmap locking API: Order lock of nascent mm outside lock of live mm Jann Horn
2020-10-02 1:24 ` Jann Horn
2020-10-02 9:17 ` Michel Lespinasse
2020-10-02 9:17 ` Michel Lespinasse
2020-10-02 11:39 ` Jason Gunthorpe
2020-10-02 11:39 ` Jason Gunthorpe
2020-10-02 16:33 ` Jann Horn
2020-10-02 16:33 ` Jann Horn
2020-10-03 21:30 ` Michel Lespinasse
2020-10-05 1:30 ` Jann Horn
2020-10-05 1:30 ` Jann Horn
2020-10-05 12:52 ` Jason Gunthorpe [this message]
2020-10-05 12:52 ` Jason Gunthorpe
2020-10-02 1:25 ` [PATCH 2/2] exec: Broadly lock nascent mm until setup_arg_pages() Jann Horn
2020-10-02 1:25 ` Jann Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005125216.GV816047@nvidia.com \
--to=jgg@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=ebiederm@xmission.com \
--cc=jannh@google.com \
--cc=jdike@addtoit.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-um@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=richard@nod.at \
--cc=sakari.ailus@linux.intel.com \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.