* [PATCH] fix device_attr_show.cocci warnings
2020-10-06 4:38 [linux-next:master 5206/13159] drivers/gpu/drm/amd/pm/amdgpu_pm.c:1771:8-16: WARNING: use scnprintf or sprintf kernel test robot
@ 2020-10-06 4:38 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-10-06 4:38 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 12027 bytes --]
CC: kbuild-all(a)lists.01.org
TO: Alex Deucher <alexander.deucher@amd.com>
CC: Dave Airlie <airlied@redhat.com>
CC: "Christian König" <christian.koenig@amd.com>
CC: David Airlie <airlied@linux.ie>
CC: Daniel Vetter <daniel@ffwll.ch>
CC: Evan Quan <evan.quan@amd.com>
CC: Nirmoy Das <nirmoy.das@amd.com>
CC: Kevin Wang <kevin1.wang@amd.com>
CC: amd-gfx(a)lists.freedesktop.org
CC: dri-devel(a)lists.freedesktop.org
From: kernel test robot <lkp@intel.com>
drivers/gpu/drm/amd/pm/amdgpu_pm.c:1771:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:1809:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:1853:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:287:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:147:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:489:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:505:9-17: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:1572:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:1499:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:1905:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:1878:9-17: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2593:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2563:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2267:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:3059:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:3066:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2283:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2872:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:3022:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:3029:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2235:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2321:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2295:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2251:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2790:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2797:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2831:8-16: WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2838:8-16: WARNING: use scnprintf or sprintf
From Documentation/filesystems/sysfs.txt:
show() must not use snprintf() when formatting the value to be
returned to user space. If you can guarantee that an overflow
will never happen you can use sprintf() otherwise you must use
scnprintf().
Generated by: scripts/coccinelle/api/device_attr_show.cocci
Fixes: 0c8d22fcae2f ("Merge tag 'amd-drm-next-5.10-2020-09-03' of git://people.freedesktop.org/~agd5f/linux into drm-next")
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 2172e358cd1713c5b7c31361ac465edfe55e455c
commit: 0c8d22fcae2f9590a07b000e1724f665820b77f7 [5206/13159] Merge tag 'amd-drm-next-5.10-2020-09-03' of git://people.freedesktop.org/~agd5f/linux into drm-next
:::::: branch date: 4 days ago
:::::: commit date: 4 weeks ago
Please take the patch only if it's a positive warning. Thanks!
amdgpu_pm.c | 56 ++++++++++++++++++++++++++++----------------------------
1 file changed, 28 insertions(+), 28 deletions(-)
--- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
@@ -144,7 +144,7 @@ static ssize_t amdgpu_get_power_dpm_stat
pm_runtime_mark_last_busy(ddev->dev);
pm_runtime_put_autosuspend(ddev->dev);
- return snprintf(buf, PAGE_SIZE, "%s\n",
+ return scnprintf(buf, PAGE_SIZE, "%s\n",
(pm == POWER_STATE_TYPE_BATTERY) ? "battery" :
(pm == POWER_STATE_TYPE_BALANCED) ? "balanced" : "performance");
}
@@ -284,7 +284,7 @@ static ssize_t amdgpu_get_power_dpm_forc
pm_runtime_mark_last_busy(ddev->dev);
pm_runtime_put_autosuspend(ddev->dev);
- return snprintf(buf, PAGE_SIZE, "%s\n",
+ return scnprintf(buf, PAGE_SIZE, "%s\n",
(level == AMD_DPM_FORCED_LEVEL_AUTO) ? "auto" :
(level == AMD_DPM_FORCED_LEVEL_LOW) ? "low" :
(level == AMD_DPM_FORCED_LEVEL_HIGH) ? "high" :
@@ -486,7 +486,7 @@ static ssize_t amdgpu_get_pp_cur_state(s
if (i == data.nums)
i = -EINVAL;
- return snprintf(buf, PAGE_SIZE, "%d\n", i);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", i);
}
static ssize_t amdgpu_get_pp_force_state(struct device *dev,
@@ -502,7 +502,7 @@ static ssize_t amdgpu_get_pp_force_state
if (adev->pp_force_state_enabled)
return amdgpu_get_pp_cur_state(dev, attr, buf);
else
- return snprintf(buf, PAGE_SIZE, "\n");
+ return scnprintf(buf, PAGE_SIZE, "\n");
}
static ssize_t amdgpu_set_pp_force_state(struct device *dev,
@@ -1496,7 +1496,7 @@ static ssize_t amdgpu_get_pp_sclk_od(str
pm_runtime_mark_last_busy(ddev->dev);
pm_runtime_put_autosuspend(ddev->dev);
- return snprintf(buf, PAGE_SIZE, "%d\n", value);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", value);
}
static ssize_t amdgpu_set_pp_sclk_od(struct device *dev,
@@ -1569,7 +1569,7 @@ static ssize_t amdgpu_get_pp_mclk_od(str
pm_runtime_mark_last_busy(ddev->dev);
pm_runtime_put_autosuspend(ddev->dev);
- return snprintf(buf, PAGE_SIZE, "%d\n", value);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", value);
}
static ssize_t amdgpu_set_pp_mclk_od(struct device *dev,
@@ -1768,7 +1768,7 @@ static ssize_t amdgpu_get_gpu_busy_perce
if (r)
return r;
- return snprintf(buf, PAGE_SIZE, "%d\n", value);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", value);
}
/**
@@ -1806,7 +1806,7 @@ static ssize_t amdgpu_get_mem_busy_perce
if (r)
return r;
- return snprintf(buf, PAGE_SIZE, "%d\n", value);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", value);
}
/**
@@ -1850,7 +1850,7 @@ static ssize_t amdgpu_get_pcie_bw(struct
pm_runtime_mark_last_busy(ddev->dev);
pm_runtime_put_autosuspend(ddev->dev);
- return snprintf(buf, PAGE_SIZE, "%llu %llu %i\n",
+ return scnprintf(buf, PAGE_SIZE, "%llu %llu %i\n",
count0, count1, pcie_get_mps(adev->pdev));
}
@@ -1875,7 +1875,7 @@ static ssize_t amdgpu_get_unique_id(stru
return -EPERM;
if (adev->unique_id)
- return snprintf(buf, PAGE_SIZE, "%016llx\n", adev->unique_id);
+ return scnprintf(buf, PAGE_SIZE, "%016llx\n", adev->unique_id);
return 0;
}
@@ -1902,7 +1902,7 @@ static ssize_t amdgpu_get_thermal_thrott
struct drm_device *ddev = dev_get_drvdata(dev);
struct amdgpu_device *adev = drm_to_adev(ddev);
- return snprintf(buf, PAGE_SIZE, "%s: thermal throttling logging %s, with interval %d seconds\n",
+ return scnprintf(buf, PAGE_SIZE, "%s: thermal throttling logging %s, with interval %d seconds\n",
adev_to_drm(adev)->unique,
atomic_read(&adev->throttling_logging_enabled) ? "enabled" : "disabled",
adev->throttling_logging_rs.interval / HZ + 1);
@@ -2232,7 +2232,7 @@ static ssize_t amdgpu_hwmon_show_temp(st
if (r)
return r;
- return snprintf(buf, PAGE_SIZE, "%d\n", temp);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", temp);
}
static ssize_t amdgpu_hwmon_show_temp_thresh(struct device *dev,
@@ -2248,7 +2248,7 @@ static ssize_t amdgpu_hwmon_show_temp_th
else
temp = adev->pm.dpm.thermal.max_temp;
- return snprintf(buf, PAGE_SIZE, "%d\n", temp);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", temp);
}
static ssize_t amdgpu_hwmon_show_hotspot_temp_thresh(struct device *dev,
@@ -2264,7 +2264,7 @@ static ssize_t amdgpu_hwmon_show_hotspot
else
temp = adev->pm.dpm.thermal.max_hotspot_crit_temp;
- return snprintf(buf, PAGE_SIZE, "%d\n", temp);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", temp);
}
static ssize_t amdgpu_hwmon_show_mem_temp_thresh(struct device *dev,
@@ -2280,7 +2280,7 @@ static ssize_t amdgpu_hwmon_show_mem_tem
else
temp = adev->pm.dpm.thermal.max_mem_crit_temp;
- return snprintf(buf, PAGE_SIZE, "%d\n", temp);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", temp);
}
static ssize_t amdgpu_hwmon_show_temp_label(struct device *dev,
@@ -2292,7 +2292,7 @@ static ssize_t amdgpu_hwmon_show_temp_la
if (channel >= PP_TEMP_MAX)
return -EINVAL;
- return snprintf(buf, PAGE_SIZE, "%s\n", temp_label[channel].label);
+ return scnprintf(buf, PAGE_SIZE, "%s\n", temp_label[channel].label);
}
static ssize_t amdgpu_hwmon_show_temp_emergency(struct device *dev,
@@ -2318,7 +2318,7 @@ static ssize_t amdgpu_hwmon_show_temp_em
break;
}
- return snprintf(buf, PAGE_SIZE, "%d\n", temp);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", temp);
}
static ssize_t amdgpu_hwmon_get_pwm1_enable(struct device *dev,
@@ -2560,7 +2560,7 @@ static ssize_t amdgpu_hwmon_get_fan1_min
if (r)
return r;
- return snprintf(buf, PAGE_SIZE, "%d\n", min_rpm);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", min_rpm);
}
static ssize_t amdgpu_hwmon_get_fan1_max(struct device *dev,
@@ -2590,7 +2590,7 @@ static ssize_t amdgpu_hwmon_get_fan1_max
if (r)
return r;
- return snprintf(buf, PAGE_SIZE, "%d\n", max_rpm);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", max_rpm);
}
static ssize_t amdgpu_hwmon_get_fan1_target(struct device *dev,
@@ -2787,14 +2787,14 @@ static ssize_t amdgpu_hwmon_show_vddgfx(
if (r)
return r;
- return snprintf(buf, PAGE_SIZE, "%d\n", vddgfx);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", vddgfx);
}
static ssize_t amdgpu_hwmon_show_vddgfx_label(struct device *dev,
struct device_attribute *attr,
char *buf)
{
- return snprintf(buf, PAGE_SIZE, "vddgfx\n");
+ return scnprintf(buf, PAGE_SIZE, "vddgfx\n");
}
static ssize_t amdgpu_hwmon_show_vddnb(struct device *dev,
@@ -2828,14 +2828,14 @@ static ssize_t amdgpu_hwmon_show_vddnb(s
if (r)
return r;
- return snprintf(buf, PAGE_SIZE, "%d\n", vddnb);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", vddnb);
}
static ssize_t amdgpu_hwmon_show_vddnb_label(struct device *dev,
struct device_attribute *attr,
char *buf)
{
- return snprintf(buf, PAGE_SIZE, "vddnb\n");
+ return scnprintf(buf, PAGE_SIZE, "vddnb\n");
}
static ssize_t amdgpu_hwmon_show_power_avg(struct device *dev,
@@ -2869,7 +2869,7 @@ static ssize_t amdgpu_hwmon_show_power_a
/* convert to microwatts */
uw = (query >> 8) * 1000000 + (query & 0xff) * 1000;
- return snprintf(buf, PAGE_SIZE, "%u\n", uw);
+ return scnprintf(buf, PAGE_SIZE, "%u\n", uw);
}
static ssize_t amdgpu_hwmon_show_power_cap_min(struct device *dev,
@@ -3019,14 +3019,14 @@ static ssize_t amdgpu_hwmon_show_sclk(st
if (r)
return r;
- return snprintf(buf, PAGE_SIZE, "%u\n", sclk * 10 * 1000);
+ return scnprintf(buf, PAGE_SIZE, "%u\n", sclk * 10 * 1000);
}
static ssize_t amdgpu_hwmon_show_sclk_label(struct device *dev,
struct device_attribute *attr,
char *buf)
{
- return snprintf(buf, PAGE_SIZE, "sclk\n");
+ return scnprintf(buf, PAGE_SIZE, "sclk\n");
}
static ssize_t amdgpu_hwmon_show_mclk(struct device *dev,
@@ -3056,14 +3056,14 @@ static ssize_t amdgpu_hwmon_show_mclk(st
if (r)
return r;
- return snprintf(buf, PAGE_SIZE, "%u\n", mclk * 10 * 1000);
+ return scnprintf(buf, PAGE_SIZE, "%u\n", mclk * 10 * 1000);
}
static ssize_t amdgpu_hwmon_show_mclk_label(struct device *dev,
struct device_attribute *attr,
char *buf)
{
- return snprintf(buf, PAGE_SIZE, "mclk\n");
+ return scnprintf(buf, PAGE_SIZE, "mclk\n");
}
/**
^ permalink raw reply [flat|nested] 2+ messages in thread