From: Mark Brown <broonie@kernel.org>
To: Jeremy Linton <jeremy.linton@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, ardb@kernel.org, will@kernel.org,
catalin.marinas@arm.com, davem@davemloft.net,
herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org,
dave.martin@arm.com
Subject: Re: [BUG][PATCH v3] crypto: arm64: Use x16 with indirect branch to bti_c
Date: Tue, 6 Oct 2020 17:39:43 +0100 [thread overview]
Message-ID: <20201006163943.GD5259@sirena.org.uk> (raw)
In-Reply-To: <20201006163326.2780619-1-jeremy.linton@arm.com>
[-- Attachment #1: Type: text/plain, Size: 331 bytes --]
On Tue, Oct 06, 2020 at 11:33:26AM -0500, Jeremy Linton wrote:
> The AES code uses a 'br x7' as part of a function called by
> a macro. That branch needs a bti_j as a target. This results
> in a panic as seen below. Using x16 (or x17) with an indirect
> branch keeps the target bti_c.
Reviewed-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Jeremy Linton <jeremy.linton@arm.com>
Cc: herbert@gondor.apana.org.au, catalin.marinas@arm.com,
linux-kernel@vger.kernel.org, ardb@kernel.org,
linux-crypto@vger.kernel.org, will@kernel.org,
davem@davemloft.net, linux-arm-kernel@lists.infradead.org,
dave.martin@arm.com
Subject: Re: [BUG][PATCH v3] crypto: arm64: Use x16 with indirect branch to bti_c
Date: Tue, 6 Oct 2020 17:39:43 +0100 [thread overview]
Message-ID: <20201006163943.GD5259@sirena.org.uk> (raw)
In-Reply-To: <20201006163326.2780619-1-jeremy.linton@arm.com>
[-- Attachment #1.1: Type: text/plain, Size: 331 bytes --]
On Tue, Oct 06, 2020 at 11:33:26AM -0500, Jeremy Linton wrote:
> The AES code uses a 'br x7' as part of a function called by
> a macro. That branch needs a bti_j as a target. This results
> in a panic as seen below. Using x16 (or x17) with an indirect
> branch keeps the target bti_c.
Reviewed-by: Mark Brown <broonie@kernel.org>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-06 16:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 16:33 [BUG][PATCH v3] crypto: arm64: Use x16 with indirect branch to bti_c Jeremy Linton
2020-10-06 16:33 ` Jeremy Linton
2020-10-06 16:34 ` Ard Biesheuvel
2020-10-06 16:34 ` Ard Biesheuvel
2020-10-06 16:39 ` Mark Brown [this message]
2020-10-06 16:39 ` Mark Brown
2020-10-06 17:31 ` [PATCH " Catalin Marinas
2020-10-07 8:49 ` [BUG][PATCH " Dave Martin
2020-10-07 8:49 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006163943.GD5259@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dave.martin@arm.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jeremy.linton@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.