From: Rob Herring <robh@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Timur Tabi <timur@kernel.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Mark Brown <broonie@kernel.org>,
Primoz Fiser <primoz.fiser@norik.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>
Subject: Re: [PATCH 2/2] ASoC: dt-bindings: fsl: add ac97 fixed mode support
Date: Tue, 6 Oct 2020 16:52:39 -0500 [thread overview]
Message-ID: <20201006215239.GA2912752@bogus> (raw)
In-Reply-To: <CAOMZO5CQkh06TfKj3qR9P+0ZQOQo07NAg8v9j==KMrLCWBn0mg@mail.gmail.com>
On Mon, Oct 05, 2020 at 08:35:58AM -0300, Fabio Estevam wrote:
> On Mon, Oct 5, 2020 at 8:16 AM Primoz Fiser <primoz.fiser@norik.com> wrote:
> >
> > Add devicetree bindings documentation for operating SSI in AC'97
> > variable/fixed mode of operation.
> >
> > Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
> > ---
> > Documentation/devicetree/bindings/sound/fsl,ssi.txt | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/fsl,ssi.txt b/Documentation/devicetree/bindings/sound/fsl,ssi.txt
> > index 7e15a85cecd2..abc5abe11fb9 100644
> > --- a/Documentation/devicetree/bindings/sound/fsl,ssi.txt
> > +++ b/Documentation/devicetree/bindings/sound/fsl,ssi.txt
> > @@ -43,6 +43,11 @@ Optional properties:
> > - fsl,mode: The operating mode for the AC97 interface only.
> > "ac97-slave" - AC97 mode, SSI is clock slave
> > "ac97-master" - AC97 mode, SSI is clock master
> > +- fsl,ac97-mode: SSI AC97 mode of operation.
> > + "variable" - AC97 Variable Mode, SLOTREQ bits determine
> > + next receive/transmit frame
> > + "fixed" - AC97 Fixed Mode, SSI transmits in accordance with
> > + AC97 Frame Rate Divider bits
>
> It would be good to mention what is the default mode when such
> property is absent.
Then perhaps it could be boolean?
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Primoz Fiser <primoz.fiser@norik.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Timur Tabi <timur@kernel.org>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/2] ASoC: dt-bindings: fsl: add ac97 fixed mode support
Date: Tue, 6 Oct 2020 16:52:39 -0500 [thread overview]
Message-ID: <20201006215239.GA2912752@bogus> (raw)
In-Reply-To: <CAOMZO5CQkh06TfKj3qR9P+0ZQOQo07NAg8v9j==KMrLCWBn0mg@mail.gmail.com>
On Mon, Oct 05, 2020 at 08:35:58AM -0300, Fabio Estevam wrote:
> On Mon, Oct 5, 2020 at 8:16 AM Primoz Fiser <primoz.fiser@norik.com> wrote:
> >
> > Add devicetree bindings documentation for operating SSI in AC'97
> > variable/fixed mode of operation.
> >
> > Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
> > ---
> > Documentation/devicetree/bindings/sound/fsl,ssi.txt | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/fsl,ssi.txt b/Documentation/devicetree/bindings/sound/fsl,ssi.txt
> > index 7e15a85cecd2..abc5abe11fb9 100644
> > --- a/Documentation/devicetree/bindings/sound/fsl,ssi.txt
> > +++ b/Documentation/devicetree/bindings/sound/fsl,ssi.txt
> > @@ -43,6 +43,11 @@ Optional properties:
> > - fsl,mode: The operating mode for the AC97 interface only.
> > "ac97-slave" - AC97 mode, SSI is clock slave
> > "ac97-master" - AC97 mode, SSI is clock master
> > +- fsl,ac97-mode: SSI AC97 mode of operation.
> > + "variable" - AC97 Variable Mode, SLOTREQ bits determine
> > + next receive/transmit frame
> > + "fixed" - AC97 Fixed Mode, SSI transmits in accordance with
> > + AC97 Frame Rate Divider bits
>
> It would be good to mention what is the default mode when such
> property is absent.
Then perhaps it could be boolean?
Rob
next prev parent reply other threads:[~2020-10-06 21:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 11:16 [PATCH 1/2] ASoC: fsl: fsl_ssi: add ac97 fixed mode support Primoz Fiser
2020-10-05 11:16 ` Primoz Fiser
2020-10-05 11:16 ` [PATCH 2/2] ASoC: dt-bindings: fsl: " Primoz Fiser
2020-10-05 11:16 ` Primoz Fiser
2020-10-05 11:35 ` Fabio Estevam
2020-10-05 11:35 ` Fabio Estevam
2020-10-06 21:52 ` Rob Herring [this message]
2020-10-06 21:52 ` Rob Herring
2020-10-07 6:49 ` Primoz Fiser
2020-10-07 6:49 ` Primoz Fiser
2020-10-05 11:34 ` [PATCH 1/2] ASoC: fsl: fsl_ssi: " Fabio Estevam
2020-10-05 11:34 ` Fabio Estevam
2020-10-05 11:49 ` Mark Brown
2020-10-05 11:49 ` Mark Brown
2020-10-05 12:59 ` Primoz Fiser
2020-10-05 12:59 ` Primoz Fiser
2020-10-05 13:51 ` Maciej S. Szmigiero
2020-10-05 13:51 ` Maciej S. Szmigiero
2020-10-07 7:01 ` Primoz Fiser
2020-10-07 7:01 ` Primoz Fiser
2020-10-05 22:03 ` Mark Brown
2020-10-05 22:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006215239.GA2912752@bogus \
--to=robh@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=nicoleotsuka@gmail.com \
--cc=primoz.fiser@norik.com \
--cc=shengjiu.wang@gmail.com \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.