From: Christoph Hellwig <hch@lst.de>
To: Stefano Stabellini <stefano.stabellini@xilinx.com>
Cc: xen-devel@lists.xenproject.org, iommu@lists.linux-foundation.org,
Christoph Hellwig <hch@lst.de>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: xen-swiotlb vs phys_to_dma
Date: Wed, 7 Oct 2020 08:00:08 +0200 [thread overview]
Message-ID: <20201007060008.GA10125@lst.de> (raw)
In-Reply-To: <alpine.DEB.2.21.2010061325230.10908@sstabellini-ThinkPad-T480s>
On Tue, Oct 06, 2020 at 01:46:12PM -0700, Stefano Stabellini wrote:
> OK, this makes a lot of sense, and I like the patch because it makes the
> swiotlb interface clearer.
>
> Just one comment below.
>
> > +phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t orig_addr,
> > + size_t mapping_size, size_t alloc_size,
> > + enum dma_data_direction dir, unsigned long attrs)
> > {
> > + dma_addr_t tbl_dma_addr = phys_to_dma_unencrypted(dev, io_tlb_start);
>
> This is supposed to be hwdev, not dev
Yeah, te compiler would be rather unhappy oterwise.
I'll resend it after the dma-mapping and Xen trees are merged by Linus
to avoid a merge conflict.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Stefano Stabellini <stefano.stabellini@xilinx.com>
Cc: Christoph Hellwig <hch@lst.de>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
xen-devel@lists.xenproject.org, iommu@lists.linux-foundation.org
Subject: Re: xen-swiotlb vs phys_to_dma
Date: Wed, 7 Oct 2020 08:00:08 +0200 [thread overview]
Message-ID: <20201007060008.GA10125@lst.de> (raw)
In-Reply-To: <alpine.DEB.2.21.2010061325230.10908@sstabellini-ThinkPad-T480s>
On Tue, Oct 06, 2020 at 01:46:12PM -0700, Stefano Stabellini wrote:
> OK, this makes a lot of sense, and I like the patch because it makes the
> swiotlb interface clearer.
>
> Just one comment below.
>
> > +phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t orig_addr,
> > + size_t mapping_size, size_t alloc_size,
> > + enum dma_data_direction dir, unsigned long attrs)
> > {
> > + dma_addr_t tbl_dma_addr = phys_to_dma_unencrypted(dev, io_tlb_start);
>
> This is supposed to be hwdev, not dev
Yeah, te compiler would be rather unhappy oterwise.
I'll resend it after the dma-mapping and Xen trees are merged by Linus
to avoid a merge conflict.
next prev parent reply other threads:[~2020-10-07 6:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 12:34 xen-swiotlb vs phys_to_dma Christoph Hellwig
2020-10-02 12:34 ` Christoph Hellwig
2020-10-02 20:21 ` Stefano Stabellini
2020-10-02 20:21 ` Stefano Stabellini
2020-10-06 8:26 ` Christoph Hellwig
2020-10-06 8:26 ` Christoph Hellwig
2020-10-06 20:46 ` Stefano Stabellini
2020-10-06 20:46 ` Stefano Stabellini
2020-10-07 6:00 ` Christoph Hellwig [this message]
2020-10-07 6:00 ` Christoph Hellwig
2020-10-07 17:15 ` Stefano Stabellini
2020-10-07 17:15 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007060008.GA10125@lst.de \
--to=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=konrad.wilk@oracle.com \
--cc=stefano.stabellini@xilinx.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.