All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Yonggang Luo" <luoyonggang@gmail.com>,
	qemu-devel@nongnu.org, "QEMU Trivial" <qemu-trivial@nongnu.org>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH v3 2/3] cirrus: Fixing and speedup the msys2/mingw CI
Date: Wed, 7 Oct 2020 09:32:02 +0100	[thread overview]
Message-ID: <20201007083202.GF2505881@redhat.com> (raw)
In-Reply-To: <6b4528dc-918d-ebf4-db27-cbd67fa96c11@redhat.com>

On Wed, Oct 07, 2020 at 10:18:48AM +0200, Paolo Bonzini wrote:
> On 07/10/20 05:51, Yonggang Luo wrote:
> > Using a prepared https://github.com/lygstate/qemu/releases/download/v5.1.0/msys2-x86_64.tar.xz
> > for speed up the msys2/mingw prepare speed on the cirrus CI.
> > This file are generated by the msys2.docker
> 
> The speedup is nice, but we need to be able to regenerate the tarball
> without access to a Windows machine.  Otherwise whoever adds a new
> dependency cannot test it himself with CI.
> 
> Ideally, the tarball would be generated by the containers job in the
> Gitlab CI, but I'm not sure if that's possible.

IMHO any caching should be integrated into the Cirrus CI job itself.
Cirrus has builtin support for caching the contents of a folder, so
the first time the job runs it should populate the cache, and that
can be used thereafter.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



WARNING: multiple messages have this Message-ID (diff)
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"QEMU Trivial" <qemu-trivial@nongnu.org>,
	qemu-devel@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Yonggang Luo" <luoyonggang@gmail.com>
Subject: Re: [PATCH v3 2/3] cirrus: Fixing and speedup the msys2/mingw CI
Date: Wed, 7 Oct 2020 09:32:02 +0100	[thread overview]
Message-ID: <20201007083202.GF2505881@redhat.com> (raw)
In-Reply-To: <6b4528dc-918d-ebf4-db27-cbd67fa96c11@redhat.com>

On Wed, Oct 07, 2020 at 10:18:48AM +0200, Paolo Bonzini wrote:
> On 07/10/20 05:51, Yonggang Luo wrote:
> > Using a prepared https://github.com/lygstate/qemu/releases/download/v5.1.0/msys2-x86_64.tar.xz
> > for speed up the msys2/mingw prepare speed on the cirrus CI.
> > This file are generated by the msys2.docker
> 
> The speedup is nice, but we need to be able to regenerate the tarball
> without access to a Windows machine.  Otherwise whoever adds a new
> dependency cannot test it himself with CI.
> 
> Ideally, the tarball would be generated by the containers job in the
> Gitlab CI, but I'm not sure if that's possible.

IMHO any caching should be integrated into the Cirrus CI job itself.
Cirrus has builtin support for caching the contents of a folder, so
the first time the job runs it should populate the cache, and that
can be used thereafter.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2020-10-07  8:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07  3:51 [PATCH v3 0/3] Improve cirrus msys2 Yonggang Luo
2020-10-07  3:51 ` Yonggang Luo
2020-10-07  3:51 ` [PATCH v3 1/3] docker: Add win32/msys2/mingw64 docker Yonggang Luo
2020-10-07  3:51   ` Yonggang Luo
2020-10-07  3:51 ` [PATCH v3 2/3] cirrus: Fixing and speedup the msys2/mingw CI Yonggang Luo
2020-10-07  3:51   ` Yonggang Luo
2020-10-07  8:18   ` Paolo Bonzini
2020-10-07  8:18     ` Paolo Bonzini
2020-10-07  8:32     ` Daniel P. Berrangé [this message]
2020-10-07  8:32       ` Daniel P. Berrangé
2020-10-07  8:41     ` Thomas Huth
2020-10-07  8:41       ` Thomas Huth
2020-10-07  8:54       ` 罗勇刚(Yonggang Luo)
2020-10-07  8:54         ` 罗勇刚(Yonggang Luo)
2020-10-07  3:51 ` [PATCH v3 3/3] cirrus: msys2/mingw speed is up, add excluded target back Yonggang Luo
2020-10-07  3:51   ` Yonggang Luo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201007083202.GF2505881@redhat.com \
    --to=berrange@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=luoyonggang@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.