* [android-common:android-mainline 1/1] drivers/scsi/ufs/ufshcd.c:7443 ufshcd_clear_ua_wlun() warn: inconsistent returns
@ 2020-10-06 7:04 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2020-10-06 7:04 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 3481 bytes --]
CC: kbuild-all(a)lists.01.org
TO: cros-kernel-buildreports(a)googlegroups.com
tree: https://android.googlesource.com/kernel/common android-mainline
head: fedfc101f8f5356727d023c3ad47b2bafe316c8b
commit: fedfc101f8f5356727d023c3ad47b2bafe316c8b [1/1] FROMLIST: scsi: ufs: clear uac for rpmb lun
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago
config: i386-randconfig-m021-20201004 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/scsi/ufs/ufshcd.c:7443 ufshcd_clear_ua_wlun() warn: inconsistent returns '*hba->host->host_lock'.
drivers/scsi/ufs/ufshcd.c:7443 ufshcd_clear_ua_wlun() warn: inconsistent returns 'flags'.
vim +7443 drivers/scsi/ufs/ufshcd.c
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7409
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7410 static int ufshcd_clear_ua_wlun(struct ufs_hba *hba, u8 wlun)
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7411 {
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7412 struct scsi_device *sdp;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7413 unsigned long flags;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7414 int ret = 0;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7415
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7416 spin_lock_irqsave(hba->host->host_lock, flags);
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7417 if (wlun == UFS_UPIU_UFS_DEVICE_WLUN)
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7418 sdp = hba->sdev_ufs_device;
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7419 else if (wlun == UFS_UPIU_RPMB_WLUN)
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7420 sdp = hba->sdev_rpmb;
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7421 else
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7422 return -EINVAL;
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7423
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7424 if (sdp) {
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7425 ret = scsi_device_get(sdp);
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7426 if (!ret && !scsi_device_online(sdp)) {
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7427 ret = -ENODEV;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7428 scsi_device_put(sdp);
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7429 }
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7430 } else {
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7431 ret = -ENODEV;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7432 }
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7433 spin_unlock_irqrestore(hba->host->host_lock, flags);
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7434 if (ret)
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7435 goto out_err;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7436
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7437 ret = ufshcd_send_request_sense(hba, sdp);
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7438 scsi_device_put(sdp);
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7439 out_err:
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7440 if (ret)
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7441 dev_err(hba->dev, "%s: UAC clear LU=%x ret = %d\n",
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7442 __func__, wlun, ret);
fedfc101f8f535 Jaegeuk Kim 2020-10-05 @7443 return ret;
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7444 }
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7445
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33215 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [android-common:android-mainline 1/1] drivers/scsi/ufs/ufshcd.c:7443 ufshcd_clear_ua_wlun() warn: inconsistent returns
@ 2020-10-07 8:44 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2020-10-07 8:44 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 3348 bytes --]
tree: https://android.googlesource.com/kernel/common android-mainline
head: fedfc101f8f5356727d023c3ad47b2bafe316c8b
commit: fedfc101f8f5356727d023c3ad47b2bafe316c8b [1/1] FROMLIST: scsi: ufs: clear uac for rpmb lun
config: i386-randconfig-m021-20201004 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/scsi/ufs/ufshcd.c:7443 ufshcd_clear_ua_wlun() warn: inconsistent returns '*hba->host->host_lock'.
drivers/scsi/ufs/ufshcd.c:7443 ufshcd_clear_ua_wlun() warn: inconsistent returns 'flags'.
vim +7443 drivers/scsi/ufs/ufshcd.c
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7410 static int ufshcd_clear_ua_wlun(struct ufs_hba *hba, u8 wlun)
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7411 {
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7412 struct scsi_device *sdp;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7413 unsigned long flags;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7414 int ret = 0;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7415
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7416 spin_lock_irqsave(hba->host->host_lock, flags);
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7417 if (wlun == UFS_UPIU_UFS_DEVICE_WLUN)
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7418 sdp = hba->sdev_ufs_device;
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7419 else if (wlun == UFS_UPIU_RPMB_WLUN)
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7420 sdp = hba->sdev_rpmb;
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7421 else
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7422 return -EINVAL;
^^^^^^^^^^^^^^^
Need to unlock before returning.
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7423
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7424 if (sdp) {
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7425 ret = scsi_device_get(sdp);
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7426 if (!ret && !scsi_device_online(sdp)) {
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7427 ret = -ENODEV;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7428 scsi_device_put(sdp);
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7429 }
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7430 } else {
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7431 ret = -ENODEV;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7432 }
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7433 spin_unlock_irqrestore(hba->host->host_lock, flags);
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7434 if (ret)
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7435 goto out_err;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7436
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7437 ret = ufshcd_send_request_sense(hba, sdp);
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7438 scsi_device_put(sdp);
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7439 out_err:
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7440 if (ret)
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7441 dev_err(hba->dev, "%s: UAC clear LU=%x ret = %d\n",
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7442 __func__, wlun, ret);
fedfc101f8f535 Jaegeuk Kim 2020-10-05 @7443 return ret;
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7444 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33215 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [android-common:android-mainline 1/1] drivers/scsi/ufs/ufshcd.c:7443 ufshcd_clear_ua_wlun() warn: inconsistent returns
@ 2020-10-07 8:44 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2020-10-07 8:44 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3348 bytes --]
tree: https://android.googlesource.com/kernel/common android-mainline
head: fedfc101f8f5356727d023c3ad47b2bafe316c8b
commit: fedfc101f8f5356727d023c3ad47b2bafe316c8b [1/1] FROMLIST: scsi: ufs: clear uac for rpmb lun
config: i386-randconfig-m021-20201004 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/scsi/ufs/ufshcd.c:7443 ufshcd_clear_ua_wlun() warn: inconsistent returns '*hba->host->host_lock'.
drivers/scsi/ufs/ufshcd.c:7443 ufshcd_clear_ua_wlun() warn: inconsistent returns 'flags'.
vim +7443 drivers/scsi/ufs/ufshcd.c
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7410 static int ufshcd_clear_ua_wlun(struct ufs_hba *hba, u8 wlun)
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7411 {
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7412 struct scsi_device *sdp;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7413 unsigned long flags;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7414 int ret = 0;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7415
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7416 spin_lock_irqsave(hba->host->host_lock, flags);
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7417 if (wlun == UFS_UPIU_UFS_DEVICE_WLUN)
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7418 sdp = hba->sdev_ufs_device;
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7419 else if (wlun == UFS_UPIU_RPMB_WLUN)
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7420 sdp = hba->sdev_rpmb;
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7421 else
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7422 return -EINVAL;
^^^^^^^^^^^^^^^
Need to unlock before returning.
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7423
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7424 if (sdp) {
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7425 ret = scsi_device_get(sdp);
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7426 if (!ret && !scsi_device_online(sdp)) {
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7427 ret = -ENODEV;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7428 scsi_device_put(sdp);
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7429 }
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7430 } else {
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7431 ret = -ENODEV;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7432 }
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7433 spin_unlock_irqrestore(hba->host->host_lock, flags);
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7434 if (ret)
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7435 goto out_err;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7436
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7437 ret = ufshcd_send_request_sense(hba, sdp);
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7438 scsi_device_put(sdp);
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7439 out_err:
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7440 if (ret)
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7441 dev_err(hba->dev, "%s: UAC clear LU=%x ret = %d\n",
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7442 __func__, wlun, ret);
fedfc101f8f535 Jaegeuk Kim 2020-10-05 @7443 return ret;
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7444 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33215 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-07 8:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-07 8:44 [android-common:android-mainline 1/1] drivers/scsi/ufs/ufshcd.c:7443 ufshcd_clear_ua_wlun() warn: inconsistent returns Dan Carpenter
2020-10-07 8:44 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2020-10-06 7:04 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.