From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: v.narang@samsung.com, a.sahrawat@samsung.com,
akpm@linux-foundation.org, maz@kernel.org, bigeasy@linutronix.de,
vincent.whitchurch@axis.com, ndesaulniers@google.com,
linux-kernel@vger.kernel.org, valentin.schneider@arm.com,
0x7f454c46@gmail.com, tglx@linutronix.de, nhuck@google.com,
will@kernel.org, caij2003@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/3] IRQ stack support for ARM
Date: Thu, 8 Oct 2020 09:30:15 +0100 [thread overview]
Message-ID: <20201008083015.GK1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <1602141333-17822-1-git-send-email-maninder1.s@samsung.com>
On Thu, Oct 08, 2020 at 12:45:30PM +0530, Maninder Singh wrote:
> Observed Stack Overflow on 8KB kernel stack on ARM specially
> incase on network interrupts, which results in undeterministic behaviour.
> So there is need for per cpu dedicated IRQ stack for ARM.
>
> As ARm does not have extra co-processor register
> to save thread info pointer, IRQ stack will be at some
> performance cost, so code is under CONFIG_IRQ_STACK.
>
> and we don't have much knowledge and set up for CLANG
> and ARM_UNWIND, so dependency added for both cases.
>
> Tested patch set with QEMU for latest kernel
> and 4.1 kernel for ARM target with same patch set.
You need to investigate and show where and why this is happening. My
guess is you have a network driver that uses a lot of kernel stack
space, which itself would be a bug.
Note that there are compiler versions out there that mis-optimise and
eat stack space - the kernel build should be warning if a function
uses a large amount of stack.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: ndesaulniers@google.com, caij2003@gmail.com, tglx@linutronix.de,
bigeasy@linutronix.de, maz@kernel.org,
valentin.schneider@arm.com, vincent.whitchurch@axis.com,
nhuck@google.com, akpm@linux-foundation.org,
0x7f454c46@gmail.com, will@kernel.org, a.sahrawat@samsung.com,
v.narang@samsung.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] IRQ stack support for ARM
Date: Thu, 8 Oct 2020 09:30:15 +0100 [thread overview]
Message-ID: <20201008083015.GK1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <1602141333-17822-1-git-send-email-maninder1.s@samsung.com>
On Thu, Oct 08, 2020 at 12:45:30PM +0530, Maninder Singh wrote:
> Observed Stack Overflow on 8KB kernel stack on ARM specially
> incase on network interrupts, which results in undeterministic behaviour.
> So there is need for per cpu dedicated IRQ stack for ARM.
>
> As ARm does not have extra co-processor register
> to save thread info pointer, IRQ stack will be at some
> performance cost, so code is under CONFIG_IRQ_STACK.
>
> and we don't have much knowledge and set up for CLANG
> and ARM_UNWIND, so dependency added for both cases.
>
> Tested patch set with QEMU for latest kernel
> and 4.1 kernel for ARM target with same patch set.
You need to investigate and show where and why this is happening. My
guess is you have a network driver that uses a lot of kernel stack
space, which itself would be a bug.
Note that there are compiler versions out there that mis-optimise and
eat stack space - the kernel build should be warning if a function
uses a large amount of stack.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2020-10-08 8:32 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201008071628epcas5p24d196a6023a47a3b0bfa7b7f231ec811@epcas5p2.samsung.com>
2020-10-08 7:15 ` [PATCH 0/3] IRQ stack support for ARM Maninder Singh
2020-10-08 7:15 ` Maninder Singh
2020-10-08 7:15 ` [PATCH 1/3] arm: introduce self pointer in thread info Maninder Singh
2020-10-08 7:15 ` Maninder Singh
2020-10-08 7:15 ` [PATCH 2/3] arm: introduce IRQ stacks Maninder Singh
2020-10-08 7:15 ` Maninder Singh
[not found] ` <CAK8P3a2RYeNiTy9QmwFVKtFifXxWc9XfAT6ThPoSH9wGYsKGpA@mail.gmail.com>
2020-10-21 12:42 ` Arnd Bergmann
2020-10-21 12:42 ` Arnd Bergmann
2020-10-21 12:45 ` Russell King - ARM Linux admin
2020-10-21 12:45 ` Russell King - ARM Linux admin
2020-10-21 12:55 ` Arnd Bergmann
2020-10-21 12:55 ` Arnd Bergmann
2020-10-21 12:57 ` Russell King - ARM Linux admin
2020-10-21 12:57 ` Russell King - ARM Linux admin
2020-10-21 13:46 ` Vaneet Narang
2020-10-21 13:46 ` Vaneet Narang
2020-10-21 15:59 ` Arnd Bergmann
2020-10-21 15:59 ` Arnd Bergmann
2020-11-09 14:45 ` Tony Lindgren
2020-11-09 14:45 ` Tony Lindgren
2020-11-09 19:10 ` Arnd Bergmann
2020-11-09 19:10 ` Arnd Bergmann
2020-11-10 9:19 ` Tony Lindgren
2020-11-10 9:19 ` Tony Lindgren
2020-11-10 10:04 ` Arnd Bergmann
2020-11-10 10:04 ` Arnd Bergmann
2020-11-10 12:04 ` Tony Lindgren
2020-11-10 12:04 ` Tony Lindgren
2020-11-10 13:35 ` Arnd Bergmann
2020-11-10 13:35 ` Arnd Bergmann
2020-11-11 6:56 ` Tony Lindgren
2020-11-11 6:56 ` Tony Lindgren
2020-10-08 7:15 ` [PATCH 3/3] arm: Modify stack trace and dump for use with irq stack Maninder Singh
2020-10-08 7:15 ` Maninder Singh
2020-10-08 7:53 ` [PATCH 0/3] IRQ stack support for ARM Sebastian Andrzej Siewior
2020-10-08 7:53 ` Sebastian Andrzej Siewior
2020-10-08 8:30 ` Russell King - ARM Linux admin [this message]
2020-10-08 8:30 ` Russell King - ARM Linux admin
2020-10-15 20:59 ` Nick Desaulniers
2020-10-15 20:59 ` Nick Desaulniers
2020-10-15 21:16 ` Florian Fainelli
2020-10-15 21:16 ` Florian Fainelli
[not found] ` <CAK8P3a0h=D8_Kn_fpHbsik_jf4to2jayxj7K7B7=HaNFzKqNnw@mail.gmail.com>
2020-10-21 11:58 ` Arnd Bergmann
2020-10-21 11:58 ` Arnd Bergmann
2020-10-21 12:34 ` Russell King - ARM Linux admin
2020-10-21 12:34 ` Russell King - ARM Linux admin
2020-10-21 12:46 ` Arnd Bergmann
2020-10-21 12:46 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008083015.GK1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=0x7f454c46@gmail.com \
--cc=a.sahrawat@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=caij2003@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=maz@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nhuck@google.com \
--cc=tglx@linutronix.de \
--cc=v.narang@samsung.com \
--cc=valentin.schneider@arm.com \
--cc=vincent.whitchurch@axis.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.