From: Marek Behun <marek.behun@nic.cz>
To: Vadim Pasternak <vadimp@nvidia.com>
Cc: Pavel Machek <pavel@ucw.cz>,
"jacek.anaszewski@gmail.com" <jacek.anaszewski@gmail.com>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>
Subject: Re: [PATCH led-next 1/1] leds: mlxreg: Allow multi-instantiation of same name LED for modular systems
Date: Thu, 8 Oct 2020 10:55:50 +0200 [thread overview]
Message-ID: <20201008105550.44fa3165@nic.cz> (raw)
In-Reply-To: <DM6PR12MB389877E86421231E18EF7DCDAF0B0@DM6PR12MB3898.namprd12.prod.outlook.com>
On Thu, 8 Oct 2020 08:47:45 +0000
Vadim Pasternak <vadimp@nvidia.com> wrote:
> >
> > But noone is currently using mlxreg123 in their applications, so that part is not
> > going in.
>
> Yes, this is true.
> I could modify it as:
>
> if (priv->pdev->id > 0)
> sprintf(led_data->led_cdev_name, "%s%d:%s", "card",
> priv->pdev->id, data->label);
> else
> sprintf(led_data->led_cdev_name, "%s:%s", "mlxreg",
> data->label);
>
Vadim, the LED core constructs names in form
device:color:function-enumerator
so if you must have number there, IMO it should be
mlxreg:green:status-48
mlxreg:green:status-56
...
Marek
next prev parent reply other threads:[~2020-10-08 8:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 16:58 [PATCH led-next 1/1] leds: mlxreg: Allow multi-instantiation of same name LED for modular systems Vadim Pasternak
2020-10-06 23:15 ` Marek Behun
2020-10-07 6:07 ` Vadim Pasternak
2020-10-07 12:17 ` Marek Behun
2020-10-07 11:31 ` Pavel Machek
2020-10-07 12:20 ` Marek Behun
2020-10-08 6:16 ` Vadim Pasternak
2020-10-08 7:56 ` Pavel Machek
2020-10-08 8:47 ` Vadim Pasternak
2020-10-08 8:55 ` Marek Behun [this message]
2020-10-08 9:30 ` Vadim Pasternak
2020-10-08 10:05 ` Pavel Machek
2020-10-08 10:32 ` Vadim Pasternak
2020-11-25 11:20 ` Pavel Machek
2020-11-25 12:01 ` Vadim Pasternak
2020-12-30 18:48 ` Pavel Machek
2020-10-08 10:32 ` Marek Behun
2020-10-12 10:14 ` Vadim Pasternak
2020-10-21 8:33 ` Pavel Machek
2020-10-21 12:29 ` Vadim Pasternak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008105550.44fa3165@nic.cz \
--to=marek.behun@nic.cz \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=vadimp@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.