Re: [PATCH led-next 1/1] leds: mlxreg: Allow multi-instantiation of same name LED for modular systems

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 2103 bytes --]

Hi!

> > And yes, if you have some kind of device with a status LED, then you can put
> > that into the first card. For example sda::status would be accetpable. But
> > cardXX is way too generic.
> > 
> > Perhaps you can explain what "card" is in this context? What is its main
> > function?
> 
> I provide support for new modular systems which could be equipped with the
> different types of replaceable line cards and management board.
> The first type of line card is 16x100GbE QSFP28 Ethernet ports.
> It equipped with Lattice CPLD device aimed for system and ASIC control, Nvidia FPGA,
> Nvidia gearboxes (PHYs).
> 
> After that we'll have other line cards: 8x200Gbe QSFP28 Eth ports, 4x400Gbe Eth QSFP-DD,
> smart cards equipped with Nvidia ARM CPU for offloading and for fast access to the storage
> (EBoF).
> 
> For this modular system CPLDs are connected through I2C bus and LED driver will work
> over I2C. On main plane CPLD is connected through LPC, and LED driver works over LPC.
> 
> Card is common name. But I'd like to avoid some more specific names.
> 
> For example, we have huge InfiniBand modular systems with 800 of IB 200G and 400G
> ports, which I didn't have yet in upstream. Those system have also replaceable line cards
> (so called leaves) and replaceable fabric cards (so called spines).
> If I'll give name 'card<bus#>, it will be good also for those systems.
> If I'll give more specific name, it'll be not so good name for
 > fabric cards.

Ok, I guess card<something> is best suggestion so far. If it is really
status for specific PCI card, then that's the right way to name it.

Maybe "pciecard<>" would be even better.

Plus we really should have documentation somewhere so that next
person trying to name a LED on a card ends up with same answer.

> I can use name 'fru' instead of 'card' which is standard name and stands for
> 'Filed Replicable Unit'. Such name will be good for line cards, for fabric cards,
> for power units, FANs etcetera.

Best regards,

									Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]