Re: [PATCH V5 3/3] i2c: i2c-qcom-geni: Add shutdown callback for i2c

[Dan Carpenter <dan.carpenter@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 4216 bytes --]

Hi Roja,

url:    https://github.com/0day-ci/linux/commits/Roja-Rani-Yarubandi/Implement-Shutdown-callback-for-geni-i2c/20201001-164636 
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git  i2c/for-next
config: parisc-randconfig-s032-20201008 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross  -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.2-218-gc0e96d6d-dirty
        # https://github.com/0day-ci/linux/commit/d8cd18adc21493e099c0d562dfb53a817ca21926 
        git remote add linux-review https://github.com/0day-ci/linux 
        git fetch --no-tags linux-review Roja-Rani-Yarubandi/Implement-Shutdown-callback-for-geni-i2c/20201001-164636
        git checkout d8cd18adc21493e099c0d562dfb53a817ca21926
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

echo
echo "sparse warnings: (new ones prefixed by >>)"
echo
>> drivers/i2c/busses/i2c-qcom-geni.c:383:13: sparse: sparse: context imbalance in 'geni_i2c_stop_xfer' - different lock contexts for basic block

vim +/geni_i2c_stop_xfer +383 drivers/i2c/busses/i2c-qcom-geni.c

d8cd18adc21493e Roja Rani Yarubandi 2020-10-01 @383  static void geni_i2c_stop_xfer(struct geni_i2c_dev *gi2c)
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  384  {
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  385  	int ret;
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  386  	u32 geni_status;
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  387  	unsigned long flags;
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  388  	struct i2c_msg *cur;
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  389  
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  390  	/* Resume device, runtime suspend can happen anytime during transfer */
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  391  	ret = pm_runtime_get_sync(gi2c->se.dev);
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  392  	if (ret < 0) {
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  393  		dev_err(gi2c->se.dev, "Failed to resume device: %d\n", ret);
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  394  		return;
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  395  	}
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  396  
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  397  	spin_lock_irqsave(&gi2c->lock, flags);
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  398  	geni_status = readl_relaxed(gi2c->se.base + SE_GENI_STATUS);
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  399  	if (!(geni_status & M_GENI_CMD_ACTIVE))
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  400  		goto out;


goto unlock;

d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  401  
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  402  	cur = gi2c->cur;
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  403  	geni_i2c_abort_xfer(gi2c);
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  404  	if (cur->flags & I2C_M_RD)
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  405  		geni_i2c_rx_msg_cleanup(gi2c, cur);
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  406  	else
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  407  		geni_i2c_tx_msg_cleanup(gi2c, cur);
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  408  	spin_unlock_irqrestore(&gi2c->lock, flags);
                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  409  out:
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  410  	pm_runtime_put_sync_suspend(gi2c->se.dev);
d8cd18adc21493e Roja Rani Yarubandi 2020-10-01  411  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org 

_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33727 bytes --]