From: Eric Biggers <ebiggers@kernel.org>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [v2 PATCH] crypto: sun4i-ss - Fix sparse endianness markers
Date: Thu, 8 Oct 2020 16:35:43 -0700 [thread overview]
Message-ID: <20201008233543.GD1869638@gmail.com> (raw)
In-Reply-To: <20201008063623.GA17802@Red>
On Thu, Oct 08, 2020 at 08:36:23AM +0200, Corentin Labbe wrote:
> On Thu, Oct 08, 2020 at 04:52:38PM +1100, Herbert Xu wrote:
> > On Thu, Sep 24, 2020 at 03:27:38PM +0200, Corentin Labbe wrote:
> > >
> > > This is an example on next-20200923+BigEndian
> > > alg: ahash: sha1 test failed (wrong result) on test vector \"random: psize=194 ksize=0\", cfg=\"random: inplace may_sleep use_finup src_divs=[98.25%@+1124, <flush>1.75%@+5] iv_offset=18\"
This failure is in one of the randomly generated test cases. If it doesn't
reproduce reliably, you can set cryptomgr.fuzz_iterations=1000 on the kernel
command line (increased from the default 100).
It is confusing that it says just "sha1". This seems to be a quirk specific to
how tcrypt calls alg_test(). It's probably really testing "sha1-sun4i-ss".
I guess that testmgr.c should be using the actual cra_driver_name in the log
messages, not the 'driver' string that was passed into alg_test().
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: kbuild-all@lists.01.org
Subject: Re: [v2 PATCH] crypto: sun4i-ss - Fix sparse endianness markers
Date: Thu, 08 Oct 2020 16:35:43 -0700 [thread overview]
Message-ID: <20201008233543.GD1869638@gmail.com> (raw)
In-Reply-To: <20201008063623.GA17802@Red>
[-- Attachment #1: Type: text/plain, Size: 971 bytes --]
On Thu, Oct 08, 2020 at 08:36:23AM +0200, Corentin Labbe wrote:
> On Thu, Oct 08, 2020 at 04:52:38PM +1100, Herbert Xu wrote:
> > On Thu, Sep 24, 2020 at 03:27:38PM +0200, Corentin Labbe wrote:
> > >
> > > This is an example on next-20200923+BigEndian
> > > alg: ahash: sha1 test failed (wrong result) on test vector \"random: psize=194 ksize=0\", cfg=\"random: inplace may_sleep use_finup src_divs=[98.25%@+1124, <flush>1.75%@+5] iv_offset=18\"
This failure is in one of the randomly generated test cases. If it doesn't
reproduce reliably, you can set cryptomgr.fuzz_iterations=1000 on the kernel
command line (increased from the default 100).
It is confusing that it says just "sha1". This seems to be a quirk specific to
how tcrypt calls alg_test(). It's probably really testing "sha1-sun4i-ss".
I guess that testmgr.c should be using the actual cra_driver_name in the log
messages, not the 'driver' string that was passed into alg_test().
- Eric
next prev parent reply other threads:[~2020-10-08 23:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 8:52 drivers/crypto/allwinner/sun4i-ss/sun4i-ss-hash.c:483:35: sparse: sparse: incorrect type in assignment (different base types) kernel test robot
2020-09-06 8:52 ` kernel test robot
2020-09-07 6:24 ` [PATCH] crypto: sun4i-ss - Fix SHA1 hash on A33-variant with BE CPU Herbert Xu
2020-09-07 6:24 ` Herbert Xu
2020-09-07 14:55 ` Corentin Labbe
2020-09-07 14:55 ` Corentin Labbe
2020-09-07 16:00 ` Corentin Labbe
2020-09-07 16:00 ` Corentin Labbe
2020-09-08 5:00 ` [v2 PATCH] crypto: sun4i-ss - Fix sparse endianness markers Herbert Xu
2020-09-08 5:00 ` Herbert Xu
2020-09-10 12:22 ` Corentin Labbe
2020-09-10 12:22 ` Corentin Labbe
2020-09-11 4:13 ` Herbert Xu
2020-09-11 4:13 ` Herbert Xu
2020-09-14 7:45 ` Corentin Labbe
2020-09-14 7:45 ` Corentin Labbe
2020-09-14 10:40 ` Corentin Labbe
2020-09-14 10:40 ` Corentin Labbe
2020-09-24 3:08 ` Herbert Xu
2020-09-24 3:08 ` Herbert Xu
2020-09-24 13:27 ` Corentin Labbe
2020-09-24 13:27 ` Corentin Labbe
2020-10-08 5:52 ` Herbert Xu
2020-10-08 5:52 ` Herbert Xu
2020-10-08 6:36 ` Corentin Labbe
2020-10-08 6:36 ` Corentin Labbe
2020-10-08 23:35 ` Eric Biggers [this message]
2020-10-08 23:35 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008233543.GD1869638@gmail.com \
--to=ebiggers@kernel.org \
--cc=clabbe.montjoie@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=kbuild-all@lists.01.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.