Re: [PATCH v4 seccomp 5/5] seccomp/cache: Report cache data through /proc/pid/seccomp_cache

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 12641 bytes --]

Hi YiFei,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20201009]
[cannot apply to tip/x86/core tip/master linux/master linus/master v5.9-rc8 v5.9-rc7 v5.9-rc6 v5.9-rc8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/YiFei-Zhu/seccomp-Add-bitmap-cache-of-constant-allow-filter-results/20201010-013933
base:    d67bc7812221606e1886620a357b13f906814af7
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/a1a1697444ceecfb62796ccd5ba42057c82bd295
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review YiFei-Zhu/seccomp-Add-bitmap-cache-of-constant-allow-filter-results/20201010-013933
        git checkout a1a1697444ceecfb62796ccd5ba42057c82bd295
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/sched.h:22,
                    from include/linux/ptrace.h:6,
                    from arch/xtensa/kernel/asm-offsets.c:21:
>> include/linux/seccomp.h:126:35: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
     126 | int proc_pid_seccomp_cache(struct seq_file *m, struct pid_namespace *ns,
         |                                   ^~~~~~~~
--
   In file included from include/linux/sched.h:22,
                    from include/linux/uaccess.h:8,
                    from fs/proc/base.c:51:
>> include/linux/seccomp.h:126:35: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
     126 | int proc_pid_seccomp_cache(struct seq_file *m, struct pid_namespace *ns,
         |                                   ^~~~~~~~
   fs/proc/base.c:3261:32: error: initialization of 'int (*)(struct seq_file *, struct pid_namespace *, struct pid *, struct task_struct *)' from incompatible pointer type 'int (*)(struct seq_file *, struct pid_namespace *, struct pid *, struct task_struct *)' [-Werror=incompatible-pointer-types]
    3261 |  ONE("seccomp_cache", S_IRUSR, proc_pid_seccomp_cache),
         |                                ^~~~~~~~~~~~~~~~~~~~~~
   fs/proc/base.c:133:10: note: in definition of macro 'NOD'
     133 |  .op   = OP,     \
         |          ^~
   fs/proc/base.c:3261:2: note: in expansion of macro 'ONE'
    3261 |  ONE("seccomp_cache", S_IRUSR, proc_pid_seccomp_cache),
         |  ^~~
   fs/proc/base.c:3261:32: note: (near initialization for 'tgid_base_stuff[51].op.proc_show')
    3261 |  ONE("seccomp_cache", S_IRUSR, proc_pid_seccomp_cache),
         |                                ^~~~~~~~~~~~~~~~~~~~~~
   fs/proc/base.c:133:10: note: in definition of macro 'NOD'
     133 |  .op   = OP,     \
         |          ^~
   fs/proc/base.c:3261:2: note: in expansion of macro 'ONE'
    3261 |  ONE("seccomp_cache", S_IRUSR, proc_pid_seccomp_cache),
         |  ^~~
   fs/proc/base.c:3593:32: error: initialization of 'int (*)(struct seq_file *, struct pid_namespace *, struct pid *, struct task_struct *)' from incompatible pointer type 'int (*)(struct seq_file *, struct pid_namespace *, struct pid *, struct task_struct *)' [-Werror=incompatible-pointer-types]
    3593 |  ONE("seccomp_cache", S_IRUSR, proc_pid_seccomp_cache),
         |                                ^~~~~~~~~~~~~~~~~~~~~~
   fs/proc/base.c:133:10: note: in definition of macro 'NOD'
     133 |  .op   = OP,     \
         |          ^~
   fs/proc/base.c:3593:2: note: in expansion of macro 'ONE'
    3593 |  ONE("seccomp_cache", S_IRUSR, proc_pid_seccomp_cache),
         |  ^~~
   fs/proc/base.c:3593:32: note: (near initialization for 'tid_base_stuff[45].op.proc_show')
    3593 |  ONE("seccomp_cache", S_IRUSR, proc_pid_seccomp_cache),
         |                                ^~~~~~~~~~~~~~~~~~~~~~
   fs/proc/base.c:133:10: note: in definition of macro 'NOD'
     133 |  .op   = OP,     \
         |          ^~
   fs/proc/base.c:3593:2: note: in expansion of macro 'ONE'
    3593 |  ONE("seccomp_cache", S_IRUSR, proc_pid_seccomp_cache),
         |  ^~~
   cc1: some warnings being treated as errors
--
   In file included from include/linux/sched.h:22,
                    from include/linux/blkdev.h:5,
                    from fs/hfsplus/inode.c:12:
>> include/linux/seccomp.h:126:35: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
     126 | int proc_pid_seccomp_cache(struct seq_file *m, struct pid_namespace *ns,
         |                                   ^~~~~~~~
   fs/hfsplus/inode.c: In function 'hfsplus_cat_read_inode':
   fs/hfsplus/inode.c:501:16: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
     501 |    /* panic? */;
         |                ^
   fs/hfsplus/inode.c:522:16: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
     522 |    /* panic? */;
         |                ^
   fs/hfsplus/inode.c: In function 'hfsplus_cat_write_inode':
   fs/hfsplus/inode.c:580:16: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
     580 |    /* panic? */;
         |                ^
   fs/hfsplus/inode.c:606:16: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
     606 |    /* panic? */;
         |                ^
--
   In file included from include/linux/sched.h:22,
                    from include/linux/mm.h:32,
                    from include/linux/pagemap.h:8,
                    from fs/hfs/inode.c:14:
>> include/linux/seccomp.h:126:35: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
     126 | int proc_pid_seccomp_cache(struct seq_file *m, struct pid_namespace *ns,
         |                                   ^~~~~~~~
   fs/hfs/inode.c: In function 'hfs_write_inode':
   fs/hfs/inode.c:464:16: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
     464 |    /* panic? */;
         |                ^
   fs/hfs/inode.c:485:16: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
     485 |    /* panic? */;
         |                ^
--
   In file included from include/linux/sched.h:22,
                    from include/linux/mm.h:32,
                    from include/linux/pagemap.h:8,
                    from fs/efs/symlink.c:11:
>> include/linux/seccomp.h:126:35: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
     126 | int proc_pid_seccomp_cache(struct seq_file *m, struct pid_namespace *ns,
         |                                   ^~~~~~~~
   In file included from fs/efs/symlink.c:13:
   fs/efs/efs.h:22:19: warning: 'cprt' defined but not used [-Wunused-const-variable=]
      22 | static const char cprt[] = "EFS: "EFS_VERSION" - (c) 1999 Al Smith <Al.Smith@aeschi.ch.eu.org>";
         |                   ^~~~
--
   In file included from include/linux/sched.h:22,
                    from fs/jffs2/nodelist.c:15:
>> include/linux/seccomp.h:126:35: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
     126 | int proc_pid_seccomp_cache(struct seq_file *m, struct pid_namespace *ns,
         |                                   ^~~~~~~~
   fs/jffs2/nodelist.c: In function 'jffs2_add_frag_to_fragtree':
   fs/jffs2/nodelist.c:255:37: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
     255 |   this->ofs, this->ofs + this->size);
         |                                     ^
   fs/jffs2/nodelist.c:278:38: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
     278 |      this->ofs, this->ofs+this->size);
         |                                      ^
   fs/jffs2/nodelist.c: In function 'jffs2_lookup_node_frag':
   fs/jffs2/nodelist.c:558:52: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
     558 |   dbg_fragtree2("returning NULL, empty fragtree\n");
         |                                                    ^
--
   In file included from include/linux/sched.h:22,
                    from include/linux/mm.h:32,
                    from include/linux/bvec.h:14,
                    from fs/orangefs/inode.c:13:
>> include/linux/seccomp.h:126:35: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
     126 | int proc_pid_seccomp_cache(struct seq_file *m, struct pid_namespace *ns,
         |                                   ^~~~~~~~
   In file included from fs/orangefs/protocol.h:287,
                    from fs/orangefs/inode.c:14:
   fs/orangefs/orangefs-debug.h:86:18: warning: 'num_kmod_keyword_mask_map' defined but not used [-Wunused-const-variable=]
      86 | static const int num_kmod_keyword_mask_map = (int)
         |                  ^~~~~~~~~~~~~~~~~~~~~~~~~
--
   In file included from include/linux/sched.h:22,
                    from fs/btrfs/extent-tree.c:6:
>> include/linux/seccomp.h:126:35: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
     126 | int proc_pid_seccomp_cache(struct seq_file *m, struct pid_namespace *ns,
         |                                   ^~~~~~~~
   In file included from include/linux/printk.h:7,
                    from include/linux/kernel.h:16,
                    from include/asm-generic/bug.h:20,
                    from ./arch/xtensa/include/generated/asm/bug.h:1,
                    from include/linux/bug.h:5,
                    from include/linux/thread_info.h:12,
                    from arch/xtensa/include/asm/current.h:18,
                    from include/linux/sched.h:12,
                    from fs/btrfs/extent-tree.c:6:
   fs/btrfs/extent-tree.c: In function '__btrfs_free_extent':
   include/linux/kern_levels.h:5:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 8 has type 'unsigned int' [-Wformat=]
       5 | #define KERN_SOH "\001"  /* ASCII Start Of Header */
         |                  ^~~~~~
   include/linux/kern_levels.h:10:19: note: in expansion of macro 'KERN_SOH'
      10 | #define KERN_CRIT KERN_SOH "2" /* critical conditions */
         |                   ^~~~~~~~
   fs/btrfs/ctree.h:3148:24: note: in expansion of macro 'KERN_CRIT'
    3148 |  btrfs_printk(fs_info, KERN_CRIT fmt, ##args)
         |                        ^~~~~~~~~
   fs/btrfs/extent-tree.c:3187:4: note: in expansion of macro 'btrfs_crit'
    3187 |    btrfs_crit(info,
         |    ^~~~~~~~~~
   fs/btrfs/extent-tree.c:3188:83: note: format string is defined here
    3188 | "invalid extent item size for key (%llu, %u, %llu) owner %llu, has %u expect >= %lu",
         |                                                                                 ~~^
         |                                                                                   |
         |                                                                                   long unsigned int
         |                                                                                 %u
--
   In file included from include/linux/sched.h:22,
                    from include/linux/ptrace.h:6,
                    from arch/xtensa/kernel/asm-offsets.c:21:
>> include/linux/seccomp.h:126:35: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
     126 | int proc_pid_seccomp_cache(struct seq_file *m, struct pid_namespace *ns,
         |                                   ^~~~~~~~

vim +126 include/linux/seccomp.h

   124	
   125	#ifdef CONFIG_SECCOMP_CACHE_DEBUG
 > 126	int proc_pid_seccomp_cache(struct seq_file *m, struct pid_namespace *ns,

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 66114 bytes --]

[-- Attachment #3: Type: text/plain, Size: 171 bytes --]

_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/containers