From: Stephen Hemminger <stephen@networkplumber.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Linux USB Mailing List" <linux-usb@vger.kernel.org>,
"Steffen Klassert" <steffen.klassert@secunet.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Sergey Matyukevich" <geomatsi@gmail.com>,
linux-rdma@vger.kernel.org, bridge@lists.linux-foundation.org,
"Pravin B Shelar" <pshelar@ovn.org>,
"Nikolay Aleksandrov" <nikolay@nvidia.com>,
"Roopa Prabhu" <roopa@nvidia.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Igor Mitsyanko" <imitsyanko@quantenna.com>,
"Alexey Kuznetsov" <kuznet@ms2.inr.ac.ru>,
"Kalle Valo" <kvalo@codeaurora.org>,
"Hideaki YOSHIFUJI" <yoshfuji@linux-ipv6.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Oliver Neukum" <oneukum@suse.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David Miller" <davem@davemloft.net>,
"Bjørn Mork" <bjorn@mork.no>
Subject: Re: [Bridge] [PATCH net-next 01/12] net: core: add function dev_fetch_sw_netstats for fetching pcpu_sw_netstats
Date: Sun, 11 Oct 2020 12:54:12 -0700 [thread overview]
Message-ID: <20201011125412.3719926a@hermes.local> (raw)
In-Reply-To: <5bb71143-0dac-c413-7e97-50eed8a57862@gmail.com>
On Sun, 11 Oct 2020 21:36:43 +0200
Heiner Kallweit <hkallweit1@gmail.com> wrote:
> +void dev_fetch_sw_netstats(struct rtnl_link_stats64 *s,
> + struct pcpu_sw_netstats __percpu *netstats)
netstats is unmodified, should it be const?
> +{
> + int cpu;
> +
> + if (IS_ERR_OR_NULL(netstats))
> + return;
Any code calling this with a null pointer is broken/buggy, please don't
ignore that.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: "David Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>, "Bjørn Mork" <bjorn@mork.no>,
"Oliver Neukum" <oneukum@suse.com>,
"Igor Mitsyanko" <imitsyanko@quantenna.com>,
"Sergey Matyukevich" <geomatsi@gmail.com>,
"Kalle Valo" <kvalo@codeaurora.org>,
"Roopa Prabhu" <roopa@nvidia.com>,
"Nikolay Aleksandrov" <nikolay@nvidia.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"Alexey Kuznetsov" <kuznet@ms2.inr.ac.ru>,
"Hideaki YOSHIFUJI" <yoshfuji@linux-ipv6.org>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Pravin B Shelar" <pshelar@ovn.org>,
"Steffen Klassert" <steffen.klassert@secunet.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
linux-rdma@vger.kernel.org,
"Linux USB Mailing List" <linux-usb@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
bridge@lists.linux-foundation.org
Subject: Re: [PATCH net-next 01/12] net: core: add function dev_fetch_sw_netstats for fetching pcpu_sw_netstats
Date: Sun, 11 Oct 2020 12:54:12 -0700 [thread overview]
Message-ID: <20201011125412.3719926a@hermes.local> (raw)
In-Reply-To: <5bb71143-0dac-c413-7e97-50eed8a57862@gmail.com>
On Sun, 11 Oct 2020 21:36:43 +0200
Heiner Kallweit <hkallweit1@gmail.com> wrote:
> +void dev_fetch_sw_netstats(struct rtnl_link_stats64 *s,
> + struct pcpu_sw_netstats __percpu *netstats)
netstats is unmodified, should it be const?
> +{
> + int cpu;
> +
> + if (IS_ERR_OR_NULL(netstats))
> + return;
Any code calling this with a null pointer is broken/buggy, please don't
ignore that.
next prev parent reply other threads:[~2020-10-11 19:54 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 19:34 [Bridge] [PATCH net-next 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Heiner Kallweit
2020-10-11 19:34 ` Heiner Kallweit
2020-10-11 19:36 ` [Bridge] [PATCH net-next 01/12] net: core: add " Heiner Kallweit
2020-10-11 19:36 ` Heiner Kallweit
2020-10-11 19:54 ` Stephen Hemminger [this message]
2020-10-11 19:54 ` Stephen Hemminger
2020-10-11 20:18 ` [Bridge] " Heiner Kallweit
2020-10-11 20:18 ` Heiner Kallweit
2020-10-11 22:07 ` [Bridge] " Jakub Kicinski
2020-10-11 22:07 ` Jakub Kicinski
2020-10-11 19:37 ` [Bridge] [PATCH net-next 02/12] IB/hfi1: use new function dev_fetch_sw_netstats Heiner Kallweit
2020-10-11 19:37 ` Heiner Kallweit
2020-10-11 19:38 ` [Bridge] [PATCH net-next 03/12] net: macsec: " Heiner Kallweit
2020-10-11 19:38 ` Heiner Kallweit
2020-10-11 19:38 ` [Bridge] [PATCH net-next 04/12] net: usb: qmi_wwan: " Heiner Kallweit
2020-10-11 19:38 ` Heiner Kallweit
2020-10-12 6:47 ` [Bridge] " Bjørn Mork
2020-10-12 6:47 ` Bjørn Mork
2020-10-11 19:39 ` [Bridge] [PATCH net-next 05/12] net: usbnet: " Heiner Kallweit
2020-10-11 19:39 ` Heiner Kallweit
2020-10-11 19:40 ` [Bridge] [PATCH net-next 06/12] qtnfmac: " Heiner Kallweit
2020-10-11 19:40 ` Heiner Kallweit
2020-10-12 7:10 ` [Bridge] " Kalle Valo
2020-10-12 7:10 ` Kalle Valo
2020-10-11 19:40 ` [Bridge] [PATCH net-next 07/12] net: bridge: " Heiner Kallweit
2020-10-11 19:40 ` Heiner Kallweit
2020-10-11 19:41 ` [Bridge] [PATCH net-next 08/12] net: dsa: " Heiner Kallweit
2020-10-11 19:41 ` Heiner Kallweit
2020-10-11 20:15 ` [Bridge] " Vladimir Oltean
2020-10-11 20:15 ` Vladimir Oltean
2020-10-12 1:49 ` [Bridge] " Florian Fainelli
2020-10-12 1:49 ` Florian Fainelli
2020-10-11 19:42 ` [Bridge] [PATCH net-next 09/12] iptunnel: " Heiner Kallweit
2020-10-11 19:42 ` Heiner Kallweit
2020-10-11 19:42 ` [Bridge] [PATCH net-next 10/12] mac80211: " Heiner Kallweit
2020-10-11 19:42 ` Heiner Kallweit
2020-10-11 19:43 ` [Bridge] [PATCH net-next 11/12] net: openvswitch: " Heiner Kallweit
2020-10-11 19:43 ` Heiner Kallweit
2020-10-11 19:44 ` [Bridge] [PATCH net-next 12/12] xfrm: " Heiner Kallweit
2020-10-11 19:44 ` Heiner Kallweit
2020-10-11 22:10 ` [Bridge] [PATCH net-next 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Jakub Kicinski
2020-10-11 22:10 ` Jakub Kicinski
2020-10-11 22:29 ` [Bridge] " Heiner Kallweit
2020-10-11 22:29 ` Heiner Kallweit
2020-10-11 22:41 ` [Bridge] " Jakub Kicinski
2020-10-11 22:41 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201011125412.3719926a@hermes.local \
--to=stephen@networkplumber.org \
--cc=andrew@lunn.ch \
--cc=bjorn@mork.no \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=geomatsi@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=hkallweit1@gmail.com \
--cc=imitsyanko@quantenna.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=kvalo@codeaurora.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=olteanv@gmail.com \
--cc=oneukum@suse.com \
--cc=pshelar@ovn.org \
--cc=roopa@nvidia.com \
--cc=steffen.klassert@secunet.com \
--cc=vivien.didelot@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.