* [ti:ti-linux-5.4.y 1/1] net/hsr/hsr_forward.c:244:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute
@ 2020-10-10 7:07 kernel test robot
2020-10-12 11:42 ` Dan Murphy
0 siblings, 1 reply; 6+ messages in thread
From: kernel test robot @ 2020-10-10 7:07 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 4356 bytes --]
tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-linux-5.4.y
head: f85baf8e2e6374594eb76d4c14ada9d62a2fa98b
commit: f85baf8e2e6374594eb76d4c14ada9d62a2fa98b [1/1] Merge tag 'v5.4.69' of http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable into ti-linux-5.4.y
config: x86_64-randconfig-a005-20201010 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 9b5b3050237db3642ed7ab1bdb3ffa2202511b99)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git remote add ti git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git
git fetch --no-tags ti ti-linux-5.4.y
git checkout f85baf8e2e6374594eb76d4c14ada9d62a2fa98b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> net/hsr/hsr_forward.c:244:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
skb_put_padto(skb, VLAN_ETH_ZLEN);
^~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~
net/hsr/hsr_forward.c:246:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
skb_put_padto(skb, ETH_ZLEN);
^~~~~~~~~~~~~ ~~~~~~~~~~~~~
net/hsr/hsr_forward.c:279:2: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
skb_put_padto(skb, ETH_ZLEN + HSR_HLEN);
^~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~
3 warnings generated.
vim +/warn_unused_result +244 net/hsr/hsr_forward.c
cec32b3c120970 Murali Karicheri 2020-06-02 232
cec32b3c120970 Murali Karicheri 2020-06-02 233 /* Tailroom for PRP rct should have been created before calling this */
cec32b3c120970 Murali Karicheri 2020-06-02 234 static void prp_fill_rct(struct sk_buff *skb, struct hsr_frame_info *frame,
cec32b3c120970 Murali Karicheri 2020-06-02 235 struct hsr_port *port)
cec32b3c120970 Murali Karicheri 2020-06-02 236 {
cec32b3c120970 Murali Karicheri 2020-06-02 237 struct prp_rct *trailer;
cec32b3c120970 Murali Karicheri 2020-06-02 238 int lsdu_size;
cec32b3c120970 Murali Karicheri 2020-06-02 239
cec32b3c120970 Murali Karicheri 2020-06-02 240 if (!skb)
cec32b3c120970 Murali Karicheri 2020-06-02 241 return;
cec32b3c120970 Murali Karicheri 2020-06-02 242
cec32b3c120970 Murali Karicheri 2020-06-02 243 if (frame->is_vlan)
cec32b3c120970 Murali Karicheri 2020-06-02 @244 skb_put_padto(skb, VLAN_ETH_ZLEN);
cec32b3c120970 Murali Karicheri 2020-06-02 245 else
cec32b3c120970 Murali Karicheri 2020-06-02 246 skb_put_padto(skb, ETH_ZLEN);
cec32b3c120970 Murali Karicheri 2020-06-02 247
cec32b3c120970 Murali Karicheri 2020-06-02 248 trailer = (struct prp_rct *)skb_put(skb, HSR_HLEN);
cec32b3c120970 Murali Karicheri 2020-06-02 249 lsdu_size = skb->len - 14;
cec32b3c120970 Murali Karicheri 2020-06-02 250 if (frame->is_vlan)
cec32b3c120970 Murali Karicheri 2020-06-02 251 lsdu_size -= 4;
cec32b3c120970 Murali Karicheri 2020-06-02 252 prp_set_lan_id(trailer, port);
cec32b3c120970 Murali Karicheri 2020-06-02 253 set_prp_LSDU_size(trailer, lsdu_size);
cec32b3c120970 Murali Karicheri 2020-06-02 254 trailer->sequence_nr = htons(frame->sequence_nr);
cec32b3c120970 Murali Karicheri 2020-06-02 255 trailer->PRP_suffix = htons(ETH_P_PRP);
cec32b3c120970 Murali Karicheri 2020-06-02 256 }
cec32b3c120970 Murali Karicheri 2020-06-02 257
:::::: The code at line 244 was first introduced by commit
:::::: cec32b3c120970149886c47f9e5b7e09c73ba020 net: prp: add packet handling support
:::::: TO: Murali Karicheri <m-karicheri2@ti.com>
:::::: CC: Murali Karicheri <m-karicheri2@ti.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28625 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [ti:ti-linux-5.4.y 1/1] net/hsr/hsr_forward.c:244:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute
2020-10-10 7:07 [ti:ti-linux-5.4.y 1/1] net/hsr/hsr_forward.c:244:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute kernel test robot
@ 2020-10-12 11:42 ` Dan Murphy
2020-10-12 12:08 ` Philip Li
0 siblings, 1 reply; 6+ messages in thread
From: Dan Murphy @ 2020-10-12 11:42 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 320 bytes --]
Hello robot
On 10/10/20 2:07 AM, kernel test robot wrote:
> tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-linux-5.4.y
Why is this TI tree being reported to the open source community? They
have no interest in our product tree unless this same bug is in the
mainline or Linux stable
Dan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ti:ti-linux-5.4.y 1/1] net/hsr/hsr_forward.c:244:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute
2020-10-12 11:42 ` Dan Murphy
@ 2020-10-12 12:08 ` Philip Li
2020-10-12 12:12 ` Philip Li
0 siblings, 1 reply; 6+ messages in thread
From: Philip Li @ 2020-10-12 12:08 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 699 bytes --]
On Mon, Oct 12, 2020 at 06:42:21AM -0500, Dan Murphy wrote:
> Hello robot
>
> On 10/10/20 2:07 AM, kernel test robot wrote:
> > tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-linux-5.4.y
>
> Why is this TI tree being reported to the open source community? They have
hi Dan, thanks for the info, this is added automatically, we will
disable the test of this repo. Sorry for any confusion.
> no interest in our product tree unless this same bug is in the mainline or
> Linux stable
>
> Dan
>
> _______________________________________________
> kbuild-all mailing list -- kbuild-all(a)lists.01.org
> To unsubscribe send an email to kbuild-all-leave(a)lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ti:ti-linux-5.4.y 1/1] net/hsr/hsr_forward.c:244:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute
2020-10-12 12:08 ` Philip Li
@ 2020-10-12 12:12 ` Philip Li
2020-10-12 12:17 ` Dan Murphy
0 siblings, 1 reply; 6+ messages in thread
From: Philip Li @ 2020-10-12 12:12 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1114 bytes --]
On Mon, Oct 12, 2020 at 08:08:18PM +0800, Philip Li wrote:
> On Mon, Oct 12, 2020 at 06:42:21AM -0500, Dan Murphy wrote:
> > Hello robot
> >
> > On 10/10/20 2:07 AM, kernel test robot wrote:
> > > tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-linux-5.4.y
> >
> > Why is this TI tree being reported to the open source community? They have
> hi Dan, thanks for the info, this is added automatically, we will
> disable the test of this repo. Sorry for any confusion.
oops, I understand the question wrongly. We will keep testing this repo.
The problem here is it is a clang build, and we currently cc clang mailing list
in case there's doublt that this may be a clang prolem instead of kernel. It
is not specially to whole opoen source community. Is this ok with you?
Thanks
>
> > no interest in our product tree unless this same bug is in the mainline or
> > Linux stable
> >
> > Dan
> >
> > _______________________________________________
> > kbuild-all mailing list -- kbuild-all(a)lists.01.org
> > To unsubscribe send an email to kbuild-all-leave(a)lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ti:ti-linux-5.4.y 1/1] net/hsr/hsr_forward.c:244:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute
2020-10-12 12:12 ` Philip Li
@ 2020-10-12 12:17 ` Dan Murphy
2020-10-12 12:18 ` Philip Li
0 siblings, 1 reply; 6+ messages in thread
From: Dan Murphy @ 2020-10-12 12:17 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1143 bytes --]
Philip
On 10/12/20 7:12 AM, Philip Li wrote:
> On Mon, Oct 12, 2020 at 08:08:18PM +0800, Philip Li wrote:
>> On Mon, Oct 12, 2020 at 06:42:21AM -0500, Dan Murphy wrote:
>>> Hello robot
>>>
>>> On 10/10/20 2:07 AM, kernel test robot wrote:
>>>> tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-linux-5.4.y
>>> Why is this TI tree being reported to the open source community? They have
>> hi Dan, thanks for the info, this is added automatically, we will
>> disable the test of this repo. Sorry for any confusion.
> oops, I understand the question wrongly. We will keep testing this repo.
> The problem here is it is a clang build, and we currently cc clang mailing list
> in case there's doublt that this may be a clang prolem instead of kernel. It
> is not specially to whole opoen source community. Is this ok with you?
It is fine to keep testing the repo but the error reporting should go to
TI not GKH. I am fairly certain he does not care about our tree.
Not sure if there is intelligence in the bot to direct bug reports to
specific companies or individuals when testing SoC product trees
Dan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ti:ti-linux-5.4.y 1/1] net/hsr/hsr_forward.c:244:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute
2020-10-12 12:17 ` Dan Murphy
@ 2020-10-12 12:18 ` Philip Li
0 siblings, 0 replies; 6+ messages in thread
From: Philip Li @ 2020-10-12 12:18 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1515 bytes --]
On Mon, Oct 12, 2020 at 07:17:52AM -0500, Dan Murphy wrote:
> Philip
>
> On 10/12/20 7:12 AM, Philip Li wrote:
> > On Mon, Oct 12, 2020 at 08:08:18PM +0800, Philip Li wrote:
> > > On Mon, Oct 12, 2020 at 06:42:21AM -0500, Dan Murphy wrote:
> > > > Hello robot
> > > >
> > > > On 10/10/20 2:07 AM, kernel test robot wrote:
> > > > > tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-linux-5.4.y
> > > > Why is this TI tree being reported to the open source community? They have
> > > hi Dan, thanks for the info, this is added automatically, we will
> > > disable the test of this repo. Sorry for any confusion.
> > oops, I understand the question wrongly. We will keep testing this repo.
> > The problem here is it is a clang build, and we currently cc clang mailing list
> > in case there's doublt that this may be a clang prolem instead of kernel. It
> > is not specially to whole opoen source community. Is this ok with you?
>
> It is fine to keep testing the repo but the error reporting should go to TI
> not GKH. I am fairly certain he does not care about our tree.
yes, you are right, for this case, we should not send mail to GKH.
>
> Not sure if there is intelligence in the bot to direct bug reports to
> specific companies or individuals when testing SoC product trees
Currently, we can do some static configuration per different needs.
Do you have any mailing list that you want to send report to/cc for this ti
repo? Or just send to you?
>
> Dan
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-10-12 12:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-10 7:07 [ti:ti-linux-5.4.y 1/1] net/hsr/hsr_forward.c:244:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute kernel test robot
2020-10-12 11:42 ` Dan Murphy
2020-10-12 12:08 ` Philip Li
2020-10-12 12:12 ` Philip Li
2020-10-12 12:17 ` Dan Murphy
2020-10-12 12:18 ` Philip Li
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.