From: Krzysztof Kozlowski <krzk@kernel.org>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: daniel.baluta@nxp.com, peter.chen@nxp.com, abel.vesa@nxp.com,
devicetree@vger.kernel.org, festevam@gmail.com,
s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
Linux-imx@nxp.com, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
l.stach@pengutronix.de, shawnguo@kernel.org, yibin.gong@nxp.com,
aford173@gmail.com, shengjiu.wang@nxp.com, alifer.wsdm@gmail.com,
jun.li@nxp.com
Subject: Re: [PATCH V2 3/3] arm64: dts: imx8mp-evk: Correct WDOG_B pin configuration
Date: Mon, 12 Oct 2020 15:05:34 +0200 [thread overview]
Message-ID: <20201012130534.GC6468@kozik-lap> (raw)
In-Reply-To: <1602506642-5262-3-git-send-email-Anson.Huang@nxp.com>
On Mon, Oct 12, 2020 at 08:44:02PM +0800, Anson Huang wrote:
> Different revision of i.MX8MP EVK boards may have different external
> pull up registor design, some are enabled while some are NOT, to make
> sure the WDOG_B pin works properly, better to enable internal pull up
> resistor. Since enabling internal pull up resistor is NOT harmful and
> having benefit of flexibility on different board design, just enable
> it for all i.MX8MP boards; And schmitt input is NOT necessary for this
> WDOG_B output pin, so remove it; Open drain outputs provide more
> flexibility to a designer as they can be pulled-up to any voltage found
> in the system, so enable it as well.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> Changes since V1:
> - Provide more explanation of removing schmitt input and enabling open drain in commit msg.
> ---
> arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, aford173@gmail.com,
daniel.baluta@nxp.com, shengjiu.wang@nxp.com, peter.chen@nxp.com,
alifer.wsdm@gmail.com, abel.vesa@nxp.com, yibin.gong@nxp.com,
jun.li@nxp.com, l.stach@pengutronix.de,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Linux-imx@nxp.com
Subject: Re: [PATCH V2 3/3] arm64: dts: imx8mp-evk: Correct WDOG_B pin configuration
Date: Mon, 12 Oct 2020 15:05:34 +0200 [thread overview]
Message-ID: <20201012130534.GC6468@kozik-lap> (raw)
In-Reply-To: <1602506642-5262-3-git-send-email-Anson.Huang@nxp.com>
On Mon, Oct 12, 2020 at 08:44:02PM +0800, Anson Huang wrote:
> Different revision of i.MX8MP EVK boards may have different external
> pull up registor design, some are enabled while some are NOT, to make
> sure the WDOG_B pin works properly, better to enable internal pull up
> resistor. Since enabling internal pull up resistor is NOT harmful and
> having benefit of flexibility on different board design, just enable
> it for all i.MX8MP boards; And schmitt input is NOT necessary for this
> WDOG_B output pin, so remove it; Open drain outputs provide more
> flexibility to a designer as they can be pulled-up to any voltage found
> in the system, so enable it as well.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> Changes since V1:
> - Provide more explanation of removing schmitt input and enabling open drain in commit msg.
> ---
> arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-10-12 13:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 12:44 [PATCH V2 1/3] arm64: dts: imx8mm: Correct WDOG_B pin configuration Anson Huang
2020-10-12 12:44 ` Anson Huang
2020-10-12 12:44 ` [PATCH V2 2/3] arm64: dts: imx8mn: " Anson Huang
2020-10-12 12:44 ` Anson Huang
2020-10-12 13:05 ` Krzysztof Kozlowski
2020-10-12 13:05 ` Krzysztof Kozlowski
2020-10-12 12:44 ` [PATCH V2 3/3] arm64: dts: imx8mp-evk: " Anson Huang
2020-10-12 12:44 ` Anson Huang
2020-10-12 13:05 ` Krzysztof Kozlowski [this message]
2020-10-12 13:05 ` Krzysztof Kozlowski
2020-10-12 13:04 ` [PATCH V2 1/3] arm64: dts: imx8mm: " Krzysztof Kozlowski
2020-10-12 13:04 ` Krzysztof Kozlowski
2020-10-30 10:34 ` Shawn Guo
2020-10-30 10:34 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012130534.GC6468@kozik-lap \
--to=krzk@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=aford173@gmail.com \
--cc=alifer.wsdm@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.chen@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.