From: Krzysztof Kozlowski <krzk@kernel.org>
To: Adam Ford <aford173@gmail.com>
Cc: devicetree@vger.kernel.org, Will Deacon <will@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
aford@beaconembedded.com, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] arm64: dts: imx8mm: Add node for SPDIF
Date: Mon, 12 Oct 2020 19:00:16 +0200 [thread overview]
Message-ID: <20201012170016.GA5369@kozik-lap> (raw)
In-Reply-To: <20201008212706.870115-2-aford173@gmail.com>
On Thu, Oct 08, 2020 at 04:27:05PM -0500, Adam Ford wrote:
> The i.MX8M Mini can support SPIDF which is very similar to the
SPIDF -> SPDIF
> IP used on the i.MX35.
>
> This patch adds the SPIF node.
Just "Add the SPDIF node", avoid "this patch". And SPIF->SPDIF.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index fad1f9cdb241..44a59f59f65a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -358,6 +358,30 @@ micfil: audio-controller@30080000 {
> status = "disabled";
> };
>
> + spdif1: spdif@30090000 {
> + compatible = "fsl,imx8mm-spdif", "fsl,imx35-spdif";
This does not pass the dtschema validation, so only "fsl,imx35-spdif".
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Adam Ford <aford173@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, aford@beaconembedded.com,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: imx8mm: Add node for SPDIF
Date: Mon, 12 Oct 2020 19:00:16 +0200 [thread overview]
Message-ID: <20201012170016.GA5369@kozik-lap> (raw)
In-Reply-To: <20201008212706.870115-2-aford173@gmail.com>
On Thu, Oct 08, 2020 at 04:27:05PM -0500, Adam Ford wrote:
> The i.MX8M Mini can support SPIDF which is very similar to the
SPIDF -> SPDIF
> IP used on the i.MX35.
>
> This patch adds the SPIF node.
Just "Add the SPDIF node", avoid "this patch". And SPIF->SPDIF.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index fad1f9cdb241..44a59f59f65a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -358,6 +358,30 @@ micfil: audio-controller@30080000 {
> status = "disabled";
> };
>
> + spdif1: spdif@30090000 {
> + compatible = "fsl,imx8mm-spdif", "fsl,imx35-spdif";
This does not pass the dtschema validation, so only "fsl,imx35-spdif".
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-10-12 17:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 21:27 [PATCH 1/3] arm64: dts: imx8mm: Add support for micfil Adam Ford
2020-10-08 21:27 ` Adam Ford
2020-10-08 21:27 ` [PATCH 2/3] arm64: dts: imx8mm: Add node for SPDIF Adam Ford
2020-10-08 21:27 ` Adam Ford
2020-10-12 17:00 ` Krzysztof Kozlowski [this message]
2020-10-12 17:00 ` Krzysztof Kozlowski
2020-10-19 16:55 ` Fabio Estevam
2020-10-19 16:55 ` Fabio Estevam
2020-10-19 17:06 ` Krzysztof Kozlowski
2020-10-19 17:06 ` Krzysztof Kozlowski
2020-10-08 21:27 ` [PATCH 3/3] arm64: defconfig: Enable additional sound drivers on i.MX8M Mini Adam Ford
2020-10-08 21:27 ` Adam Ford
2020-10-19 17:51 ` Krzysztof Kozlowski
2020-10-19 17:51 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012170016.GA5369@kozik-lap \
--to=krzk@kernel.org \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.