All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bilal Wasim <bilalwasim676@gmail.com>
To: Jitao Shi <jitao.shi@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, bibby.hsieh@mediatek.com,
	srv_heupstream@mediatek.com, David Airlie <airlied@linux.ie>,
	huijuan.xie@mediatek.com, stonea168@163.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	cawa.cheng@mediatek.com, ck.hu@mediatek.com,
	Rob Herring <robh+dt@kernel.org>,
	linux-mediatek@lists.infradead.org,
	Daniel Vetter <daniel@ffwll.ch>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	yingjoe.chen@mediatek.com, eddie.huang@mediatek.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/2] Revert "drm/mediatek: dsi: Fix scrolling of panel with small hfp or hbp"
Date: Mon, 12 Oct 2020 17:07:30 +0500	[thread overview]
Message-ID: <20201012170730.582d4b96@a-VirtualBox> (raw)
In-Reply-To: <20201010070910.11294-2-jitao.shi@mediatek.com>

Hi Jitao,

On Sat, 10 Oct 2020 15:09:09 +0800
Jitao Shi <jitao.shi@mediatek.com> wrote:

> This reverts commit 35bf948f1edbf507f6e57e0879fa6ea36d2d2930.
> 
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dsi.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c
> b/drivers/gpu/drm/mediatek/mtk_dsi.c index 80b7a082e874..16fd99dcdacf
> 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -466,13 +466,14 @@ static void mtk_dsi_config_vdo_timing(struct
> mtk_dsi *dsi) horizontal_sync_active_byte = (vm->hsync_len *
> dsi_tmp_buf_bpp - 10); 
>  	if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE)
> -		horizontal_backporch_byte = vm->hback_porch *
> dsi_tmp_buf_bpp;
> +		horizontal_backporch_byte =
> +			(vm->hback_porch * dsi_tmp_buf_bpp - 10);
>  	else
> -		horizontal_backporch_byte = (vm->hback_porch +
> vm->hsync_len) *
> -					    dsi_tmp_buf_bpp;
> +		horizontal_backporch_byte = ((vm->hback_porch +
> vm->hsync_len) *
> +			dsi_tmp_buf_bpp - 10);
>  
>  	data_phy_cycles = timing->lpx + timing->da_hs_prepare +
> -			  timing->da_hs_zero + timing->da_hs_exit;
> +			  timing->da_hs_zero + timing->da_hs_exit +
> 3; 
>  	if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) {
>  		if ((vm->hfront_porch + vm->hback_porch) *
> dsi_tmp_buf_bpp >

Reviewed-by: Bilal Wasim <bilal.wasim@imgtec.com>
Tested-by: Bilal Wasim <bilal.wasim@imgtec.com>

Thanks,
Bilal

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Bilal Wasim <bilalwasim676@gmail.com>
To: Jitao Shi <jitao.shi@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, bibby.hsieh@mediatek.com,
	srv_heupstream@mediatek.com, David Airlie <airlied@linux.ie>,
	huijuan.xie@mediatek.com, stonea168@163.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	cawa.cheng@mediatek.com, ck.hu@mediatek.com,
	Rob Herring <robh+dt@kernel.org>,
	linux-mediatek@lists.infradead.org,
	Daniel Vetter <daniel@ffwll.ch>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	yingjoe.chen@mediatek.com, eddie.huang@mediatek.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/2] Revert "drm/mediatek: dsi: Fix scrolling of panel with small hfp or hbp"
Date: Mon, 12 Oct 2020 17:07:30 +0500	[thread overview]
Message-ID: <20201012170730.582d4b96@a-VirtualBox> (raw)
In-Reply-To: <20201010070910.11294-2-jitao.shi@mediatek.com>

Hi Jitao,

On Sat, 10 Oct 2020 15:09:09 +0800
Jitao Shi <jitao.shi@mediatek.com> wrote:

> This reverts commit 35bf948f1edbf507f6e57e0879fa6ea36d2d2930.
> 
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dsi.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c
> b/drivers/gpu/drm/mediatek/mtk_dsi.c index 80b7a082e874..16fd99dcdacf
> 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -466,13 +466,14 @@ static void mtk_dsi_config_vdo_timing(struct
> mtk_dsi *dsi) horizontal_sync_active_byte = (vm->hsync_len *
> dsi_tmp_buf_bpp - 10); 
>  	if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE)
> -		horizontal_backporch_byte = vm->hback_porch *
> dsi_tmp_buf_bpp;
> +		horizontal_backporch_byte =
> +			(vm->hback_porch * dsi_tmp_buf_bpp - 10);
>  	else
> -		horizontal_backporch_byte = (vm->hback_porch +
> vm->hsync_len) *
> -					    dsi_tmp_buf_bpp;
> +		horizontal_backporch_byte = ((vm->hback_porch +
> vm->hsync_len) *
> +			dsi_tmp_buf_bpp - 10);
>  
>  	data_phy_cycles = timing->lpx + timing->da_hs_prepare +
> -			  timing->da_hs_zero + timing->da_hs_exit;
> +			  timing->da_hs_zero + timing->da_hs_exit +
> 3; 
>  	if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) {
>  		if ((vm->hfront_porch + vm->hback_porch) *
> dsi_tmp_buf_bpp >

Reviewed-by: Bilal Wasim <bilal.wasim@imgtec.com>
Tested-by: Bilal Wasim <bilal.wasim@imgtec.com>

Thanks,
Bilal

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Bilal Wasim <bilalwasim676@gmail.com>
To: Jitao Shi <jitao.shi@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
	huijuan.xie@mediatek.com, stonea168@163.com,
	cawa.cheng@mediatek.com, linux-mediatek@lists.infradead.org,
	bibby.hsieh@mediatek.com, ck.hu@mediatek.com,
	yingjoe.chen@mediatek.com, eddie.huang@mediatek.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/2] Revert "drm/mediatek: dsi: Fix scrolling of panel with small hfp or hbp"
Date: Mon, 12 Oct 2020 17:07:30 +0500	[thread overview]
Message-ID: <20201012170730.582d4b96@a-VirtualBox> (raw)
In-Reply-To: <20201010070910.11294-2-jitao.shi@mediatek.com>

Hi Jitao,

On Sat, 10 Oct 2020 15:09:09 +0800
Jitao Shi <jitao.shi@mediatek.com> wrote:

> This reverts commit 35bf948f1edbf507f6e57e0879fa6ea36d2d2930.
> 
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dsi.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c
> b/drivers/gpu/drm/mediatek/mtk_dsi.c index 80b7a082e874..16fd99dcdacf
> 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -466,13 +466,14 @@ static void mtk_dsi_config_vdo_timing(struct
> mtk_dsi *dsi) horizontal_sync_active_byte = (vm->hsync_len *
> dsi_tmp_buf_bpp - 10); 
>  	if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE)
> -		horizontal_backporch_byte = vm->hback_porch *
> dsi_tmp_buf_bpp;
> +		horizontal_backporch_byte =
> +			(vm->hback_porch * dsi_tmp_buf_bpp - 10);
>  	else
> -		horizontal_backporch_byte = (vm->hback_porch +
> vm->hsync_len) *
> -					    dsi_tmp_buf_bpp;
> +		horizontal_backporch_byte = ((vm->hback_porch +
> vm->hsync_len) *
> +			dsi_tmp_buf_bpp - 10);
>  
>  	data_phy_cycles = timing->lpx + timing->da_hs_prepare +
> -			  timing->da_hs_zero + timing->da_hs_exit;
> +			  timing->da_hs_zero + timing->da_hs_exit +
> 3; 
>  	if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) {
>  		if ((vm->hfront_porch + vm->hback_porch) *
> dsi_tmp_buf_bpp >

Reviewed-by: Bilal Wasim <bilal.wasim@imgtec.com>
Tested-by: Bilal Wasim <bilal.wasim@imgtec.com>

Thanks,
Bilal

WARNING: multiple messages have this Message-ID (diff)
From: Bilal Wasim <bilalwasim676@gmail.com>
To: Jitao Shi <jitao.shi@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
	David Airlie <airlied@linux.ie>,
	huijuan.xie@mediatek.com, stonea168@163.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	cawa.cheng@mediatek.com, Rob Herring <robh+dt@kernel.org>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	yingjoe.chen@mediatek.com, eddie.huang@mediatek.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/2] Revert "drm/mediatek: dsi: Fix scrolling of panel with small hfp or hbp"
Date: Mon, 12 Oct 2020 17:07:30 +0500	[thread overview]
Message-ID: <20201012170730.582d4b96@a-VirtualBox> (raw)
In-Reply-To: <20201010070910.11294-2-jitao.shi@mediatek.com>

Hi Jitao,

On Sat, 10 Oct 2020 15:09:09 +0800
Jitao Shi <jitao.shi@mediatek.com> wrote:

> This reverts commit 35bf948f1edbf507f6e57e0879fa6ea36d2d2930.
> 
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dsi.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c
> b/drivers/gpu/drm/mediatek/mtk_dsi.c index 80b7a082e874..16fd99dcdacf
> 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -466,13 +466,14 @@ static void mtk_dsi_config_vdo_timing(struct
> mtk_dsi *dsi) horizontal_sync_active_byte = (vm->hsync_len *
> dsi_tmp_buf_bpp - 10); 
>  	if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE)
> -		horizontal_backporch_byte = vm->hback_porch *
> dsi_tmp_buf_bpp;
> +		horizontal_backporch_byte =
> +			(vm->hback_porch * dsi_tmp_buf_bpp - 10);
>  	else
> -		horizontal_backporch_byte = (vm->hback_porch +
> vm->hsync_len) *
> -					    dsi_tmp_buf_bpp;
> +		horizontal_backporch_byte = ((vm->hback_porch +
> vm->hsync_len) *
> +			dsi_tmp_buf_bpp - 10);
>  
>  	data_phy_cycles = timing->lpx + timing->da_hs_prepare +
> -			  timing->da_hs_zero + timing->da_hs_exit;
> +			  timing->da_hs_zero + timing->da_hs_exit +
> 3; 
>  	if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) {
>  		if ((vm->hfront_porch + vm->hback_porch) *
> dsi_tmp_buf_bpp >

Reviewed-by: Bilal Wasim <bilal.wasim@imgtec.com>
Tested-by: Bilal Wasim <bilal.wasim@imgtec.com>

Thanks,
Bilal
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-10-12 12:07 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-10  7:09 [v4 PATCH 0/2] fix scrolling of panel with small hfp or hbp Jitao Shi
2020-10-10  7:09 ` Jitao Shi
2020-10-10  7:09 ` Jitao Shi
2020-10-10  7:09 ` Jitao Shi
2020-10-10  7:09 ` [PATCH v4 1/2] Revert "drm/mediatek: dsi: Fix scrolling of panel with small hfp or hbp" Jitao Shi
2020-10-10  7:09   ` Jitao Shi
2020-10-10  7:09   ` Jitao Shi
2020-10-10  7:09   ` Jitao Shi
2020-10-12 12:07   ` Bilal Wasim [this message]
2020-10-12 12:07     ` Bilal Wasim
2020-10-12 12:07     ` Bilal Wasim
2020-10-12 12:07     ` Bilal Wasim
2020-10-10  7:09 ` [PATCH v4 2/2] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp Jitao Shi
2020-10-10  7:09   ` Jitao Shi
2020-10-10  7:09   ` Jitao Shi
2020-10-10  7:09   ` Jitao Shi
2020-10-12 15:22 ` [v4 PATCH 0/2] " Chun-Kuang Hu
2020-10-12 15:22   ` Chun-Kuang Hu
2020-10-12 15:22   ` Chun-Kuang Hu
2020-10-12 15:22   ` Chun-Kuang Hu
2020-10-13  9:55   ` Jitao Shi
2020-10-13  9:55     ` Jitao Shi
2020-10-13  9:55     ` Jitao Shi
2020-10-13  9:55     ` Jitao Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201012170730.582d4b96@a-VirtualBox \
    --to=bilalwasim676@gmail.com \
    --cc=airlied@linux.ie \
    --cc=bibby.hsieh@mediatek.com \
    --cc=cawa.cheng@mediatek.com \
    --cc=ck.hu@mediatek.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eddie.huang@mediatek.com \
    --cc=huijuan.xie@mediatek.com \
    --cc=jitao.shi@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=srv_heupstream@mediatek.com \
    --cc=stonea168@163.com \
    --cc=yingjoe.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.