From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, Tsuchiya Yuto <kitakar@gmail.com>,
bingbu.cao@intel.com, Yong Zhi <yong.zhi@intel.com>,
Tianshu Qiu <tian.shu.qiu@intel.com>
Subject: Re: [PATCH v3 7/8] ipu3-cio2: Rename CIO2_IMAGE_MAX_LENGTH as CIO2_IMAGE_MAX_HEIGHT
Date: Mon, 12 Oct 2020 21:32:35 +0300 [thread overview]
Message-ID: <20201012183235.GA740@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20201012180414.11579-8-sakari.ailus@linux.intel.com>
Hi Sakari,
Thank you for the patch.
On Mon, Oct 12, 2020 at 09:04:13PM +0300, Sakari Ailus wrote:
> CIO2_IMAGE_MAX_LENGTH is the maximum width of the image. Rename it as
I assume you mean maximum height :-) With this fixed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> "CIO2_IMAGE_MAX_HEIGHT" in order to better describe what it is.
>
> Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> drivers/media/pci/intel/ipu3/ipu3-cio2.c | 6 +++---
> drivers/media/pci/intel/ipu3/ipu3-cio2.h | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> index e42177f8c426..d9baa8bfe54f 100644
> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> @@ -1094,8 +1094,8 @@ static int cio2_v4l2_try_fmt(struct file *file, void *fh, struct v4l2_format *f)
> /* Only supports up to 4224x3136 */
> if (mpix->width > CIO2_IMAGE_MAX_WIDTH)
> mpix->width = CIO2_IMAGE_MAX_WIDTH;
> - if (mpix->height > CIO2_IMAGE_MAX_LENGTH)
> - mpix->height = CIO2_IMAGE_MAX_LENGTH;
> + if (mpix->height > CIO2_IMAGE_MAX_HEIGHT)
> + mpix->height = CIO2_IMAGE_MAX_HEIGHT;
>
> mpix->num_planes = 1;
> mpix->pixelformat = fmt->fourcc;
> @@ -1283,7 +1283,7 @@ static int cio2_subdev_set_fmt(struct v4l2_subdev *sd,
> }
>
> fmt->format.width = min(fmt->format.width, CIO2_IMAGE_MAX_WIDTH);
> - fmt->format.height = min(fmt->format.height, CIO2_IMAGE_MAX_LENGTH);
> + fmt->format.height = min(fmt->format.height, CIO2_IMAGE_MAX_HEIGHT);
> fmt->format.field = V4L2_FIELD_NONE;
>
> mutex_lock(&q->subdev_lock);
> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.h b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
> index 7650d7998a3f..ccf0b85ae36f 100644
> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.h
> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
> @@ -14,7 +14,7 @@
> #define CIO2_DMA_MASK DMA_BIT_MASK(39)
>
> #define CIO2_IMAGE_MAX_WIDTH 4224U
> -#define CIO2_IMAGE_MAX_LENGTH 3136U
> +#define CIO2_IMAGE_MAX_HEIGHT 3136U
>
> /* 32MB = 8xFBPT_entry */
> #define CIO2_MAX_LOPS 8
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-10-12 18:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 18:04 [PATCH v3 0/8] ipu3-cio2 format and other fixes Sakari Ailus
2020-10-12 18:04 ` [PATCH v3 1/8] ipu3-cio2: Return actual subdev format Sakari Ailus
2020-10-12 18:04 ` [PATCH v3 2/8] ipu3-cio2: Serialise access to pad format Sakari Ailus
2020-10-12 18:04 ` [PATCH v3 3/8] ipu3-cio2: Validate mbus format in setting subdev format Sakari Ailus
2020-10-12 18:04 ` [PATCH v3 4/8] ipu3-cio2: Make the field on subdev format V4L2_FIELD_NONE Sakari Ailus
2020-10-12 18:04 ` [PATCH v3 5/8] ipu3-cio2: Use unsigned values where appropriate Sakari Ailus
2020-10-12 18:04 ` [PATCH v3 6/8] ipu3-cio2: Remove explicit type from frame size checks Sakari Ailus
2020-10-12 18:30 ` Andy Shevchenko
2020-10-12 18:35 ` Laurent Pinchart
2020-10-12 18:04 ` [PATCH v3 7/8] ipu3-cio2: Rename CIO2_IMAGE_MAX_LENGTH as CIO2_IMAGE_MAX_HEIGHT Sakari Ailus
2020-10-12 18:31 ` Andy Shevchenko
2020-10-12 18:32 ` Laurent Pinchart [this message]
2020-10-12 18:04 ` [PATCH v3 8/8] ipu3-cio2: Remove traces of returned buffers Sakari Ailus
2020-10-12 18:32 ` Andy Shevchenko
2020-10-13 7:22 ` Sakari Ailus
2020-10-12 18:35 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012183235.GA740@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=bingbu.cao@intel.com \
--cc=kitakar@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.