From: kernel test robot <lkp@intel.com>
To: Al Cooper <alcooperx@gmail.com>, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
Al Cooper <alcooperx@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v3 2/2] usb: Add driver to allow any GPIO to be used for 7211 USB signals
Date: Tue, 13 Oct 2020 08:18:11 +0800 [thread overview]
Message-ID: <202010130818.H4HkrMGs-lkp@intel.com> (raw)
In-Reply-To: <20201012200007.8862-3-alcooperx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3230 bytes --]
Hi Al,
I love your patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on linus/master linux/master v5.9 next-20201012]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Al-Cooper/usb-Add-driver-for-USB-signal-re-mapper/20201013-040257
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: arm64-randconfig-r032-20201012 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 9e72d3eaf38f217698f72cb8fdc969a6e72dad3a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/96c8d52dbcdf6606c03aa54bcb5aece99b9328de
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Al-Cooper/usb-Add-driver-for-USB-signal-re-mapper/20201013-040257
git checkout 96c8d52dbcdf6606c03aa54bcb5aece99b9328de
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/usb/misc/brcmstb-usb-pinmap.c:219:6: warning: no previous prototype for function 'sync_all_pins' [-Wmissing-prototypes]
void sync_all_pins(struct brcmstb_usb_pinmap_data *pdata)
^
drivers/usb/misc/brcmstb-usb-pinmap.c:219:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void sync_all_pins(struct brcmstb_usb_pinmap_data *pdata)
^
static
1 warning generated.
vim +/sync_all_pins +219 drivers/usb/misc/brcmstb-usb-pinmap.c
218
> 219 void sync_all_pins(struct brcmstb_usb_pinmap_data *pdata)
220 {
221 struct out_pin *pout;
222 struct in_pin *pin;
223 int val;
224 int x;
225
226 /*
227 * Enable the override, clear any changed condition and
228 * propagate the state to the GPIO for all out pins.
229 */
230 pout = pdata->out_pins;
231 for (x = 0; x < pdata->out_count; x++) {
232 pinmap_set(pdata->regs, pout->enable_mask);
233 pinmap_set(pdata->regs, pout->clr_changed_mask);
234 pinmap_unset(pdata->regs, pout->clr_changed_mask);
235 val = readl(pdata->regs) & pout->value_mask;
236 gpiod_set_value(pout->gpiod, val ? 1 : 0);
237 pout++;
238 }
239
240 /* sync and enable all in pins. */
241 pin = pdata->in_pins;
242 for (x = 0; x < pdata->in_count; x++) {
243 sync_in_pin(pin);
244 pinmap_set(pdata->regs, pin->enable_mask);
245 pin++;
246 }
247 }
248
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 39294 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 2/2] usb: Add driver to allow any GPIO to be used for 7211 USB signals
Date: Tue, 13 Oct 2020 08:18:11 +0800 [thread overview]
Message-ID: <202010130818.H4HkrMGs-lkp@intel.com> (raw)
In-Reply-To: <20201012200007.8862-3-alcooperx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3309 bytes --]
Hi Al,
I love your patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on linus/master linux/master v5.9 next-20201012]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Al-Cooper/usb-Add-driver-for-USB-signal-re-mapper/20201013-040257
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: arm64-randconfig-r032-20201012 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 9e72d3eaf38f217698f72cb8fdc969a6e72dad3a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/96c8d52dbcdf6606c03aa54bcb5aece99b9328de
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Al-Cooper/usb-Add-driver-for-USB-signal-re-mapper/20201013-040257
git checkout 96c8d52dbcdf6606c03aa54bcb5aece99b9328de
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/usb/misc/brcmstb-usb-pinmap.c:219:6: warning: no previous prototype for function 'sync_all_pins' [-Wmissing-prototypes]
void sync_all_pins(struct brcmstb_usb_pinmap_data *pdata)
^
drivers/usb/misc/brcmstb-usb-pinmap.c:219:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void sync_all_pins(struct brcmstb_usb_pinmap_data *pdata)
^
static
1 warning generated.
vim +/sync_all_pins +219 drivers/usb/misc/brcmstb-usb-pinmap.c
218
> 219 void sync_all_pins(struct brcmstb_usb_pinmap_data *pdata)
220 {
221 struct out_pin *pout;
222 struct in_pin *pin;
223 int val;
224 int x;
225
226 /*
227 * Enable the override, clear any changed condition and
228 * propagate the state to the GPIO for all out pins.
229 */
230 pout = pdata->out_pins;
231 for (x = 0; x < pdata->out_count; x++) {
232 pinmap_set(pdata->regs, pout->enable_mask);
233 pinmap_set(pdata->regs, pout->clr_changed_mask);
234 pinmap_unset(pdata->regs, pout->clr_changed_mask);
235 val = readl(pdata->regs) & pout->value_mask;
236 gpiod_set_value(pout->gpiod, val ? 1 : 0);
237 pout++;
238 }
239
240 /* sync and enable all in pins. */
241 pin = pdata->in_pins;
242 for (x = 0; x < pdata->in_count; x++) {
243 sync_in_pin(pin);
244 pinmap_set(pdata->regs, pin->enable_mask);
245 pin++;
246 }
247 }
248
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39294 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Al Cooper <alcooperx@gmail.com>, linux-kernel@vger.kernel.org
Cc: devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
kbuild-all@lists.01.org, Rob Herring <robh+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Al Cooper <alcooperx@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
clang-built-linux@googlegroups.com, linux-usb@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/2] usb: Add driver to allow any GPIO to be used for 7211 USB signals
Date: Tue, 13 Oct 2020 08:18:11 +0800 [thread overview]
Message-ID: <202010130818.H4HkrMGs-lkp@intel.com> (raw)
In-Reply-To: <20201012200007.8862-3-alcooperx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3230 bytes --]
Hi Al,
I love your patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on linus/master linux/master v5.9 next-20201012]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Al-Cooper/usb-Add-driver-for-USB-signal-re-mapper/20201013-040257
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: arm64-randconfig-r032-20201012 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 9e72d3eaf38f217698f72cb8fdc969a6e72dad3a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/96c8d52dbcdf6606c03aa54bcb5aece99b9328de
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Al-Cooper/usb-Add-driver-for-USB-signal-re-mapper/20201013-040257
git checkout 96c8d52dbcdf6606c03aa54bcb5aece99b9328de
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/usb/misc/brcmstb-usb-pinmap.c:219:6: warning: no previous prototype for function 'sync_all_pins' [-Wmissing-prototypes]
void sync_all_pins(struct brcmstb_usb_pinmap_data *pdata)
^
drivers/usb/misc/brcmstb-usb-pinmap.c:219:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void sync_all_pins(struct brcmstb_usb_pinmap_data *pdata)
^
static
1 warning generated.
vim +/sync_all_pins +219 drivers/usb/misc/brcmstb-usb-pinmap.c
218
> 219 void sync_all_pins(struct brcmstb_usb_pinmap_data *pdata)
220 {
221 struct out_pin *pout;
222 struct in_pin *pin;
223 int val;
224 int x;
225
226 /*
227 * Enable the override, clear any changed condition and
228 * propagate the state to the GPIO for all out pins.
229 */
230 pout = pdata->out_pins;
231 for (x = 0; x < pdata->out_count; x++) {
232 pinmap_set(pdata->regs, pout->enable_mask);
233 pinmap_set(pdata->regs, pout->clr_changed_mask);
234 pinmap_unset(pdata->regs, pout->clr_changed_mask);
235 val = readl(pdata->regs) & pout->value_mask;
236 gpiod_set_value(pout->gpiod, val ? 1 : 0);
237 pout++;
238 }
239
240 /* sync and enable all in pins. */
241 pin = pdata->in_pins;
242 for (x = 0; x < pdata->in_count; x++) {
243 sync_in_pin(pin);
244 pinmap_set(pdata->regs, pin->enable_mask);
245 pin++;
246 }
247 }
248
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 39294 bytes --]
[-- Attachment #3: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-13 2:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 20:00 [PATCH v3 0/2] usb: Add driver for USB signal re-mapper Al Cooper
2020-10-12 20:00 ` Al Cooper
2020-10-12 20:00 ` [PATCH v3 1/2] dt-bindings: Add support for Broadcom USB pin map driver Al Cooper
2020-10-12 20:00 ` Al Cooper
2020-10-19 20:19 ` Rob Herring
2020-10-19 20:19 ` Rob Herring
2020-10-12 20:00 ` [PATCH v3 2/2] usb: Add driver to allow any GPIO to be used for 7211 USB signals Al Cooper
2020-10-12 20:00 ` Al Cooper
2020-10-13 0:18 ` kernel test robot [this message]
2020-10-13 0:18 ` kernel test robot
2020-10-13 0:18 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202010130818.H4HkrMGs-lkp@intel.com \
--to=lkp@intel.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=clang-built-linux@googlegroups.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.