* [PATCH] perf c2c: Update usage for showing memory events
@ 2020-10-11 12:10 Leo Yan
2020-10-12 9:13 ` Jiri Olsa
0 siblings, 1 reply; 4+ messages in thread
From: Leo Yan @ 2020-10-11 12:10 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Peter Zijlstra, Ingo Molnar,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Ian Rogers, linux-kernel
Cc: Leo Yan
Since commit b027cc6fdf1b ("perf c2c: Fix 'perf c2c record -e list' to
show the default events used"), "perf c2c" tool can show the memory
events properly, it's no reason to still suggest user to use the
command "perf mem record -e list" for showing events.
This patch updates the usage for showing memory events with command
"perf c2c record -e list".
Signed-off-by: Leo Yan <leo.yan@linaro.org>
---
tools/perf/builtin-c2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index 5938b100eaf4..57bb6cce43e3 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -2916,7 +2916,7 @@ static int perf_c2c__record(int argc, const char **argv)
bool event_set = false;
struct option options[] = {
OPT_CALLBACK('e', "event", &event_set, "event",
- "event selector. Use 'perf mem record -e list' to list available events",
+ "event selector. Use 'perf c2c record -e list' to list available events",
parse_record_events),
OPT_BOOLEAN('u', "all-user", &all_user, "collect only user level data"),
OPT_BOOLEAN('k', "all-kernel", &all_kernel, "collect only kernel level data"),
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] perf c2c: Update usage for showing memory events
2020-10-11 12:10 [PATCH] perf c2c: Update usage for showing memory events Leo Yan
@ 2020-10-12 9:13 ` Jiri Olsa
2020-10-12 15:25 ` Ian Rogers
0 siblings, 1 reply; 4+ messages in thread
From: Jiri Olsa @ 2020-10-12 9:13 UTC (permalink / raw)
To: Leo Yan
Cc: Arnaldo Carvalho de Melo, Peter Zijlstra, Ingo Molnar,
Mark Rutland, Alexander Shishkin, Namhyung Kim, Ian Rogers,
linux-kernel
On Sun, Oct 11, 2020 at 08:10:22PM +0800, Leo Yan wrote:
> Since commit b027cc6fdf1b ("perf c2c: Fix 'perf c2c record -e list' to
> show the default events used"), "perf c2c" tool can show the memory
> events properly, it's no reason to still suggest user to use the
> command "perf mem record -e list" for showing events.
>
> This patch updates the usage for showing memory events with command
> "perf c2c record -e list".
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks,
jirka
> ---
> tools/perf/builtin-c2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> index 5938b100eaf4..57bb6cce43e3 100644
> --- a/tools/perf/builtin-c2c.c
> +++ b/tools/perf/builtin-c2c.c
> @@ -2916,7 +2916,7 @@ static int perf_c2c__record(int argc, const char **argv)
> bool event_set = false;
> struct option options[] = {
> OPT_CALLBACK('e', "event", &event_set, "event",
> - "event selector. Use 'perf mem record -e list' to list available events",
> + "event selector. Use 'perf c2c record -e list' to list available events",
> parse_record_events),
> OPT_BOOLEAN('u', "all-user", &all_user, "collect only user level data"),
> OPT_BOOLEAN('k', "all-kernel", &all_kernel, "collect only kernel level data"),
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] perf c2c: Update usage for showing memory events
2020-10-12 9:13 ` Jiri Olsa
@ 2020-10-12 15:25 ` Ian Rogers
2020-10-13 16:16 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 4+ messages in thread
From: Ian Rogers @ 2020-10-12 15:25 UTC (permalink / raw)
To: Jiri Olsa
Cc: Leo Yan, Arnaldo Carvalho de Melo, Peter Zijlstra, Ingo Molnar,
Mark Rutland, Alexander Shishkin, Namhyung Kim, LKML
On Mon, Oct 12, 2020 at 2:13 AM Jiri Olsa <jolsa@redhat.com> wrote:
>
> On Sun, Oct 11, 2020 at 08:10:22PM +0800, Leo Yan wrote:
> > Since commit b027cc6fdf1b ("perf c2c: Fix 'perf c2c record -e list' to
> > show the default events used"), "perf c2c" tool can show the memory
> > events properly, it's no reason to still suggest user to use the
> > command "perf mem record -e list" for showing events.
> >
> > This patch updates the usage for showing memory events with command
> > "perf c2c record -e list".
> >
> > Signed-off-by: Leo Yan <leo.yan@linaro.org>
>
> Acked-by: Jiri Olsa <jolsa@redhat.com>
>
> thanks,
> jirka
Acked-by: Ian Rogers <irogers@google.com>
Thanks,
Ian
> > ---
> > tools/perf/builtin-c2c.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> > index 5938b100eaf4..57bb6cce43e3 100644
> > --- a/tools/perf/builtin-c2c.c
> > +++ b/tools/perf/builtin-c2c.c
> > @@ -2916,7 +2916,7 @@ static int perf_c2c__record(int argc, const char **argv)
> > bool event_set = false;
> > struct option options[] = {
> > OPT_CALLBACK('e', "event", &event_set, "event",
> > - "event selector. Use 'perf mem record -e list' to list available events",
> > + "event selector. Use 'perf c2c record -e list' to list available events",
> > parse_record_events),
> > OPT_BOOLEAN('u', "all-user", &all_user, "collect only user level data"),
> > OPT_BOOLEAN('k', "all-kernel", &all_kernel, "collect only kernel level data"),
> > --
> > 2.17.1
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] perf c2c: Update usage for showing memory events
2020-10-12 15:25 ` Ian Rogers
@ 2020-10-13 16:16 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2020-10-13 16:16 UTC (permalink / raw)
To: Ian Rogers
Cc: Jiri Olsa, Leo Yan, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Namhyung Kim, LKML
Em Mon, Oct 12, 2020 at 08:25:42AM -0700, Ian Rogers escreveu:
> On Mon, Oct 12, 2020 at 2:13 AM Jiri Olsa <jolsa@redhat.com> wrote:
> >
> > On Sun, Oct 11, 2020 at 08:10:22PM +0800, Leo Yan wrote:
> > > Since commit b027cc6fdf1b ("perf c2c: Fix 'perf c2c record -e list' to
> > > show the default events used"), "perf c2c" tool can show the memory
> > > events properly, it's no reason to still suggest user to use the
> > > command "perf mem record -e list" for showing events.
> > >
> > > This patch updates the usage for showing memory events with command
> > > "perf c2c record -e list".
> > >
> > > Signed-off-by: Leo Yan <leo.yan@linaro.org>
> >
> > Acked-by: Jiri Olsa <jolsa@redhat.com>
> >
> > thanks,
> > jirka
>
> Acked-by: Ian Rogers <irogers@google.com>
Thanks, applied.
- Arnaldo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-13 16:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-11 12:10 [PATCH] perf c2c: Update usage for showing memory events Leo Yan
2020-10-12 9:13 ` Jiri Olsa
2020-10-12 15:25 ` Ian Rogers
2020-10-13 16:16 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.