[PATCH v2] gpio: 104-idi-48: improve code indentation

[PATCH v2] gpio: 104-idi-48: improve code indentation

[Deepak R Varma]

Address code indentation warning messages by checkpatch script. Combine
split function parameters on one line. This also resolves the "use tabs
instead of space" warning by checkpatch script.

Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>

---
Changes since v1:
   - Correct subject line per feedback from Greg KH.

 drivers/gpio/gpio-104-idi-48.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpio/gpio-104-idi-48.c b/drivers/gpio/gpio-104-idi-48.c
index 94c3a9bc4e75..b132afaf7d99 100644
--- a/drivers/gpio/gpio-104-idi-48.c
+++ b/drivers/gpio/gpio-104-idi-48.c
@@ -132,8 +132,7 @@ static void idi_48_irq_mask(struct irq_data *data)
 
 				outb(idi48gpio->cos_enb, idi48gpio->base + 7);
 
-				raw_spin_unlock_irqrestore(&idi48gpio->lock,
-						           flags);
+				raw_spin_unlock_irqrestore(&idi48gpio->lock, flags);
 			}
 
 			return;
@@ -166,8 +165,7 @@ static void idi_48_irq_unmask(struct irq_data *data)
 
 				outb(idi48gpio->cos_enb, idi48gpio->base + 7);
 
-				raw_spin_unlock_irqrestore(&idi48gpio->lock,
-						           flags);
+				raw_spin_unlock_irqrestore(&idi48gpio->lock, flags);
 			}
 
 			return;
-- 
2.25.1

Re: [PATCH v2] gpio: 104-idi-48: improve code indentation

[Greg KH]

On Wed, Oct 14, 2020 at 12:32:12AM +0530, Deepak R Varma wrote:
> Address code indentation warning messages by checkpatch script. Combine
> split function parameters on one line. This also resolves the "use tabs
> instead of space" warning by checkpatch script.
> 
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> 
> ---
> Changes since v1:
>    - Correct subject line per feedback from Greg KH.
> 
>  drivers/gpio/gpio-104-idi-48.c | 6 ++----

For the outreachy project application, they do not accept patches
outside of drivers/staging, as per the documentation.  So I do not know
why you are sending a patch for this to the outreachy list and not to
the "correct" list for gpio patches.

Please do not work outside of drivers/staging/ for the outreachy process
at this point in time.

thanks,

greg k-h

Re: [PATCH v2] gpio: 104-idi-48: improve code indentation

[Deepak R Varma]

On Wed, Oct 14, 2020 at 06:54:49AM +0200, Greg KH wrote:
> On Wed, Oct 14, 2020 at 12:32:12AM +0530, Deepak R Varma wrote:
> > Address code indentation warning messages by checkpatch script. Combine
> > split function parameters on one line. This also resolves the "use tabs
> > instead of space" warning by checkpatch script.
> > 
> > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> > 
> > ---
> > Changes since v1:
> >    - Correct subject line per feedback from Greg KH.
> > 
> >  drivers/gpio/gpio-104-idi-48.c | 6 ++----
> 
> For the outreachy project application, they do not accept patches
> outside of drivers/staging, as per the documentation.  So I do not know
> why you are sending a patch for this to the outreachy list and not to
> the "correct" list for gpio patches.
> 
> Please do not work outside of drivers/staging/ for the outreachy process
> at this point in time.

My apologies. I definitely missed the directory track. Will look into the
drivers/staging only for now.

Thank you,
Deepak.

> 
> thanks,
> 
> greg k-h