All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: Saravana Kannan <saravanak@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: fw_devlink on will break all snps,dw-apb-gpio users
Date: Wed, 14 Oct 2020 19:12:35 +0800	[thread overview]
Message-ID: <20201014191235.7f71fcb4@xhacker.debian> (raw)

Hi,

If set fw_devlink as on, any consumers of dw apb gpio won't probe.

The related dts looks like:

gpio0: gpio@2400 {
       compatible = "snps,dw-apb-gpio";
       #address-cells = <1>;
       #size-cells = <0>;

       porta: gpio-port@0 {
              compatible = "snps,dw-apb-gpio-port";
              gpio-controller;
              #gpio-cells = <2>;
              ngpios = <32>;
              reg = <0>;
       };
};

device_foo {
	status = "okay"
	...;
	reset-gpio = <&porta, 0, GPIO_ACTIVE_HIGH>;
};

If I change the reset-gpio property to use another kind of gpio phandle,
e.g gpio expander, then device_foo can be probed successfully.

The gpio expander dt node looks like:

	expander3: gpio@44 {
                compatible = "fcs,fxl6408";
                pinctrl-names = "default";
                pinctrl-0 = <&expander3_pmux>;
                reg = <0x44>;
                gpio-controller;
                #gpio-cells = <2>;
                interrupt-parent = <&portb>;
                interrupts = <23 IRQ_TYPE_NONE>;
                interrupt-controller;
                #interrupt-cells = <2>;
        };

The common pattern looks like the devlink can't cope with suppliers from
child dt node.

Any suggestions?

Thanks in advance,
Jisheng

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: Saravana Kannan <saravanak@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: fw_devlink on will break all snps,dw-apb-gpio users
Date: Wed, 14 Oct 2020 19:12:35 +0800	[thread overview]
Message-ID: <20201014191235.7f71fcb4@xhacker.debian> (raw)

Hi,

If set fw_devlink as on, any consumers of dw apb gpio won't probe.

The related dts looks like:

gpio0: gpio@2400 {
       compatible = "snps,dw-apb-gpio";
       #address-cells = <1>;
       #size-cells = <0>;

       porta: gpio-port@0 {
              compatible = "snps,dw-apb-gpio-port";
              gpio-controller;
              #gpio-cells = <2>;
              ngpios = <32>;
              reg = <0>;
       };
};

device_foo {
	status = "okay"
	...;
	reset-gpio = <&porta, 0, GPIO_ACTIVE_HIGH>;
};

If I change the reset-gpio property to use another kind of gpio phandle,
e.g gpio expander, then device_foo can be probed successfully.

The gpio expander dt node looks like:

	expander3: gpio@44 {
                compatible = "fcs,fxl6408";
                pinctrl-names = "default";
                pinctrl-0 = <&expander3_pmux>;
                reg = <0x44>;
                gpio-controller;
                #gpio-cells = <2>;
                interrupt-parent = <&portb>;
                interrupts = <23 IRQ_TYPE_NONE>;
                interrupt-controller;
                #interrupt-cells = <2>;
        };

The common pattern looks like the devlink can't cope with suppliers from
child dt node.

Any suggestions?

Thanks in advance,
Jisheng

             reply	other threads:[~2020-10-14 11:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14 11:12 Jisheng Zhang [this message]
2020-10-14 11:12 ` fw_devlink on will break all snps,dw-apb-gpio users Jisheng Zhang
2020-10-14 17:29 ` Saravana Kannan
2020-10-14 17:29   ` Saravana Kannan
2020-10-15  4:02   ` Jisheng Zhang
2020-10-15  4:02     ` Jisheng Zhang
2020-10-15  5:04     ` Saravana Kannan
2020-10-15  5:04       ` Saravana Kannan
2020-10-15  8:14       ` Jisheng Zhang
2020-10-15  8:14         ` Jisheng Zhang
2020-10-15  8:48         ` Saravana Kannan
2020-10-15  8:48           ` Saravana Kannan
2020-10-15  9:52           ` Jisheng Zhang
2020-10-15  9:52             ` Jisheng Zhang
2020-10-15 14:08             ` Robin Murphy
2020-10-15 14:08               ` Robin Murphy
2020-10-16  3:39               ` Jisheng Zhang
2020-10-16  3:39                 ` Jisheng Zhang
2020-10-17  0:44                 ` Saravana Kannan
2020-10-17  0:44                   ` Saravana Kannan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201014191235.7f71fcb4@xhacker.debian \
    --to=jisheng.zhang@synaptics.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=saravanak@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.