From: Christoph Hellwig <hch@lst.de>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: devicetree@vger.kernel.org, catalin.marinas@arm.com,
linux-kernel@vger.kernel.org, jeremy.linton@arm.com,
ardb@kernel.org, linux-mm@kvack.org,
iommu@lists.linux-foundation.org, robh+dt@kernel.org,
linux-rpi-kernel@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>,
robin.murphy@arm.com, hch@lst.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 8/8] mm: Update DMA zones description
Date: Thu, 15 Oct 2020 07:40:26 +0200 [thread overview]
Message-ID: <20201015054026.GC12218@lst.de> (raw)
In-Reply-To: <20201014191211.27029-9-nsaenzjulienne@suse.de>
On Wed, Oct 14, 2020 at 09:12:10PM +0200, Nicolas Saenz Julienne wrote:
> The default behavior for arm64 changed, so reflect that.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> ---
> include/linux/mmzone.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index fb3bf696c05e..4ee2306351b9 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -363,8 +363,9 @@ enum zone_type {
> * - arm only uses ZONE_DMA, the size, up to 4G, may vary depending on
> * the specific device.
> *
> - * - arm64 has a fixed 1G ZONE_DMA and ZONE_DMA32 for the rest of the
> - * lower 4G.
> + * - arm64 uses a single 4GB ZONE_DMA, except on the Raspberry Pi 4,
> + * in which ZONE_DMA covers the first GB and ZONE_DMA32 the rest of
> + * the lower 4GB.
Honestly I think this comment just needs to go away. We can't really list
every setup in a comment in common code.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: devicetree@vger.kernel.org, catalin.marinas@arm.com,
linux-kernel@vger.kernel.org, jeremy.linton@arm.com,
ardb@kernel.org, linux-mm@kvack.org,
iommu@lists.linux-foundation.org, robh+dt@kernel.org,
linux-rpi-kernel@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>,
robin.murphy@arm.com, hch@lst.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 8/8] mm: Update DMA zones description
Date: Thu, 15 Oct 2020 07:40:26 +0200 [thread overview]
Message-ID: <20201015054026.GC12218@lst.de> (raw)
In-Reply-To: <20201014191211.27029-9-nsaenzjulienne@suse.de>
On Wed, Oct 14, 2020 at 09:12:10PM +0200, Nicolas Saenz Julienne wrote:
> The default behavior for arm64 changed, so reflect that.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> ---
> include/linux/mmzone.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index fb3bf696c05e..4ee2306351b9 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -363,8 +363,9 @@ enum zone_type {
> * - arm only uses ZONE_DMA, the size, up to 4G, may vary depending on
> * the specific device.
> *
> - * - arm64 has a fixed 1G ZONE_DMA and ZONE_DMA32 for the rest of the
> - * lower 4G.
> + * - arm64 uses a single 4GB ZONE_DMA, except on the Raspberry Pi 4,
> + * in which ZONE_DMA covers the first GB and ZONE_DMA32 the rest of
> + * the lower 4GB.
Honestly I think this comment just needs to go away. We can't really list
every setup in a comment in common code.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: robh+dt@kernel.org, catalin.marinas@arm.com, hch@lst.de,
ardb@kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org, jeremy.linton@arm.com,
iommu@lists.linux-foundation.org, devicetree@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v3 8/8] mm: Update DMA zones description
Date: Thu, 15 Oct 2020 07:40:26 +0200 [thread overview]
Message-ID: <20201015054026.GC12218@lst.de> (raw)
In-Reply-To: <20201014191211.27029-9-nsaenzjulienne@suse.de>
On Wed, Oct 14, 2020 at 09:12:10PM +0200, Nicolas Saenz Julienne wrote:
> The default behavior for arm64 changed, so reflect that.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> ---
> include/linux/mmzone.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index fb3bf696c05e..4ee2306351b9 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -363,8 +363,9 @@ enum zone_type {
> * - arm only uses ZONE_DMA, the size, up to 4G, may vary depending on
> * the specific device.
> *
> - * - arm64 has a fixed 1G ZONE_DMA and ZONE_DMA32 for the rest of the
> - * lower 4G.
> + * - arm64 uses a single 4GB ZONE_DMA, except on the Raspberry Pi 4,
> + * in which ZONE_DMA covers the first GB and ZONE_DMA32 the rest of
> + * the lower 4GB.
Honestly I think this comment just needs to go away. We can't really list
every setup in a comment in common code.
next prev parent reply other threads:[~2020-10-15 5:40 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 19:12 [PATCH v3 0/8] arm64: Default to 32-bit wide ZONE_DMA Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` [PATCH v3 1/8] arm64: mm: Move reserve_crashkernel() into mem_init() Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-15 8:40 ` Will Deacon
2020-10-15 8:40 ` Will Deacon
2020-10-15 8:40 ` Will Deacon
2020-10-15 8:55 ` Nicolas Saenz Julienne
2020-10-15 8:55 ` Nicolas Saenz Julienne
2020-10-15 8:55 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` [PATCH v3 2/8] arm64: mm: Move zone_dma_bits initialization into zone_sizes_init() Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` [PATCH v3 3/8] of/address: Introduce of_dma_get_max_cpu_address() Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 22:02 ` Rob Herring
2020-10-14 22:02 ` Rob Herring
2020-10-14 22:02 ` Rob Herring
2020-10-15 6:56 ` Ard Biesheuvel
2020-10-15 6:56 ` Ard Biesheuvel
2020-10-15 6:56 ` Ard Biesheuvel
2020-10-15 9:16 ` Nicolas Saenz Julienne
2020-10-15 9:16 ` Nicolas Saenz Julienne
2020-10-15 9:16 ` Nicolas Saenz Julienne
2020-10-15 9:18 ` Ard Biesheuvel
2020-10-15 9:18 ` Ard Biesheuvel
2020-10-15 9:18 ` Ard Biesheuvel
2020-10-15 8:54 ` Nicolas Saenz Julienne
2020-10-15 8:54 ` Nicolas Saenz Julienne
2020-10-15 8:54 ` Nicolas Saenz Julienne
2020-10-15 5:42 ` Christoph Hellwig
2020-10-15 5:42 ` Christoph Hellwig
2020-10-15 5:42 ` Christoph Hellwig
2020-10-15 10:03 ` Nicolas Saenz Julienne
2020-10-15 10:03 ` Nicolas Saenz Julienne
2020-10-15 10:03 ` Nicolas Saenz Julienne
2020-10-16 13:19 ` Rob Herring
2020-10-16 13:19 ` Rob Herring
2020-10-16 13:19 ` Rob Herring
2020-10-14 19:12 ` [PATCH v3 4/8] of: unittest: Add test for of_dma_get_max_cpu_address() Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 22:04 ` Rob Herring
2020-10-14 22:04 ` Rob Herring
2020-10-14 22:04 ` Rob Herring
2020-10-15 9:51 ` Nicolas Saenz Julienne
2020-10-15 9:51 ` Nicolas Saenz Julienne
2020-10-15 9:51 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` [PATCH v3 5/8] dma-direct: Turn zone_dma_bits default value into a define Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-15 5:38 ` Christoph Hellwig
2020-10-15 5:38 ` Christoph Hellwig
2020-10-15 5:38 ` Christoph Hellwig
2020-10-15 10:05 ` Nicolas Saenz Julienne
2020-10-15 10:05 ` Nicolas Saenz Julienne
2020-10-15 10:05 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` [PATCH v3 6/8] arm64: mm: Set ZONE_DMA size based on devicetree's dma-ranges Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-15 5:39 ` Christoph Hellwig
2020-10-15 5:39 ` Christoph Hellwig
2020-10-15 5:39 ` Christoph Hellwig
2020-10-15 10:05 ` Nicolas Saenz Julienne
2020-10-15 10:05 ` Nicolas Saenz Julienne
2020-10-15 10:05 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` [PATCH v3 7/8] arm64: mm: Set ZONE_DMA size based on early IORT scan Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-15 10:31 ` Lorenzo Pieralisi
2020-10-15 10:31 ` Lorenzo Pieralisi
2020-10-15 10:31 ` Lorenzo Pieralisi
2020-10-16 6:56 ` Ard Biesheuvel
2020-10-16 6:56 ` Ard Biesheuvel
2020-10-16 6:56 ` Ard Biesheuvel
2020-10-15 14:26 ` Hanjun Guo
2020-10-15 14:26 ` Hanjun Guo
2020-10-15 14:26 ` Hanjun Guo
2020-10-15 15:15 ` Nicolas Saenz Julienne
2020-10-15 15:15 ` Nicolas Saenz Julienne
2020-10-15 15:15 ` Nicolas Saenz Julienne
2020-10-15 18:03 ` Catalin Marinas
2020-10-15 18:03 ` Catalin Marinas
2020-10-15 18:03 ` Catalin Marinas
2020-10-16 6:51 ` Hanjun Guo
2020-10-16 6:51 ` Hanjun Guo
2020-10-16 6:51 ` Hanjun Guo
2020-10-16 6:54 ` Ard Biesheuvel
2020-10-16 6:54 ` Ard Biesheuvel
2020-10-16 6:54 ` Ard Biesheuvel
2020-10-16 7:27 ` Hanjun Guo
2020-10-16 7:27 ` Hanjun Guo
2020-10-16 7:27 ` Hanjun Guo
2020-10-16 7:34 ` Hanjun Guo
2020-10-16 7:34 ` Hanjun Guo
2020-10-16 7:34 ` Hanjun Guo
2020-10-14 19:12 ` [PATCH v3 8/8] mm: Update DMA zones description Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-14 19:12 ` Nicolas Saenz Julienne
2020-10-15 5:40 ` Christoph Hellwig [this message]
2020-10-15 5:40 ` Christoph Hellwig
2020-10-15 5:40 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015054026.GC12218@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jeremy.linton@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.