From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Vitor Massaru Iha <vitor@massaru.org>
Cc: elver@google.com, mhocko@suse.com, arnd@arndb.de,
torvalds@linux-foundation.org, brendanhiggins@google.com,
linux-kernel@vger.kernel.org, elfring@users.sourceforge.net,
paul.gortmaker@windriver.com, geert@linux-m68k.org,
linux-kselftest@vger.kernel.org, tglx@linutronix.de,
linux-kernel-mentees@lists.linuxfoundation.org,
akpm@linux-foundation.org, kunit-dev@googlegroups.com
Subject: Re: [Linux-kernel-mentees] [PATCH v2] lib: kunit: add list_sort test conversion to KUnit
Date: Thu, 15 Oct 2020 13:51:05 +0300 [thread overview]
Message-ID: <20201015105105.GS4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201015014616.309000-1-vitor@massaru.org>
On Wed, Oct 14, 2020 at 10:46:16PM -0300, Vitor Massaru Iha wrote:
> This adds the conversion of the runtime tests of test_list_sort,
> from `lib/test_list_sort.c` to KUnit tests.
Please, provide better commit message. For example, add the output of _succeeded_
*and* _failed_ test cases (yes, you have to break code manually to reproduce failed
test cases) _before_ *and* _after_ the change.
W/o above information I'm going to NAK this as I promised before.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Vitor Massaru Iha <vitor@massaru.org>
Cc: kunit-dev@googlegroups.com, brendanhiggins@google.com,
elver@google.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linuxfoundation.org,
gregkh@linuxfoundation.org, tglx@linutronix.de,
geert@linux-m68k.org, paul.gortmaker@windriver.com,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
arnd@arndb.de, elfring@users.sourceforge.net, mhocko@suse.com
Subject: Re: [PATCH v2] lib: kunit: add list_sort test conversion to KUnit
Date: Thu, 15 Oct 2020 13:51:05 +0300 [thread overview]
Message-ID: <20201015105105.GS4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201015014616.309000-1-vitor@massaru.org>
On Wed, Oct 14, 2020 at 10:46:16PM -0300, Vitor Massaru Iha wrote:
> This adds the conversion of the runtime tests of test_list_sort,
> from `lib/test_list_sort.c` to KUnit tests.
Please, provide better commit message. For example, add the output of _succeeded_
*and* _failed_ test cases (yes, you have to break code manually to reproduce failed
test cases) _before_ *and* _after_ the change.
W/o above information I'm going to NAK this as I promised before.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-10-15 10:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 1:46 [Linux-kernel-mentees] [PATCH v2] lib: kunit: add list_sort test conversion to KUnit Vitor Massaru Iha
2020-10-15 1:46 ` Vitor Massaru Iha
2020-10-15 10:51 ` Andy Shevchenko [this message]
2020-10-15 10:51 ` Andy Shevchenko
2020-10-15 17:54 ` [Linux-kernel-mentees] " Vitor Massaru Iha
2020-10-15 17:54 ` Vitor Massaru Iha
2020-10-15 17:48 ` [Linux-kernel-mentees] " Andy Shevchenko
2020-10-15 17:48 ` Andy Shevchenko
2020-10-15 17:59 ` [Linux-kernel-mentees] " Vitor Massaru Iha
2020-10-15 17:59 ` Vitor Massaru Iha
2020-10-15 18:21 ` [Linux-kernel-mentees] " Andy Shevchenko
2020-10-15 18:21 ` Andy Shevchenko
2020-10-15 18:23 ` [Linux-kernel-mentees] " Andy Shevchenko
2020-10-15 18:23 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015105105.GS4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=brendanhiggins@google.com \
--cc=elfring@users.sourceforge.net \
--cc=elver@google.com \
--cc=geert@linux-m68k.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=paul.gortmaker@windriver.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vitor@massaru.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.