From: Greg KH <gregkh@linuxfoundation.org>
To: Sumera Priyadarsini <sylphrenadin@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [Outreachy][PATCH 0/3] staging: Replace snprintf() with scnprintf()
Date: Fri, 16 Oct 2020 10:24:54 +0200 [thread overview]
Message-ID: <20201016082454.GA1658723@kroah.com> (raw)
In-Reply-To: <20201015192157.GC20115@casper.infradead.org>
On Thu, Oct 15, 2020 at 08:21:57PM +0100, Matthew Wilcox wrote:
> On Fri, Oct 16, 2020 at 12:41:42AM +0530, Sumera Priyadarsini wrote:
> > The show() methods in device attributes should return the number of
> > bytes printed into the buffer which is the return value of scnprintf().
> > snprintf() returns the potential number of bytes that could be written
> > which may be greater than the actual length to be written.
>
> There's a big patchset just gone into 5.10 yesterday which adds a new
> sysfs_emit() for show methods. You probably want to use that instead
> of scnprintf().
Yes, please do that instead, I will not take these as-is, sorry.
thanks,
greg k-h
next prev parent reply other threads:[~2020-10-16 8:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 19:11 [Outreachy][PATCH 0/3] staging: Replace snprintf() with scnprintf() Sumera Priyadarsini
2020-10-15 19:14 ` [Outreachy][PATCH 1/3] staging: fbtft: " Sumera Priyadarsini
2020-10-15 19:16 ` [Outreachy][PATCH 2/3] staging: fieldbus: " Sumera Priyadarsini
2020-10-23 13:03 ` Sven Van Asbroeck
2020-10-23 13:39 ` Sumera Priyadarsini
2020-10-15 19:18 ` [Outreachy][PATCH 3/3] staging: comedi: " Sumera Priyadarsini
2020-10-16 9:14 ` Ian Abbott
2020-10-16 9:36 ` Sumera Priyadarsini
2020-10-18 19:51 ` [Outreachy kernel] " Deepak R Varma
2020-10-18 20:35 ` Helen Koike
2020-10-18 21:31 ` Julia Lawall
2020-10-15 19:21 ` [Outreachy kernel] [Outreachy][PATCH 0/3] staging: " Matthew Wilcox
2020-10-16 8:24 ` Greg KH [this message]
2020-10-16 8:44 ` Sumera Priyadarsini
2020-10-18 5:32 ` Deepak R Varma
2020-10-18 5:38 ` Greg KH
2020-10-19 6:02 ` Deepak R Varma
2020-10-19 6:09 ` Greg KH
2020-10-19 6:25 ` Deepak R Varma
2020-10-19 6:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016082454.GA1658723@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=sylphrenadin@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.