From: Deepak R Varma <mh12gx2825@gmail.com>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: Sumera Priyadarsini <sylphrenadin@gmail.com>,
outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org,
hsweeten@visionengravers.com
Subject: Re: [Outreachy kernel] Re: [Outreachy][PATCH 3/3] staging: comedi: Replace snprintf() with scnprintf()
Date: Mon, 19 Oct 2020 01:21:36 +0530 [thread overview]
Message-ID: <20201018195136.GA73063@ubuntu204> (raw)
In-Reply-To: <825f5868-49f4-509d-638d-5fcab59c8f1a@mev.co.uk>
On Fri, Oct 16, 2020 at 10:14:46AM +0100, Ian Abbott wrote:
> On 15/10/2020 20:18, Sumera Priyadarsini wrote:
> > The show() methods should return the number of bytes printed into the
> > buffer which is the return value of scnprintf(). snprintf() returns the
> > potential number of bytes that could be written which may be greater
> > than the actual length to be written.
> >
> > Replace snprintf() with the safer scnprintf() in comedi_fops.c.
> >
> > Issue found with Coccinelle.
> >
> > Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
>
> The patch is fine, but there are a couple of problems.
>
> 1) Patches for "staging" should be Cc'ed to devel@driverdev.osuosl.org .
Hi Ian,
Does this apply to ALL drivers under "staging" or only the comedi series
drivers?
Thank you,
Deepak.
>
> 2) It appears to be part of a patch series, but I have no clue about the
> other patches in the series because I haven't seen them. The patch doesn't
> look like it depends on any other patches in a series, so it should be a
> standalone patch, not part of a series.
>
> --
> -=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company )=-
> -=( registered in England & Wales. Regd. number: 02862268. )=-
> -=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
> -=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/825f5868-49f4-509d-638d-5fcab59c8f1a%40mev.co.uk.
next prev parent reply other threads:[~2020-10-18 19:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 19:11 [Outreachy][PATCH 0/3] staging: Replace snprintf() with scnprintf() Sumera Priyadarsini
2020-10-15 19:14 ` [Outreachy][PATCH 1/3] staging: fbtft: " Sumera Priyadarsini
2020-10-15 19:16 ` [Outreachy][PATCH 2/3] staging: fieldbus: " Sumera Priyadarsini
2020-10-23 13:03 ` Sven Van Asbroeck
2020-10-23 13:39 ` Sumera Priyadarsini
2020-10-15 19:18 ` [Outreachy][PATCH 3/3] staging: comedi: " Sumera Priyadarsini
2020-10-16 9:14 ` Ian Abbott
2020-10-16 9:36 ` Sumera Priyadarsini
2020-10-18 19:51 ` Deepak R Varma [this message]
2020-10-18 20:35 ` [Outreachy kernel] " Helen Koike
2020-10-18 21:31 ` Julia Lawall
2020-10-15 19:21 ` [Outreachy kernel] [Outreachy][PATCH 0/3] staging: " Matthew Wilcox
2020-10-16 8:24 ` Greg KH
2020-10-16 8:44 ` Sumera Priyadarsini
2020-10-18 5:32 ` Deepak R Varma
2020-10-18 5:38 ` Greg KH
2020-10-19 6:02 ` Deepak R Varma
2020-10-19 6:09 ` Greg KH
2020-10-19 6:25 ` Deepak R Varma
2020-10-19 6:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201018195136.GA73063@ubuntu204 \
--to=mh12gx2825@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=sylphrenadin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.