All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>
Cc: linmiaohe@huawei.com, jhubbard@nvidia.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	chris@chris-wilson.co.uk, linaro-mm-sig@lists.linaro.org,
	linux-mm@kvack.org, willy@infradead.org, airlied@redhat.com,
	akpm@linux-foundation.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 1/2] mm: mmap: fix fput in error path v2
Date: Fri, 16 Oct 2020 13:13:10 -0300	[thread overview]
Message-ID: <20201016161310.GE36674@ziepe.ca> (raw)
In-Reply-To: <20201012085203.56119-1-christian.koenig@amd.com>

On Mon, Oct 12, 2020 at 10:52:02AM +0200, Christian König wrote:
> Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..."
> adds a workaround for a bug in mmap_region.
> 
> As the comment states ->mmap() callback can change
> vma->vm_file and so we might call fput() on the wrong file.
> 
> Revert the workaround and proper fix this in mmap_region.
> 
> v2: drop the extra if in dma_buf_mmap as well
> 
> Signed-off-by: Christian König <christian.koenig@amd.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
>  drivers/dma-buf/dma-buf.c | 20 +++-----------------
>  mm/mmap.c                 |  2 +-
>  2 files changed, 4 insertions(+), 18 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Probably should Fixes that other patch Andrew pointed at

Jason
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org,
	dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
	chris@chris-wilson.co.uk, airlied@redhat.com, daniel@ffwll.ch,
	sumit.semwal@linaro.org, willy@infradead.org,
	jhubbard@nvidia.com, linmiaohe@huawei.com
Subject: Re: [PATCH 1/2] mm: mmap: fix fput in error path v2
Date: Fri, 16 Oct 2020 13:13:10 -0300	[thread overview]
Message-ID: <20201016161310.GE36674@ziepe.ca> (raw)
In-Reply-To: <20201012085203.56119-1-christian.koenig@amd.com>

On Mon, Oct 12, 2020 at 10:52:02AM +0200, Christian König wrote:
> Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..."
> adds a workaround for a bug in mmap_region.
> 
> As the comment states ->mmap() callback can change
> vma->vm_file and so we might call fput() on the wrong file.
> 
> Revert the workaround and proper fix this in mmap_region.
> 
> v2: drop the extra if in dma_buf_mmap as well
> 
> Signed-off-by: Christian König <christian.koenig@amd.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
>  drivers/dma-buf/dma-buf.c | 20 +++-----------------
>  mm/mmap.c                 |  2 +-
>  2 files changed, 4 insertions(+), 18 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Probably should Fixes that other patch Andrew pointed at

Jason

  parent reply	other threads:[~2020-10-17 19:05 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-12  8:52 [PATCH 1/2] mm: mmap: fix fput in error path v2 Christian König
2020-10-12  8:52 ` Christian König
2020-10-12  8:52 ` [PATCH 2/2] mm: introduce vma_set_file function v4 Christian König
2020-10-12  8:52   ` Christian König
2020-10-12 12:15   ` kernel test robot
2020-10-12 12:15     ` kernel test robot
2020-10-12 12:15     ` kernel test robot
2020-10-12 14:08   ` kernel test robot
2020-10-12 14:08     ` kernel test robot
2020-10-12 14:08     ` kernel test robot
2020-10-12 14:22   ` kernel test robot
2020-10-12 14:22     ` kernel test robot
2020-10-12 14:22     ` kernel test robot
2020-10-16 16:13   ` Jason Gunthorpe
2020-10-16 16:13     ` Jason Gunthorpe
2020-10-16 16:13 ` Jason Gunthorpe [this message]
2020-10-16 16:13   ` [PATCH 1/2] mm: mmap: fix fput in error path v2 Jason Gunthorpe
2020-11-04  8:03 ` Christian König
2020-11-04  8:03   ` Christian König
  -- strict thread matches above, loose matches on Subject: below --
2020-11-06 11:48 cleanup a fix and add the vma_set_file function Christian König
2020-11-06 11:48 ` [PATCH 1/2] mm: mmap: fix fput in error path v2 Christian König
2020-11-06 11:48   ` Christian König
2020-11-06 22:48   ` Andrew Morton
2020-11-06 22:48     ` Andrew Morton
2020-11-18 10:57     ` Christian König
2020-11-18 10:57       ` Christian König
2020-11-18 22:27       ` Andrew Morton
2020-11-18 22:27         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201016161310.GE36674@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=airlied@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=ckoenig.leichtzumerken@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jhubbard@nvidia.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.