From: Jason Gunthorpe <jgg@ziepe.ca>
To: Jianxin Xiong <jianxin.xiong@intel.com>
Cc: linux-rdma@vger.kernel.org, dri-devel@lists.freedesktop.org,
Doug Ledford <dledford@redhat.com>,
Leon Romanovsky <leon@kernel.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Christian Koenig <christian.koenig@amd.com>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH v5 1/5] RDMA/umem: Support importing dma-buf as user memory region
Date: Fri, 16 Oct 2020 15:59:59 -0300 [thread overview]
Message-ID: <20201016185959.GC37159@ziepe.ca> (raw)
In-Reply-To: <1602799365-138199-1-git-send-email-jianxin.xiong@intel.com>
On Thu, Oct 15, 2020 at 03:02:45PM -0700, Jianxin Xiong wrote:
> +static void ib_umem_dmabuf_invalidate_cb(struct dma_buf_attachment *attach)
> +{
> + struct ib_umem_dmabuf *umem_dmabuf = attach->importer_priv;
> +
> + dma_resv_assert_held(umem_dmabuf->attach->dmabuf->resv);
> +
> + ib_umem_dmabuf_unmap_pages(&umem_dmabuf->umem, true);
> + queue_work(ib_wq, &umem_dmabuf->work);
Do we really want to queue remapping or should it wait until there is
a page fault?
What do GPUs do?
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Jianxin Xiong <jianxin.xiong@intel.com>
Cc: Leon Romanovsky <leon@kernel.org>,
linux-rdma@vger.kernel.org, dri-devel@lists.freedesktop.org,
Doug Ledford <dledford@redhat.com>,
Daniel Vetter <daniel.vetter@intel.com>,
Christian Koenig <christian.koenig@amd.com>
Subject: Re: [PATCH v5 1/5] RDMA/umem: Support importing dma-buf as user memory region
Date: Fri, 16 Oct 2020 15:59:59 -0300 [thread overview]
Message-ID: <20201016185959.GC37159@ziepe.ca> (raw)
In-Reply-To: <1602799365-138199-1-git-send-email-jianxin.xiong@intel.com>
On Thu, Oct 15, 2020 at 03:02:45PM -0700, Jianxin Xiong wrote:
> +static void ib_umem_dmabuf_invalidate_cb(struct dma_buf_attachment *attach)
> +{
> + struct ib_umem_dmabuf *umem_dmabuf = attach->importer_priv;
> +
> + dma_resv_assert_held(umem_dmabuf->attach->dmabuf->resv);
> +
> + ib_umem_dmabuf_unmap_pages(&umem_dmabuf->umem, true);
> + queue_work(ib_wq, &umem_dmabuf->work);
Do we really want to queue remapping or should it wait until there is
a page fault?
What do GPUs do?
Jason
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-10-16 19:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 22:02 [PATCH v5 1/5] RDMA/umem: Support importing dma-buf as user memory region Jianxin Xiong
2020-10-15 22:02 ` Jianxin Xiong
2020-10-16 18:59 ` Jason Gunthorpe [this message]
2020-10-16 18:59 ` Jason Gunthorpe
2020-10-16 20:16 ` Xiong, Jianxin
2020-10-16 20:16 ` Xiong, Jianxin
2020-10-18 18:05 ` Daniel Vetter
2020-10-18 18:05 ` Daniel Vetter
2020-10-17 0:28 ` Jason Gunthorpe
2020-10-17 0:28 ` Jason Gunthorpe
2020-10-17 0:57 ` Xiong, Jianxin
2020-10-17 0:57 ` Xiong, Jianxin
2020-10-17 1:04 ` Jason Gunthorpe
2020-10-17 1:04 ` Jason Gunthorpe
2020-10-19 5:28 ` Xiong, Jianxin
2020-10-19 5:28 ` Xiong, Jianxin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016185959.GC37159@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@intel.com \
--cc=dledford@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jianxin.xiong@intel.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.