drivers/tty/serial/8250/8250_fsl.c:109:3-10: line 109 is redundant because platform_get_irq() already prints an error

drivers/tty/serial/8250/8250_fsl.c:109:3-10: line 109 is redundant because platform_get_irq() already prints an error

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: kuldip dwivedi <kuldip.dwivedi@puresoftware.com>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   7cf726a59435301046250c42131554d9ccc566b8
commit: 11361610b00500c4afe269ff5a4fe06d58f0a3d0 serial: 8250_fsl: Add ACPI support
date:   6 weeks ago
:::::: branch date: 27 hours ago
:::::: commit date: 6 weeks ago
config: arm64-randconfig-c003-20201019 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


"coccinelle warnings: (new ones prefixed by >>)"
>> drivers/tty/serial/8250/8250_fsl.c:109:3-10: line 109 is redundant because platform_get_irq() already prints an error

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 29580 bytes --]

[PATCH] serial: 8250_fsl: fix platform_get_irq.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1498 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: kuldip dwivedi <kuldip.dwivedi@puresoftware.com>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: Jiri Slaby <jirislaby@kernel.org>
CC: Dmitry Safonov <0x7f454c46@gmail.com>
CC: linux-serial(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/tty/serial/8250/8250_fsl.c:109:3-10: line 109 is redundant because platform_get_irq() already prints an error

 Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: 11361610b005 ("serial: 8250_fsl: Add ACPI support")
CC: kuldip dwivedi <kuldip.dwivedi@puresoftware.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   7cf726a59435301046250c42131554d9ccc566b8
commit: 11361610b00500c4afe269ff5a4fe06d58f0a3d0 serial: 8250_fsl: Add ACPI support
:::::: branch date: 27 hours ago
:::::: commit date: 6 weeks ago

Please take the patch only if it's a positive warning. Thanks!

 8250_fsl.c |    2 --
 1 file changed, 2 deletions(-)

--- a/drivers/tty/serial/8250/8250_fsl.c
+++ b/drivers/tty/serial/8250/8250_fsl.c
@@ -105,8 +105,6 @@ static int fsl8250_acpi_probe(struct pla
 
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0) {
-		if (irq != -EPROBE_DEFER)
-			dev_err(dev, "cannot get irq\n");
 		return irq;
 	}